Skip to content

Commit 40d749a

Browse files
Merge pull request #1136 from Geode-solutions/perf/build
fix(Build): improve build time
2 parents 22e5288 + 0d911d0 commit 40d749a

File tree

119 files changed

+2340
-1596
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

119 files changed

+2340
-1596
lines changed

bindings/python/src/basic/attribute.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
#include "../common.hpp"
2525

2626
#include <geode/basic/attribute.hpp>
27+
#include <geode/basic/constant_attribute.hpp>
28+
#include <geode/basic/sparse_attribute.hpp>
29+
#include <geode/basic/variable_attribute.hpp>
30+
2731
namespace geode
2832
{
2933
template < typename type >

bindings/python/src/basic/attribute_manager.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,12 @@
2424
#include "../common.hpp"
2525

2626
#include <geode/basic/attribute_manager.hpp>
27+
#include <geode/basic/constant_attribute.hpp>
28+
#include <geode/basic/sparse_attribute.hpp>
29+
#include <geode/basic/variable_attribute.hpp>
30+
2731
#include <typeinfo>
32+
2833
namespace geode
2934
{
3035
template < typename type >

include/geode/basic/algorithm.hpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,10 +132,4 @@ namespace geode
132132
const auto last = std::unique( container.begin(), container.end() );
133133
container.erase( last, container.end() );
134134
}
135-
136-
/*!
137-
* Concatenate tuples into a single tuple.
138-
*/
139-
template < typename... tuples >
140-
using tuple_cat = decltype( std::tuple_cat( std::declval< tuples >()... ) );
141135
} // namespace geode

include/geode/basic/assert.hpp

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,11 @@
2424
#pragma once
2525

2626
#include <array>
27-
#include <sstream>
2827
#include <stdexcept>
2928
#include <string>
3029

3130
#include <absl/base/optimization.h>
3231
#include <absl/debugging/stacktrace.h>
33-
#include <absl/debugging/symbolize.h>
3432
#include <absl/strings/str_cat.h>
3533

3634
#include <geode/basic/opengeode_basic_export.hpp>
@@ -50,7 +48,7 @@ namespace geode
5048
* return geode_lippincott();
5149
* }
5250
*/
53-
class OpenGeodeException : public std::runtime_error
51+
class opengeode_basic_api OpenGeodeException : public std::runtime_error
5452
{
5553
static constexpr int MAX_STACK_DEPTH = 10;
5654
static constexpr int NB_SKIPPED_STACKS = 1;
@@ -68,25 +66,7 @@ namespace geode
6866

6967
~OpenGeodeException() noexcept override = default;
7068

71-
[[nodiscard]] std::string stack_trace() const
72-
{
73-
std::string stack_string;
74-
for( auto frame = 0; frame < stack_size_; ++frame )
75-
{
76-
absl::StrAppend( &stack_string, " ", frame, ": " );
77-
if( std::array< char, SYMBOL_SIZE > symbol; absl::Symbolize(
78-
stack_[frame], symbol.data(), sizeof( symbol ) ) )
79-
{
80-
absl::StrAppend( &stack_string, symbol.data() );
81-
}
82-
else
83-
{
84-
absl::StrAppend( &stack_string, "Unknown" );
85-
}
86-
absl::StrAppend( &stack_string, "\n" );
87-
}
88-
return stack_string;
89-
}
69+
[[nodiscard]] std::string stack_trace() const;
9070

9171
private:
9272
std::array< void*, MAX_STACK_DEPTH > stack_;

0 commit comments

Comments
 (0)