PR review

panquez · panquez · commit 50bdd158cb0e · 2024-08-29T09:18:39.000+02:00
diff --git a/include/geode/basic/algorithm.hpp b/include/geode/basic/algorithm.hpp
@@ -36,7 +36,13 @@ namespace geode
     template < typename Container >
     void concatenate( Container& container, const Container& values )
     {
-        container.insert( container.end(), values.begin(), values.end() );
+        absl::c_copy( values, std::back_inserter( container ) );
+    }
+
+    template < typename Container >
+    void concatenate( Container& container, Container&& values )
+    {
+        absl::c_move( values, std::back_inserter( container ) );
     }
 
     /*!

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,13 @@ namespace geode`
`36`	`36`	`template < typename Container >`
`37`	`37`	`void concatenate( Container& container, const Container& values )`
`38`	`38`	`{`
`39`		`- container.insert( container.end(), values.begin(), values.end() );`
	`39`	`+ absl::c_copy( values, std::back_inserter( container ) );`
	`40`	`+ }`
	`41`	`+`
	`42`	`+ template < typename Container >`
	`43`	`+ void concatenate( Container& container, Container&& values )`
	`44`	`+ {`
	`45`	`+ absl::c_move( values, std::back_inserter( container ) );`
`40`	`46`	`}`
`41`	`47`
`42`	`48`	`/*!`