fix(Geometry): return only positive or null value for point_tetrahedron_distance

Author: panquez

src/geode/geometry/distance.cpp

@@ -937,16 +937,10 @@ namespace geode
         const auto& facet_vertices =
             Tetrahedron::tetrahedron_facet_vertex[facet];
         const auto& vertices = tetra.vertices();
-        const auto output = point_triangle_signed_distance( point,
+        const auto output = point_triangle_distance( point,
             Triangle3D{ vertices[facet_vertices[0]],
                 vertices[facet_vertices[1]], vertices[facet_vertices[2]] } );
-        // Tetra facet normals point towards inside
-        if( tetrahedron_volume_sign( tetra ) == Sign::negative )
-        {
-            return output;
-        }
-        return std::make_tuple(
-            -std::get< 0 >( output ), std::get< 1 >( output ) );
+        return output;
     }
 
     std::tuple< double, Point3D > point_triangle_signed_distance(

tests/geometry/test-distance.cpp

@@ -748,16 +748,14 @@ void test_point_tetrahedron_distance()
             geode::point_tetrahedron_distance( q1, tetra );
         OPENGEODE_EXCEPTION( distance == 0 && closest_point == q1,
             "[Test] Wrong result for point_tetrahedron_distance with query "
-            "Point3D "
-            "q1" );
+            "Point3D q1" );
 
         const geode::Point3D q2{ { 0.25, 0.25, 0.0 } };
         std::tie( distance, closest_point ) =
             geode::point_tetrahedron_distance( q2, tetra );
         OPENGEODE_EXCEPTION( distance == 0 && closest_point == q2,
             "[Test] Wrong result for point_tetrahedron_distance with query "
-            "Point3D "
-            "q2" );
+            "Point3D q2" );
 
         const geode::Point3D q3{ { 2.5, 2.5, 0.0 } };
         std::tie( distance, closest_point ) =
@@ -766,8 +764,7 @@ void test_point_tetrahedron_distance()
         OPENGEODE_EXCEPTION(
             distance == std::sqrt( 8 ) && closest_point.inexact_equal( answer ),
             "[Test] Wrong result for point_tetrahedron_distance with query "
-            "Point3D "
-            "q3" );
+            "Point3D q3" );
     };
 
     const geode::Point3D a{ { 0.0, 0.0, 0.0 } };