fix(BoundingBox): avoid to return invalid BoundingBox

Author: panquez

src/geode/mesh/core/edged_curve.cpp

@@ -158,6 +158,9 @@ namespace geode
     template < index_t dimension >
     BoundingBox< dimension > EdgedCurve< dimension >::bounding_box() const
     {
+        OPENGEODE_EXCEPTION( nb_vertices() != 0,
+            "[EdgedCurve::bounding_box] Cannot return "
+            "the bounding_box of an empty edged curve." );
         BoundingBox< dimension > box;
         for( const auto p : Range{ nb_vertices() } )
         {

src/geode/mesh/core/point_set.cpp

@@ -86,6 +86,9 @@ namespace geode
     template < index_t dimension >
     BoundingBox< dimension > PointSet< dimension >::bounding_box() const
     {
+        OPENGEODE_EXCEPTION( nb_vertices() != 0,
+            "[PointSet::bounding_box] Cannot return "
+            "the bounding_box of an empty point set." );
         BoundingBox< dimension > box;
         for( const auto p : Range{ nb_vertices() } )
         {

src/geode/mesh/core/solid_mesh.cpp

@@ -1731,6 +1731,9 @@ namespace geode
     template < index_t dimension >
     BoundingBox< dimension > SolidMesh< dimension >::bounding_box() const
     {
+        OPENGEODE_EXCEPTION( nb_vertices() != 0,
+            "[SolidMesh::bounding_box] Cannot return "
+            "the bounding_box of an empty solid mesh." );
         BoundingBox< dimension > box;
         for( const auto p : Range{ nb_vertices() } )
         {

src/geode/mesh/core/surface_mesh.cpp

@@ -1064,6 +1064,9 @@ namespace geode
     template < index_t dimension >
     BoundingBox< dimension > SurfaceMesh< dimension >::bounding_box() const
     {
+        OPENGEODE_EXCEPTION( nb_vertices() != 0,
+            "[SurfaceMesh::bounding_box] Cannot return "
+            "the bounding_box of an empty surface mesh." );
         BoundingBox< dimension > box;
         for( const auto p : Range{ nb_vertices() } )
         {

src/geode/model/representation/core/brep.cpp

@@ -890,40 +890,50 @@ namespace geode
 
     BoundingBox3D BRep::bounding_box() const
     {
-        if( nb_surfaces() > 0 )
-        {
-            return internal::meshes_bounding_box< 3 >( surfaces() );
-        }
-        if( nb_blocks() > 0 )
+        geode::BoundingBox3D box;
+        box.add_box( internal::meshes_bounding_box< 3 >( surfaces() ) );
+        box.add_box( internal::meshes_bounding_box< 3 >( lines() ) );
+        box.add_box( internal::meshes_bounding_box< 3 >( corners() ) );
+        try
         {
-            return internal::meshes_bounding_box< 3 >( blocks() );
+            box.add_box( internal::meshes_bounding_box< 3 >( blocks() ) );
         }
-        if( nb_lines() > 0 )
+        catch( const OpenGeodeException& )
         {
-            return internal::meshes_bounding_box< 3 >( lines() );
+            OPENGEODE_EXCEPTION(
+                nb_corners() > 0 || nb_lines() > 0 || nb_surfaces() > 0,
+                "[BRep::bounding_box] Cannot return the bounding_box of a BRep "
+                "with not meshes Blocks and no Corners, no Lines and no "
+                "Surfaces." );
         }
-        return internal::meshes_bounding_box< 3 >( corners() );
+        OPENGEODE_EXCEPTION( box.min() <= box.max(),
+            "[BRep::bounding_box] Cannot return the "
+            "bounding_box of an empty BRep." );
+        return box;
     }
 
     BoundingBox3D BRep::active_components_bounding_box() const
     {
         geode::BoundingBox3D box;
-        for( const auto& corner : active_corners() )
-        {
-            box.add_box( corner.mesh().bounding_box() );
-        }
-        for( const auto& line : active_lines() )
-        {
-            box.add_box( line.mesh().bounding_box() );
-        }
-        for( const auto& surface : active_surfaces() )
+        box.add_box( internal::meshes_bounding_box< 3 >( active_corners() ) );
+        box.add_box( internal::meshes_bounding_box< 3 >( active_lines() ) );
+        box.add_box( internal::meshes_bounding_box< 3 >( active_surfaces() ) );
+        try
         {
-            box.add_box( surface.mesh().bounding_box() );
+            box.add_box(
+                internal::meshes_bounding_box< 3 >( active_blocks() ) );
         }
-        for( const auto& block : active_blocks() )
+        catch( const OpenGeodeException& )
         {
-            box.add_box( block.mesh().bounding_box() );
+            for( const auto& block : active_blocks() )
+            {
+                box.add_box(
+                    internal::meshes_bounding_box< 3 >( boundaries( block ) ) );
+            }
         }
+        OPENGEODE_EXCEPTION( box.min() <= box.max(),
+            "[BRep::bounding_box] Cannot return the "
+            "bounding_box of a full inactive BRep." );
         return box;
     }