fix(delete_vector_elements): Start deletion only at first point to delete, to avoid undefined behavior when moving an element to its own place.

MelchiorSchuh · BotellaA · commit 677e8cef908a · 2022-11-23T18:49:22.000+01:00
diff --git a/include/geode/basic/algorithm.h b/include/geode/basic/algorithm.h
@@ -50,12 +50,13 @@ namespace geode
         OPENGEODE_ASSERT( to_delete.size() == values.size(),
             "[delete_vector_elements] Number of elements in the two vectors "
             "should match" );
-        index_t nb_removed_elements{ 0 };
-        if( absl::c_find( to_delete, true ) == to_delete.end() )
+        const auto it = absl::c_find( to_delete, true );
+        if( it == to_delete.end() )
         {
             return 0;
         }
-        for( const auto i : Indices{ to_delete } )
+        index_t nb_removed_elements{ 0 };
+        for( const auto i : Range{ it - to_delete.begin(), to_delete.size() } )
         {
             if( to_delete[i] )
             {

Original file line number	Diff line number	Diff line change
`@@ -50,12 +50,13 @@ namespace geode`
`50`	`50`	`OPENGEODE_ASSERT( to_delete.size() == values.size(),`
`51`	`51`	`"[delete_vector_elements] Number of elements in the two vectors "`
`52`	`52`	`"should match" );`
`53`		`- index_t nb_removed_elements{ 0 };`
`54`		`- if( absl::c_find( to_delete, true ) == to_delete.end() )`
	`53`	`+ const auto it = absl::c_find( to_delete, true );`
	`54`	`+ if( it == to_delete.end() )`
`55`	`55`	`{`
`56`	`56`	`return 0;`
`57`	`57`	`}`
`58`		`- for( const auto i : Indices{ to_delete } )`
	`58`	`+ index_t nb_removed_elements{ 0 };`
	`59`	`+ for( const auto i : Range{ it - to_delete.begin(), to_delete.size() } )`
`59`	`60`	`{`
`60`	`61`	`if( to_delete[i] )`
`61`	`62`	`{`