fixing bug with nan

benoit2776 · benoit2776 · commit 7d9a435b8d30 · 2025-09-16T14:33:35.000+02:00
diff --git a/src/geode/geometry/quality.cpp b/src/geode/geometry/quality.cpp
@@ -274,8 +274,13 @@ namespace geode
                     compute_angle( point, point_prev, point_next );
                 sinus[v] = std::sin( angle );
             }
-            return 4 * sinus[0] * sinus[1] * sinus[2]
-                   / ( sinus[0] + sinus[1] + sinus[2] );
+            const auto quality = 4 * sinus[0] * sinus[1] * sinus[2]
+                                 / ( sinus[0] + sinus[1] + sinus[2] );
+            if( std::isnan( quality ) )
+            {
+                return 0;
+            }
+            return quality;
         }
         catch( ... )
         {

Original file line number	Diff line number	Diff line change
`@@ -274,8 +274,13 @@ namespace geode`
`274`	`274`	`compute_angle( point, point_prev, point_next );`
`275`	`275`	`sinus[v] = std::sin( angle );`
`276`	`276`	`}`
`277`		`- return 4 * sinus[0] * sinus[1] * sinus[2]`
`278`		`- / ( sinus[0] + sinus[1] + sinus[2] );`
	`277`	`+ const auto quality = 4 * sinus[0] * sinus[1] * sinus[2]`
	`278`	`+ / ( sinus[0] + sinus[1] + sinus[2] );`
	`279`	`+ if( std::isnan( quality ) )`
	`280`	`+ {`
	`281`	`+ return 0;`
	`282`	`+ }`
	`283`	`+ return quality;`
`279`	`284`	`}`
`280`	`285`	`catch( ... )`
`281`	`286`	`{`