Merge pull request #1162 from Geode-solutions/fix/issue-142

MelchiorSchuh · web-flow · commit 80ca4d7f4a17 · 2025-07-03T14:22:21.000+02:00
fix(GraphBuilder): remove too much restrictive assert
diff --git a/src/geode/mesh/builder/graph_builder.cpp b/src/geode/mesh/builder/graph_builder.cpp
@@ -129,9 +129,6 @@ namespace geode
 
     index_t GraphBuilder::create_edge( index_t v0_id, index_t v1_id )
     {
-        OPENGEODE_ASSERT( v0_id != v1_id, "[GraphBuilder::create_edge] "
-                                          "Trying to create an edge with "
-                                          "same extremities" );
         const auto added_edge = graph_.nb_edges();
         create_edge();
         set_edge_vertex( { added_edge, 0 }, v0_id );

Original file line number	Diff line number	Diff line change
`@@ -129,9 +129,6 @@ namespace geode`
`129`	`129`
`130`	`130`	`index_t GraphBuilder::create_edge( index_t v0_id, index_t v1_id )`
`131`	`131`	`{`
`132`		`- OPENGEODE_ASSERT( v0_id != v1_id, "[GraphBuilder::create_edge] "`
`133`		`- "Trying to create an edge with "`
`134`		`- "same extremities" );`
`135`	`132`	`const auto added_edge = graph_.nb_edges();`
`136`	`133`	`create_edge();`
`137`	`134`	`set_edge_vertex( { added_edge, 0 }, v0_id );`