Apply prepare changes

BotellaA · BotellaA · commit 94da2e7ee393 · 2024-09-11T13:30:40.000+02:00
diff --git a/bindings/python/requirements.txt b/bindings/python/requirements.txt
@@ -2,5 +2,5 @@
 # This file is autogenerated by pip-compile with Python 3.10
 # by the following command:
 #
-#    pip-compile bindings/python/requirements.in
+#    pip-compile --pre bindings/python/requirements.in
 #
diff --git a/include/geode/basic/cell_array.hpp b/include/geode/basic/cell_array.hpp
@@ -56,17 +56,20 @@ namespace geode
 
         [[nodiscard]] index_t nb_cells_in_direction( index_t direction ) const;
 
-        [[nodiscard]] virtual index_t cell_index( const CellIndices& index ) const = 0;
+        [[nodiscard]] virtual index_t cell_index(
+            const CellIndices& index ) const = 0;
 
-        [[nodiscard]] virtual CellIndices cell_indices( index_t index ) const = 0;
+        [[nodiscard]] virtual CellIndices cell_indices(
+            index_t index ) const = 0;
 
         [[nodiscard]] std::optional< CellIndices > next_cell(
             const CellIndices& index, index_t direction ) const;
 
         [[nodiscard]] std::optional< CellIndices > previous_cell(
             const CellIndices& index, index_t direction ) const;
 
-        [[nodiscard]] bool is_cell_on_border( const CellIndices& cell_indices ) const;
+        [[nodiscard]] bool is_cell_on_border(
+            const CellIndices& cell_indices ) const;
 
     protected:
         CellArray();
diff --git a/include/geode/basic/detail/geode_input_impl.hpp b/include/geode/basic/detail/geode_input_impl.hpp
@@ -73,8 +73,9 @@ namespace geode
         }
 
         template < typename Factory, typename... Args >
-        [[nodiscard]]typename Factory::BaseClass::InputData geode_object_input_impl(
-            std::string_view type, std::string_view filename, Args... args )
+        [[nodiscard]] typename Factory::BaseClass::InputData
+            geode_object_input_impl(
+                std::string_view type, std::string_view filename, Args... args )
         {
             const Timer timer;
             auto input = geode_object_input_reader< Factory >( filename );
diff --git a/include/geode/basic/detail/geode_output_impl.hpp b/include/geode/basic/detail/geode_output_impl.hpp
@@ -40,7 +40,7 @@ namespace geode
     namespace detail
     {
         template < typename Factory >
-        [[nodiscard]]std::unique_ptr< typename Factory::BaseClass >
+        [[nodiscard]] std::unique_ptr< typename Factory::BaseClass >
             geode_object_output_writer( std::string_view& filename )
         {
             filename = absl::StripAsciiWhitespace( filename );
diff --git a/include/geode/basic/factory.hpp b/include/geode/basic/factory.hpp
@@ -119,8 +119,8 @@ namespace geode
 
     private:
         template < typename DerivedClass >
-        [[nodiscard]] static inline std::unique_ptr< BaseClass > create_function_impl(
-            Args... args )
+        [[nodiscard]] static inline std::unique_ptr< BaseClass >
+            create_function_impl( Args... args )
         {
             return std::unique_ptr< BaseClass >{ new DerivedClass{
                 std::forward< Args >( args )... } };
diff --git a/include/geode/basic/file.hpp b/include/geode/basic/file.hpp
@@ -31,7 +31,8 @@
 
 namespace geode
 {
-    [[nodiscard]] bool opengeode_basic_api file_exists( std::string_view file_path );
+    [[nodiscard]] bool opengeode_basic_api file_exists(
+        std::string_view file_path );
 
     void opengeode_basic_api check_keyword(
         std::ifstream& file, std::string_view keyword );
diff --git a/include/geode/image/core/greyscale_color.hpp b/include/geode/image/core/greyscale_color.hpp
@@ -46,7 +46,7 @@ namespace geode
 
         explicit GreyscaleColor( local_index_t value ) : value_( value ) {}
 
-       [[nodiscard]]  local_index_t value() const
+        [[nodiscard]] local_index_t value() const
         {
             return value_;
         }
@@ -56,17 +56,18 @@ namespace geode
             value_ = greyscale;
         }
 
-       [[nodiscard]]  bool operator==( const GreyscaleColor &other ) const
+        [[nodiscard]] bool operator==( const GreyscaleColor &other ) const
         {
             return value() == other.value();
         }
 
-       [[nodiscard]]  bool operator!=( const GreyscaleColor &other ) const
+        [[nodiscard]] bool operator!=( const GreyscaleColor &other ) const
         {
             return value() != other.value();
         }
 
-        [[nodiscard]] GreyscaleColor operator+( const GreyscaleColor &other ) const
+        [[nodiscard]] GreyscaleColor operator+(
+            const GreyscaleColor &other ) const
         {
             return GreyscaleColor{ static_cast< geode::local_index_t >(
                 value() / 2 + other.value() / 2 ) };
@@ -77,7 +78,7 @@ namespace geode
             set_value( ( value() + other.value() ) / 2 );
         }
 
-      [[nodiscard]]   std::string string() const
+        [[nodiscard]] std::string string() const
         {
             return absl::StrCat( value_ );
         }
diff --git a/include/geode/mesh/helpers/hausdorff_distance.hpp b/include/geode/mesh/helpers/hausdorff_distance.hpp
@@ -33,7 +33,7 @@ namespace geode
 
 namespace geode
 {
-  [[nodiscard]]  double opengeode_mesh_api hausdorff_distance(
+    [[nodiscard]] double opengeode_mesh_api hausdorff_distance(
         const TriangulatedSurface3D& mesh_A,
         const TriangulatedSurface3D& mesh_B );
 } // namespace geode
diff --git a/include/geode/mesh/io/tetrahedral_solid_output.hpp b/include/geode/mesh/io/tetrahedral_solid_output.hpp
@@ -64,7 +64,7 @@ namespace geode
     };
 
     template < index_t dimension >
-  [[nodiscard]]  bool is_tetrahedral_solid_saveable(
+    [[nodiscard]] bool is_tetrahedral_solid_saveable(
         const TetrahedralSolid< dimension >& tetrahedral_solid,
         std::string_view filename );
 
diff --git a/include/geode/model/mixin/core/component.hpp b/include/geode/model/mixin/core/component.hpp
@@ -50,7 +50,7 @@ namespace geode
         Component( Component&& other ) noexcept;
         virtual ~Component();
 
-     [[nodiscard]]   virtual ComponentType component_type() const = 0;
+        [[nodiscard]] virtual ComponentType component_type() const = 0;
 
     protected:
         Component();
diff --git a/include/geode/model/mixin/core/corner.hpp b/include/geode/model/mixin/core/corner.hpp
@@ -62,26 +62,26 @@ namespace geode
         Corner( Corner&& other ) noexcept;
         ~Corner();
 
-      [[nodiscard]]  static ComponentType component_type_static()
+        [[nodiscard]] static ComponentType component_type_static()
         {
             return ComponentType{ "Corner" };
         }
 
-      [[nodiscard]]  ComponentType component_type() const final
+        [[nodiscard]] ComponentType component_type() const final
         {
             return component_type_static();
         }
 
-      [[nodiscard]]  ComponentID component_id() const
+        [[nodiscard]] ComponentID component_id() const
         {
             return { this->component_type_static(), this->id() };
         };
 
-     [[nodiscard]]   const Mesh& mesh() const;
+        [[nodiscard]] const Mesh& mesh() const;
 
-     [[nodiscard]]   Mesh& modifiable_mesh( CornersKey key );
+        [[nodiscard]] Mesh& modifiable_mesh( CornersKey key );
 
-       [[nodiscard]] const MeshImpl& mesh_type() const;
+        [[nodiscard]] const MeshImpl& mesh_type() const;
 
     public:
         explicit Corner( CornersKey key );
@@ -94,14 +94,14 @@ namespace geode
 
         void set_corner_name( std::string_view name, CornersBuilderKey key );
 
-     [[nodiscard]]   Mesh& modifiable_mesh( CornersBuilderKey key );
+        [[nodiscard]] Mesh& modifiable_mesh( CornersBuilderKey key );
 
     private:
         Corner();
 
         explicit Corner( const MeshImpl& impl );
 
-     [[nodiscard]]   Mesh& modifiable_mesh();
+        [[nodiscard]] Mesh& modifiable_mesh();
 
         template < typename Archive >
         void serialize( Archive& archive );
diff --git a/include/geode/model/representation/builder/brep_builder.hpp b/include/geode/model/representation/builder/brep_builder.hpp
@@ -117,31 +117,31 @@ namespace geode
         void copy_component_geometry(
             const ModelCopyMapping& mapping, const BRep& brep );
 
-     [[nodiscard]]   const uuid& add_corner();
+        [[nodiscard]] const uuid& add_corner();
 
-      [[nodiscard]]  const uuid& add_corner( const MeshImpl& impl );
+        [[nodiscard]] const uuid& add_corner( const MeshImpl& impl );
 
-      [[nodiscard]]  const uuid& add_line();
+        [[nodiscard]] const uuid& add_line();
 
-      [[nodiscard]]  const uuid& add_line( const MeshImpl& impl );
+        [[nodiscard]] const uuid& add_line( const MeshImpl& impl );
 
-      [[nodiscard]]  const uuid& add_surface();
+        [[nodiscard]] const uuid& add_surface();
 
-      [[nodiscard]]  const uuid& add_surface( const MeshImpl& impl );
+        [[nodiscard]] const uuid& add_surface( const MeshImpl& impl );
 
-      [[nodiscard]]  const uuid& add_block();
+        [[nodiscard]] const uuid& add_block();
 
-      [[nodiscard]]  const uuid& add_block( const MeshImpl& impl );
+        [[nodiscard]] const uuid& add_block( const MeshImpl& impl );
 
-       [[nodiscard]] const uuid& add_model_boundary();
+        [[nodiscard]] const uuid& add_model_boundary();
 
-      [[nodiscard]] const uuid& add_corner_collection();
+        [[nodiscard]] const uuid& add_corner_collection();
 
-       [[nodiscard]] const uuid& add_line_collection();
+        [[nodiscard]] const uuid& add_line_collection();
 
-     [[nodiscard]]   const uuid& add_surface_collection();
+        [[nodiscard]] const uuid& add_surface_collection();
 
-     [[nodiscard]]   const uuid& add_block_collection();
+        [[nodiscard]] const uuid& add_block_collection();
 
         void add_corner( uuid corner_id );
 
diff --git a/include/geode/model/representation/builder/detail/filter.hpp b/include/geode/model/representation/builder/detail/filter.hpp
@@ -31,13 +31,15 @@ namespace geode
     namespace detail
     {
         template < typename Last >
-      [[nodiscard]]  bool is_component_supported( const ComponentType& component_type )
+        [[nodiscard]] bool is_component_supported(
+            const ComponentType& component_type )
         {
             return component_type == Last::component_type_static();
         }
 
         template < typename First, typename Second, typename... Components >
-     [[nodiscard]]   bool is_component_supported( const ComponentType& component_type )
+        [[nodiscard]] bool is_component_supported(
+            const ComponentType& component_type )
         {
             if( component_type == First::component_type_static() )
             {
@@ -55,7 +57,7 @@ namespace geode
         template < typename... Components >
         struct ComponentsTypesChecker< std::tuple< Components... > >
         {
-           bool apply( const ComponentType& component_type ) const
+            bool apply( const ComponentType& component_type ) const
             {
                 return is_component_supported< Components... >(
                     component_type );
diff --git a/include/geode/model/representation/io/geode/geode_section_input.hpp b/include/geode/model/representation/io/geode/geode_section_input.hpp
@@ -36,13 +36,13 @@ namespace geode
         {
         }
 
-     [[nodiscard]]   static std::string_view extension()
+        [[nodiscard]] static std::string_view extension()
         {
             return Section::native_extension_static();
         }
 
         void load_section_files( Section& section, std::string_view directory );
 
-   [[nodiscard]]     Section read() final;
+        [[nodiscard]] Section read() final;
     };
 } // namespace geode
diff --git a/tests/basic/test-algorithm.cpp b/tests/basic/test-algorithm.cpp
@@ -82,9 +82,6 @@ void test_delete_vector_elements()
     geode::delete_vector_elements( to_delete, toto_vector );
     OPENGEODE_EXCEPTION( toto_vector.size() == 3,
         "[Test] Delete elements result (size) for double is not correct" );
-    toto_vector[0].front();
-    toto_vector[1].front();
-    toto_vector[2].front();
     OPENGEODE_EXCEPTION( ( toto_vector[0].front().second == 0 )
                              && ( toto_vector[1].front().second == 2 )
                              && ( toto_vector[2].front().second == 3 ),

Original file line number	Diff line number	Diff line change
`@@ -2,5 +2,5 @@`
`2`	`2`	`# This file is autogenerated by pip-compile with Python 3.10`
`3`	`3`	`# by the following command:`
`4`	`4`	`#`
`5`		`-# pip-compile bindings/python/requirements.in`
	`5`	`+# pip-compile --pre bindings/python/requirements.in`
`6`	`6`	`#`
Original file line number	Diff line number	Diff line change
`@@ -73,8 +73,9 @@ namespace geode`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`template < typename Factory, typename... Args >`
`76`		`- [[nodiscard]]typename Factory::BaseClass::InputData geode_object_input_impl(`
`77`		`- std::string_view type, std::string_view filename, Args... args )`
	`76`	`+ [[nodiscard]] typename Factory::BaseClass::InputData`
	`77`	`+ geode_object_input_impl(`
	`78`	`+ std::string_view type, std::string_view filename, Args... args )`
`78`	`79`	`{`
`79`	`80`	`const Timer timer;`
`80`	`81`	`auto input = geode_object_input_reader< Factory >( filename );`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ namespace geode`
`40`	`40`	`namespace detail`
`41`	`41`	`{`
`42`	`42`	`template < typename Factory >`
`43`		`- [[nodiscard]]std::unique_ptr< typename Factory::BaseClass >`
	`43`	`+ [[nodiscard]] std::unique_ptr< typename Factory::BaseClass >`
`44`	`44`	`geode_object_output_writer( std::string_view& filename )`
`45`	`45`	`{`
`46`	`46`	`filename = absl::StripAsciiWhitespace( filename );`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@`
`31`	`31`
`32`	`32`	`namespace geode`
`33`	`33`	`{`
`34`		`- [[nodiscard]] bool opengeode_basic_api file_exists( std::string_view file_path );`
	`34`	`+ [[nodiscard]] bool opengeode_basic_api file_exists(`
	`35`	`+ std::string_view file_path );`
`35`	`36`
`36`	`37`	`void opengeode_basic_api check_keyword(`
`37`	`38`	`std::ifstream& file, std::string_view keyword );`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ namespace geode`
`46`	`46`
`47`	`47`	`explicit GreyscaleColor( local_index_t value ) : value_( value ) {}`
`48`	`48`
`49`		`- [[nodiscard]] local_index_t value() const`
	`49`	`+ [[nodiscard]] local_index_t value() const`
`50`	`50`	`{`
`51`	`51`	`return value_;`
`52`	`52`	`}`
`@@ -56,17 +56,18 @@ namespace geode`
`56`	`56`	`value_ = greyscale;`
`57`	`57`	`}`
`58`	`58`
`59`		`- [[nodiscard]] bool operator==( const GreyscaleColor &other ) const`
	`59`	`+ [[nodiscard]] bool operator==( const GreyscaleColor &other ) const`
`60`	`60`	`{`
`61`	`61`	`return value() == other.value();`
`62`	`62`	`}`
`63`	`63`
`64`		`- [[nodiscard]] bool operator!=( const GreyscaleColor &other ) const`
	`64`	`+ [[nodiscard]] bool operator!=( const GreyscaleColor &other ) const`
`65`	`65`	`{`
`66`	`66`	`return value() != other.value();`
`67`	`67`	`}`
`68`	`68`
`69`		`- [[nodiscard]] GreyscaleColor operator+( const GreyscaleColor &other ) const`
	`69`	`+ [[nodiscard]] GreyscaleColor operator+(`
	`70`	`+ const GreyscaleColor &other ) const`
`70`	`71`	`{`
`71`	`72`	`return GreyscaleColor{ static_cast< geode::local_index_t >(`
`72`	`73`	`value() / 2 + other.value() / 2 ) };`
`@@ -77,7 +78,7 @@ namespace geode`
`77`	`78`	`set_value( ( value() + other.value() ) / 2 );`
`78`	`79`	`}`
`79`	`80`
`80`		`- [[nodiscard]] std::string string() const`
	`81`	`+ [[nodiscard]] std::string string() const`
`81`	`82`	`{`
`82`	`83`	`return absl::StrCat( value_ );`
`83`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ namespace geode`
`33`	`33`
`34`	`34`	`namespace geode`
`35`	`35`	`{`
`36`		`- [[nodiscard]] double opengeode_mesh_api hausdorff_distance(`
	`36`	`+ [[nodiscard]] double opengeode_mesh_api hausdorff_distance(`
`37`	`37`	`const TriangulatedSurface3D& mesh_A,`
`38`	`38`	`const TriangulatedSurface3D& mesh_B );`
`39`	`39`	`} // namespace geode`