Merge pull request #965 from Geode-solutions/fix/replace-absl-string-view-with-std

fix(StringView): use std::string_view

Author: panquez

bindings/python/src/basic/attribute_manager.cpp

@@ -38,21 +38,21 @@ namespace geode
             absl::StrCat( "find_or_create_attribute_constant_", suffix );
         manager.def( constant_suffix.c_str(),
             static_cast< std::shared_ptr< ConstantAttribute< type > > (
-                AttributeManager::* )( absl::string_view, type ) >(
+                AttributeManager::* )( std::string_view, type ) >(
                 &AttributeManager::find_or_create_attribute< ConstantAttribute,
                     type > ) );
         const auto variable_suffix =
             absl::StrCat( "find_or_create_attribute_variable_", suffix );
         manager.def( variable_suffix.c_str(),
             static_cast< std::shared_ptr< VariableAttribute< type > > (
-                AttributeManager::* )( absl::string_view, type ) >(
+                AttributeManager::* )( std::string_view, type ) >(
                 &AttributeManager::find_or_create_attribute< VariableAttribute,
                     type > ) );
         const auto sparse_suffix =
             absl::StrCat( "find_or_create_attribute_sparse_", suffix );
         manager.def( sparse_suffix.c_str(),
             static_cast< std::shared_ptr< SparseAttribute< type > > (
-                AttributeManager::* )( absl::string_view, type ) >(
+                AttributeManager::* )( std::string_view, type ) >(
                 &AttributeManager::find_or_create_attribute< SparseAttribute,
                     type > ) );
     }

bindings/python/src/basic/uuid.cpp

@@ -31,7 +31,7 @@ namespace geode
     {
         pybind11::class_< uuid >( module, "uuid" )
             .def( pybind11::init<>() )
-            .def( pybind11::init< absl::string_view >() )
+            .def( pybind11::init< std::string_view >() )
             .def( "string", &uuid::string );
     }
 } // namespace geode

bindings/python/src/common.h

@@ -27,7 +27,6 @@
 
 #include <absl/container/fixed_array.h>
 #include <absl/container/inlined_vector.h>
-#include <absl/strings/string_view.h>
 #include <absl/types/span.h>
 
 namespace pybind11
@@ -70,11 +69,5 @@ namespace pybind11
 
             std::vector< typename std::remove_const< Type >::type > cpp_;
         };
-
-        template <>
-        struct type_caster< absl::string_view >
-            : string_caster< absl::string_view, true >
-        {
-        };
     } // namespace detail
 } // namespace pybind11

bindings/python/src/mesh/builder/crs_manager_builder.cpp

@@ -36,7 +36,7 @@
             CoordinateReferenceSystemManager< dimension >& >() )               \
         .def( "register_coordinate_reference_system",                          \
             []( CoordinateReferenceSystemManagerBuilder< dimension >& manager, \
-                absl::string_view name,                                        \
+                std::string_view name,                                         \
                 std::shared_ptr< CoordinateReferenceSystem< dimension > >&     \
                     crs ) {                                                    \
                 manager.register_coordinate_reference_system(                  \

bindings/python/src/mesh/io/edged_curve.cpp

@@ -39,7 +39,7 @@
         "load_edged_curve" + std::to_string( dimension ) + "D";                \
     module.def( load##dimension.c_str(),                                       \
         static_cast< std::unique_ptr< EdgedCurve< dimension > > ( * )(         \
-            absl::string_view ) >( &load_edged_curve< dimension > ) );         \
+            std::string_view ) >( &load_edged_curve< dimension > ) );          \
     const auto check##dimension =                                              \
         "check_edged_curve_missing_files" + std::to_string( dimension ) + "D"; \
     module.def( check##dimension.c_str(),                                      \

bindings/python/src/mesh/io/graph.cpp

@@ -35,7 +35,7 @@ namespace geode
     {
         module.def( "save_graph", &save_graph );
         module.def( "load_graph",
-            static_cast< std::unique_ptr< Graph > ( * )( absl::string_view ) >(
+            static_cast< std::unique_ptr< Graph > ( * )( std::string_view ) >(
                 &load_graph ) );
         module.def( "check_graph_missing_files", &check_graph_missing_files );
         module.def( "is_graph_loadable", &is_graph_loadable );

bindings/python/src/mesh/io/hybrid_solid.cpp

@@ -39,7 +39,7 @@
         "load_hybrid_solid" + std::to_string( dimension ) + "D";               \
     module.def( load##dimension.c_str(),                                       \
         static_cast< std::unique_ptr< HybridSolid< dimension > > ( * )(        \
-            absl::string_view ) >( &load_hybrid_solid< dimension > ) );        \
+            std::string_view ) >( &load_hybrid_solid< dimension > ) );         \
     const auto check##dimension = "check_hybrid_solid_missing_files"           \
                                   + std::to_string( dimension ) + "D";         \
     module.def( check##dimension.c_str(),                                      \

bindings/python/src/mesh/io/light_regular_grid.cpp

@@ -40,7 +40,7 @@
         "load_light_regular_grid" + std::to_string( dimension ) + "D";         \
     module.def( load##dimension.c_str(),                                       \
         static_cast< LightRegularGrid< dimension > ( * )(                      \
-            absl::string_view ) >( &load_light_regular_grid< dimension > ) );  \
+            std::string_view ) >( &load_light_regular_grid< dimension > ) );   \
     const auto check##dimension = "check_light_regular_grid_missing_files"     \
                                   + std::to_string( dimension ) + "D";         \
     module.def( check##dimension.c_str(),                                      \

bindings/python/src/mesh/io/point_set.cpp

@@ -39,7 +39,7 @@
         "load_point_set" + std::to_string( dimension ) + "D";                  \
     module.def( load##dimension.c_str(),                                       \
         static_cast< std::unique_ptr< PointSet< dimension > > ( * )(           \
-            absl::string_view ) >( &load_point_set< dimension > ) );           \
+            std::string_view ) >( &load_point_set< dimension > ) );            \
     const auto check##dimension =                                              \
         "check_point_set_missing_files" + std::to_string( dimension ) + "D";   \
     module.def( check##dimension.c_str(),                                      \

bindings/python/src/mesh/io/polygonal_surface.cpp

@@ -40,7 +40,7 @@
         "load_polygonal_surface" + std::to_string( dimension ) + "D";          \
     module.def( load##dimension.c_str(),                                       \
         static_cast< std::unique_ptr< PolygonalSurface< dimension > > ( * )(   \
-            absl::string_view ) >( &load_polygonal_surface< dimension > ) );   \
+            std::string_view ) >( &load_polygonal_surface< dimension > ) );    \
     const auto check##dimension = "check_polygonal_surface_missing_files"      \
                                   + std::to_string( dimension ) + "D";         \
     module.def( check##dimension.c_str(),                                      \