pierre comments

Author: MelchiorSchuh

include/geode/mesh/core/solid_mesh.hpp

@@ -452,8 +452,8 @@ namespace geode
             const PolyhedronFacet& polyhedron_facet ) const;
 
         /*!
-         * Return the normal of a given PolyhedronFacet (should be oriented
-         * towards the inside of the polyhedron).
+         * Return the normal of a given PolyhedronFacet (in the geode
+         * convention, it is oriented towards the inside of the polyhedron).
          * @param[in] polyhedron_facet Local index of facet in polyhedron.
          */
         [[nodiscard]] std::optional< Vector3D > polyhedron_facet_normal(

src/geode/model/representation/core/brep.cpp

@@ -917,11 +917,7 @@ namespace geode
             bbox.add_box( block_mesh.bounding_box() );
             bbox_computed = true;
         }
-        OPENGEODE_EXCEPTION( bbox_computed,
-            "[BRep::bounding_box] Cannot return the bounding_box of a BRep "
-            "with not meshed Blocks and no Corners, no Lines and no "
-            "Surfaces." );
-        OPENGEODE_EXCEPTION( bbox.min() <= bbox.max(),
+        OPENGEODE_EXCEPTION( bbox_computed && bbox.min() <= bbox.max(),
             "[BRep::bounding_box] Cannot return the "
             "bounding_box of an empty BRep." );
         return bbox;