Merge pull request #1097 from Geode-solutions/fix/seg-fault-empty

MelchiorSchuh · web-flow · commit bfefdd3992e4 · 2025-03-04T09:12:22.000+01:00
fix(Geometry): add quick skips in BoundingBox intersects methods, bas…
diff --git a/src/geode/geometry/bounding_box.cpp b/src/geode/geometry/bounding_box.cpp
@@ -267,6 +267,10 @@ namespace geode
         {
             return false;
         }
+        if( !intersects( segment.bounding_box() ) )
+        {
+            return false;
+        }
         const auto box_center = center();
         const auto box_extent = diagonal() / 2.;
         const auto segment_origin = segment.barycenter() - box_center;
@@ -299,6 +303,10 @@ namespace geode
                 return true;
             }
         }
+        if( !intersects( triangle.bounding_box() ) )
+        {
+            return false;
+        }
         const auto triangle_projection = [&vertices]( const Vector3D& normal ) {
             BoundingBox1D interval;
             interval.add_point(

Original file line number	Diff line number	Diff line change
`@@ -267,6 +267,10 @@ namespace geode`
`267`	`267`	`{`
`268`	`268`	`return false;`
`269`	`269`	`}`
	`270`	`+ if( !intersects( segment.bounding_box() ) )`
	`271`	`+ {`
	`272`	`+ return false;`
	`273`	`+ }`
`270`	`274`	`const auto box_center = center();`
`271`	`275`	`const auto box_extent = diagonal() / 2.;`
`272`	`276`	`const auto segment_origin = segment.barycenter() - box_center;`
`@@ -299,6 +303,10 @@ namespace geode`
`299`	`303`	`return true;`
`300`	`304`	`}`
`301`	`305`	`}`
	`306`	`+ if( !intersects( triangle.bounding_box() ) )`
	`307`	`+ {`
	`308`	`+ return false;`
	`309`	`+ }`
`302`	`310`	`const auto triangle_projection = [&vertices]( const Vector3D& normal ) {`
`303`	`311`	`BoundingBox1D interval;`
`304`	`312`	`interval.add_point(`