Merge branch 'next' of https://github.com/Geode-solutions/OpenGeode into fix/changing_triangle_flip_check_when_swaping_edge

Author: benoit2776

include/geode/mesh/core/solid_mesh.hpp

@@ -452,7 +452,8 @@ namespace geode
             const PolyhedronFacet& polyhedron_facet ) const;
 
         /*!
-         * Return the normal of a given PolyhedronFacet.
+         * Return the normal of a given PolyhedronFacet (in the geode
+         * convention, it is oriented towards the inside of the polyhedron).
          * @param[in] polyhedron_facet Local index of facet in polyhedron.
          */
         [[nodiscard]] std::optional< Vector3D > polyhedron_facet_normal(

src/geode/model/helpers/ray_tracing.cpp

@@ -167,7 +167,7 @@ namespace geode
         }
         throw OpenGeodeException{
             "Cannot determine the point is inside the block or not "
-            "(ambigous intersection with rays)."
+            "(ambiguous intersection with rays)."
         };
     }
 
@@ -185,8 +185,8 @@ namespace geode
             }
         }
         throw OpenGeodeException{
-            "Cannot determine the point is inside the block or not "
-            "(ambigous intersection with rays)."
+            "Cannot determine the point is inside the closed surface 3D or not "
+            "(ambiguous intersection with rays)."
         };
     }
 
@@ -228,8 +228,8 @@ namespace geode
             }
         }
         throw OpenGeodeException{
-            "Cannot determine the point is inside the surface or not "
-            "(ambigous intersection with rays)."
+            "Cannot determine the point is inside the surface 2D or not "
+            "(ambiguous intersection with rays)."
         };
     }
 

src/geode/model/representation/core/brep.cpp

@@ -891,35 +891,33 @@ namespace geode
     BoundingBox3D BRep::bounding_box() const
     {
         geode::BoundingBox3D bbox;
+        bool bbox_computed{ false };
         if( const auto box = internal::meshes_bounding_box< 3 >( surfaces() ) )
         {
             bbox.add_box( box.value() );
+            bbox_computed = true;
         }
         if( const auto box = internal::meshes_bounding_box< 3 >( lines() ) )
         {
             bbox.add_box( box.value() );
+            bbox_computed = true;
         }
         if( const auto box = internal::meshes_bounding_box< 3 >( corners() ) )
         {
             bbox.add_box( box.value() );
+            bbox_computed = true;
         }
-        try
+        for( const auto& block : blocks() )
         {
-            if( const auto box =
-                    internal::meshes_bounding_box< 3 >( blocks() ) )
+            const auto& block_mesh = block.mesh();
+            if( block_mesh.nb_vertices() == 0 )
             {
-                bbox.add_box( box.value() );
+                continue;
             }
+            bbox.add_box( block_mesh.bounding_box() );
+            bbox_computed = true;
         }
-        catch( const OpenGeodeException& )
-        {
-            OPENGEODE_EXCEPTION(
-                nb_corners() > 0 || nb_lines() > 0 || nb_surfaces() > 0,
-                "[BRep::bounding_box] Cannot return the bounding_box of a BRep "
-                "with not meshes Blocks and no Corners, no Lines and no "
-                "Surfaces." );
-        }
-        OPENGEODE_EXCEPTION( bbox.min() <= bbox.max(),
+        OPENGEODE_EXCEPTION( bbox_computed && bbox.min() <= bbox.max(),
             "[BRep::bounding_box] Cannot return the "
             "bounding_box of an empty BRep." );
         return bbox;