feat(replace_components_meshes_by_others): Added function to replace component meshes of a BRep by another BRep's.

MelchiorSchuh · MelchiorSchuh · commit df869d9acbd3 · 2024-11-28T14:17:26.000+01:00
diff --git a/include/geode/model/mixin/builder/blocks_builder.hpp b/include/geode/model/mixin/builder/blocks_builder.hpp
@@ -86,6 +86,9 @@ namespace geode
         [[nodiscard]] SolidMesh< dimension >& modifiable_block_mesh(
             const uuid& id );
 
+        [[nodiscard]] std::unique_ptr< SolidMesh< dimension > >
+            steal_block_mesh( const uuid& id );
+
     private:
         Blocks< dimension >& blocks_;
     };
diff --git a/include/geode/model/mixin/builder/corners_builder.hpp b/include/geode/model/mixin/builder/corners_builder.hpp
@@ -78,6 +78,9 @@ namespace geode
         [[nodiscard]] PointSet< dimension >& modifiable_corner_mesh(
             const uuid& id );
 
+        [[nodiscard]] std::unique_ptr< PointSet< dimension > >
+            steal_corner_mesh( const uuid& id );
+
     private:
         Corners< dimension >& corners_;
     };
diff --git a/include/geode/model/mixin/builder/lines_builder.hpp b/include/geode/model/mixin/builder/lines_builder.hpp
@@ -75,6 +75,9 @@ namespace geode
         [[nodiscard]] EdgedCurve< dimension >& modifiable_line_mesh(
             const uuid& id );
 
+        [[nodiscard]] std::unique_ptr< EdgedCurve< dimension > >
+            steal_line_mesh( const uuid& id );
+
     private:
         Lines< dimension >& lines_;
     };
diff --git a/include/geode/model/mixin/builder/surfaces_builder.hpp b/include/geode/model/mixin/builder/surfaces_builder.hpp
@@ -86,6 +86,9 @@ namespace geode
         [[nodiscard]] SurfaceMesh< dimension >& modifiable_surface_mesh(
             const uuid& id );
 
+        [[nodiscard]] std::unique_ptr< SurfaceMesh< dimension > >
+            steal_surface_mesh( const uuid& id );
+
     private:
         Surfaces< dimension >& surfaces_;
     };
diff --git a/include/geode/model/mixin/core/block.hpp b/include/geode/model/mixin/core/block.hpp
@@ -85,12 +85,6 @@ namespace geode
 
         [[nodiscard]] const MeshImpl& mesh_type() const;
 
-        template < typename TypedMesh = Mesh >
-        [[nodiscard]] TypedMesh& modifiable_mesh( BlocksKey /*unused*/ )
-        {
-            return dynamic_cast< TypedMesh& >( get_modifiable_mesh() );
-        }
-
     public:
         explicit Block( BlocksKey key );
 
@@ -100,6 +94,12 @@ namespace geode
 
         void set_mesh( std::unique_ptr< Mesh > mesh, BlocksBuilderKey key );
 
+        template < typename TypedMesh = Mesh >
+        [[nodiscard]] TypedMesh& modifiable_mesh( BlocksKey /*unused*/ )
+        {
+            return dynamic_cast< TypedMesh& >( get_modifiable_mesh() );
+        }
+
         template < typename TypedMesh = Mesh >
         [[nodiscard]] TypedMesh& modifiable_mesh( BlocksBuilderKey /*unused*/ )
         {
@@ -108,6 +108,9 @@ namespace geode
 
         void set_block_name( std::string_view name, BlocksBuilderKey key );
 
+        [[nodiscard]] std::unique_ptr< Mesh > steal_mesh(
+            BlocksBuilderKey key );
+
     private:
         Block();
 
diff --git a/include/geode/model/mixin/core/corner.hpp b/include/geode/model/mixin/core/corner.hpp
@@ -79,8 +79,6 @@ namespace geode
 
         [[nodiscard]] const Mesh& mesh() const;
 
-        [[nodiscard]] Mesh& modifiable_mesh( CornersKey key );
-
         [[nodiscard]] const MeshImpl& mesh_type() const;
 
     public:
@@ -94,8 +92,13 @@ namespace geode
 
         void set_corner_name( std::string_view name, CornersBuilderKey key );
 
+        [[nodiscard]] Mesh& modifiable_mesh( CornersKey key );
+
         [[nodiscard]] Mesh& modifiable_mesh( CornersBuilderKey key );
 
+        [[nodiscard]] std::unique_ptr< Mesh > steal_mesh(
+            CornersBuilderKey key );
+
     private:
         Corner();
 
diff --git a/include/geode/model/mixin/core/detail/mesh_storage.hpp b/include/geode/model/mixin/core/detail/mesh_storage.hpp
@@ -59,6 +59,11 @@ namespace geode
                 return *mesh_;
             }
 
+            [[nodiscard]] std::unique_ptr< Mesh > steal_mesh()
+            {
+                return std::move( mesh_ );
+            }
+
             [[nodiscard]] const MeshImpl& mesh_type() const
             {
                 return mesh_type_;
diff --git a/include/geode/model/mixin/core/line.hpp b/include/geode/model/mixin/core/line.hpp
@@ -80,8 +80,6 @@ namespace geode
 
         [[nodiscard]] const MeshImpl& mesh_type() const;
 
-        [[nodiscard]] Mesh& modifiable_mesh( LinesKey key );
-
     public:
         explicit Line( LinesKey key );
 
@@ -93,8 +91,12 @@ namespace geode
 
         void set_line_name( std::string_view name, LinesBuilderKey key );
 
+        [[nodiscard]] Mesh& modifiable_mesh( LinesKey key );
+
         [[nodiscard]] Mesh& modifiable_mesh( LinesBuilderKey key );
 
+        [[nodiscard]] std::unique_ptr< Mesh > steal_mesh( LinesBuilderKey key );
+
     private:
         Line();
 
diff --git a/include/geode/model/mixin/core/surface.hpp b/include/geode/model/mixin/core/surface.hpp
@@ -108,6 +108,9 @@ namespace geode
             return dynamic_cast< TypedMesh& >( get_modifiable_mesh() );
         }
 
+        [[nodiscard]] std::unique_ptr< Mesh > steal_mesh(
+            SurfacesBuilderKey key );
+
     private:
         Surface();
 
diff --git a/include/geode/model/representation/builder/brep_builder.hpp b/include/geode/model/representation/builder/brep_builder.hpp
@@ -110,6 +110,9 @@ namespace geode
 
         ModelCopyMapping copy( const BRep& brep );
 
+        void replace_components_meshes_by_others(
+            BRep&& other, const ModelCopyMapping& mapping );
+
         ModelCopyMapping copy_components( const BRep& brep );
 
         void copy_components( ModelCopyMapping& mapping, const BRep& brep );
diff --git a/src/geode/model/mixin/builder/blocks_builder.cpp b/src/geode/model/mixin/builder/blocks_builder.cpp
@@ -94,5 +94,13 @@ namespace geode
             typename Block< dimension >::BlocksBuilderKey{} );
     }
 
+    template < index_t dimension >
+    std::unique_ptr< SolidMesh< dimension > >
+        BlocksBuilder< dimension >::steal_block_mesh( const uuid& id )
+    {
+        return blocks_.modifiable_block( id, {} ).steal_mesh(
+            typename Block< dimension >::BlocksBuilderKey{} );
+    }
+
     template class opengeode_model_api BlocksBuilder< 3 >;
 } // namespace geode
diff --git a/src/geode/model/mixin/builder/corners_builder.cpp b/src/geode/model/mixin/builder/corners_builder.cpp
@@ -104,6 +104,14 @@ namespace geode
             typename Corner< dimension >::CornersBuilderKey{} );
     }
 
+    template < index_t dimension >
+    std::unique_ptr< PointSet< dimension > >
+        CornersBuilder< dimension >::steal_corner_mesh( const uuid& id )
+    {
+        return corners_.modifiable_corner( id, {} ).steal_mesh(
+            typename Corner< dimension >::CornersBuilderKey{} );
+    }
+
     template class opengeode_model_api CornersBuilder< 2 >;
     template class opengeode_model_api CornersBuilder< 3 >;
 } // namespace geode
diff --git a/src/geode/model/mixin/builder/lines_builder.cpp b/src/geode/model/mixin/builder/lines_builder.cpp
@@ -102,6 +102,14 @@ namespace geode
             typename Line< dimension >::LinesBuilderKey{} );
     }
 
+    template < index_t dimension >
+    std::unique_ptr< EdgedCurve< dimension > >
+        LinesBuilder< dimension >::steal_line_mesh( const uuid& id )
+    {
+        return lines_.modifiable_line( id, {} ).steal_mesh(
+            typename Line< dimension >::LinesBuilderKey{} );
+    }
+
     template class opengeode_model_api LinesBuilder< 2 >;
     template class opengeode_model_api LinesBuilder< 3 >;
 } // namespace geode
diff --git a/src/geode/model/mixin/builder/surfaces_builder.cpp b/src/geode/model/mixin/builder/surfaces_builder.cpp
@@ -95,6 +95,14 @@ namespace geode
             typename Surface< dimension >::SurfacesBuilderKey{} );
     }
 
+    template < index_t dimension >
+    std::unique_ptr< SurfaceMesh< dimension > >
+        SurfacesBuilder< dimension >::steal_surface_mesh( const uuid& id )
+    {
+        return surfaces_.modifiable_surface( id, {} ).steal_mesh(
+            typename Surface< dimension >::SurfacesBuilderKey{} );
+    }
+
     template class opengeode_model_api SurfacesBuilder< 2 >;
     template class opengeode_model_api SurfacesBuilder< 3 >;
 } // namespace geode
diff --git a/src/geode/model/mixin/core/block.cpp b/src/geode/model/mixin/core/block.cpp
@@ -149,6 +149,13 @@ namespace geode
         this->set_name( name );
     }
 
+    template < index_t dimension >
+    auto Block< dimension >::steal_mesh(
+        BlocksBuilderKey /*unused*/ ) -> std::unique_ptr< Mesh >
+    {
+        return impl_->steal_mesh();
+    }
+
     template class opengeode_model_api Block< 3 >;
 
     SERIALIZE_BITSERY_ARCHIVE( opengeode_model_api, Block< 3 > );
diff --git a/src/geode/model/mixin/core/corner.cpp b/src/geode/model/mixin/core/corner.cpp
@@ -159,6 +159,13 @@ namespace geode
         impl_->set_mesh( this->id(), std::move( mesh ) );
     }
 
+    template < index_t dimension >
+    auto Corner< dimension >::steal_mesh(
+        CornersBuilderKey /*unused*/ ) -> std::unique_ptr< Mesh >
+    {
+        return impl_->steal_mesh();
+    }
+
     template class opengeode_model_api Corner< 2 >;
     template class opengeode_model_api Corner< 3 >;
 
diff --git a/src/geode/model/mixin/core/line.cpp b/src/geode/model/mixin/core/line.cpp
@@ -158,6 +158,13 @@ namespace geode
         return modifiable_mesh();
     }
 
+    template < index_t dimension >
+    auto Line< dimension >::steal_mesh(
+        LinesBuilderKey /*unused*/ ) -> std::unique_ptr< Mesh >
+    {
+        return impl_->steal_mesh();
+    }
+
     template class opengeode_model_api Line< 2 >;
     template class opengeode_model_api Line< 3 >;
 
diff --git a/src/geode/model/mixin/core/surface.cpp b/src/geode/model/mixin/core/surface.cpp
@@ -150,6 +150,13 @@ namespace geode
         this->set_name( name );
     }
 
+    template < index_t dimension >
+    auto Surface< dimension >::steal_mesh(
+        SurfacesBuilderKey /*unused*/ ) -> std::unique_ptr< Mesh >
+    {
+        return impl_->steal_mesh();
+    }
+
     template class opengeode_model_api Surface< 2 >;
     template class opengeode_model_api Surface< 3 >;
 
diff --git a/src/geode/model/representation/builder/brep_builder.cpp b/src/geode/model/representation/builder/brep_builder.cpp
@@ -81,6 +81,45 @@ namespace geode
         return mapping;
     }
 
+    void BRepBuilder::replace_components_meshes_by_others(
+        BRep&& other, const ModelCopyMapping& mapping )
+    {
+        BRepBuilder other_builder{ other };
+        for( const auto& in2out :
+            mapping.at( Corner3D::component_type_static() ).in2out_map() )
+        {
+            this->update_corner_mesh( brep_.corner( in2out.first ),
+                other_builder.steal_corner_mesh( in2out.second ) );
+            this->corner_mesh_builder( in2out.first )->set_id( in2out.first );
+        }
+        for( const auto& in2out :
+            mapping.at( Line3D::component_type_static() ).in2out_map() )
+        {
+            this->update_line_mesh( brep_.line( in2out.first ),
+                other_builder.steal_line_mesh( in2out.second ) );
+            this->line_mesh_builder( in2out.first )->set_id( in2out.first );
+        }
+        for( const auto& in2out :
+            mapping.at( Surface3D::component_type_static() ).in2out_map() )
+        {
+            this->update_surface_mesh( brep_.surface( in2out.first ),
+                other_builder.steal_surface_mesh( in2out.second ) );
+            this->surface_mesh_builder( in2out.first )->set_id( in2out.first );
+        }
+        for( const auto& in2out :
+            mapping.at( Block3D::component_type_static() ).in2out_map() )
+        {
+            this->update_block_mesh( brep_.block( in2out.first ),
+                other_builder.steal_block_mesh( in2out.second ) );
+            this->block_mesh_builder( in2out.first )->set_id( in2out.first );
+        }
+        this->delete_isolated_vertices();
+        const auto first_new_unique_vertex_id =
+            create_unique_vertices( other.nb_unique_vertices() );
+        detail::copy_vertex_identifier_components(
+            other, *this, first_new_unique_vertex_id, mapping );
+    }
+
     ModelCopyMapping BRepBuilder::copy_components( const BRep& brep )
     {
         ModelCopyMapping mappings;
diff --git a/tests/model/test-brep.cpp b/tests/model/test-brep.cpp
@@ -1331,6 +1331,22 @@ void test_components_filter()
         "[Test] Wrong number of components with relations" );
 }
 
+std::tuple< geode::BRep, geode::ModelCopyMapping > copy_model(
+    geode::BRep& brep )
+{
+    geode::BRep other;
+    geode::BRepBuilder other_builder{ other };
+    auto mapping = other_builder.copy( brep );
+    return { std::move( other ), std::move( mapping ) };
+}
+
+void test_steal_mesh( geode::BRep& brep )
+{
+    auto [other, mapping] = copy_model( brep );
+    geode::BRepBuilder builder{ brep };
+    builder.replace_components_meshes_by_others( std::move( other ), mapping );
+}
+
 void test()
 {
     geode::OpenGeodeModelLibrary::initialize();
@@ -1391,6 +1407,7 @@ void test()
         model, surface_uuids, surface_collection_uuids );
     test_block_collection_ranges( model, block_uuid, block_collection_uuid );
     test_clone( model );
+    test_steal_mesh( model );
 
     const auto file_io = absl::StrCat( "test.", model.native_extension() );
     geode::save_brep( model, file_io );

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,11 @@ namespace geode`
`59`	`59`	`return *mesh_;`
`60`	`60`	`}`
`61`	`61`
	`62`	`+ [[nodiscard]] std::unique_ptr< Mesh > steal_mesh()`
	`63`	`+ {`
	`64`	`+ return std::move( mesh_ );`
	`65`	`+ }`
	`66`	`+`
`62`	`67`	`[[nodiscard]] const MeshImpl& mesh_type() const`
`63`	`68`	`{`
`64`	`69`	`return mesh_type_;`
Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,9 @@ namespace geode`
`108`	`108`	`return dynamic_cast< TypedMesh& >( get_modifiable_mesh() );`
`109`	`109`	`}`
`110`	`110`
	`111`	`+ [[nodiscard]] std::unique_ptr< Mesh > steal_mesh(`
	`112`	`+ SurfacesBuilderKey key );`
	`113`	`+`
`111`	`114`	`private:`
`112`	`115`	`Surface();`
`113`	`116`