Skip to content

Commit 326c3a9

Browse files
update tests
1 parent bcb01de commit 326c3a9

File tree

5 files changed

+50
-47
lines changed

5 files changed

+50
-47
lines changed

app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from werkzeug.exceptions import HTTPException
88

99
from src.opengeodeweb_back.routes import blueprint_routes
10-
from src.opengeodeweb_back.geode_functions import handle_exception
10+
from src.opengeodeweb_back.utils_functions import handle_exception
1111

1212

1313
""" Global config """

src/opengeodeweb_back/geode_functions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
# Local application imports
1010
from .geode_objects import geode_objects_dict
11-
11+
from . import utils_functions
1212

1313
def geode_object_value(geode_object: str):
1414
return geode_objects_dict()[geode_object]
@@ -140,7 +140,7 @@ def list_geode_objects(
140140
key: str = None,
141141
):
142142
return_dict = {}
143-
file_extension = extension_from_filename(os.path.basename(file_absolute_path))
143+
file_extension = utils_functions.extension_from_filename(os.path.basename(file_absolute_path))
144144
geode_objects_filtered_list = filter_geode_objects(key)
145145

146146
for geode_object in geode_objects_filtered_list:

src/opengeodeweb_back/routes/blueprint_routes.py

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,16 +11,16 @@
1111

1212
routes = flask.Blueprint("routes", __name__)
1313

14-
@routes.before_request
15-
def before_request():
16-
if "ping" not in flask.request.path:
17-
utils_functions.increment_request_counter(flask.current_app)
14+
# @routes.before_request
15+
# def before_request():
16+
# if "ping" not in flask.request.path:
17+
# utils_functions.increment_request_counter(flask.current_app)
1818

19-
@routes.teardown_request
20-
def teardown_request(exception):
21-
if "ping" not in flask.request.path:
22-
utils_functions.decrement_request_counter(flask.current_app)
23-
utils_functions.update_last_request_time(flask.current_app)
19+
# @routes.teardown_request
20+
# def teardown_request(exception):
21+
# if "ping" not in flask.request.path:
22+
# utils_functions.decrement_request_counter(flask.current_app)
23+
# utils_functions.update_last_request_time(flask.current_app)
2424

2525
schemas = os.path.join(os.path.dirname(__file__), "schemas")
2626

@@ -36,7 +36,7 @@ def teardown_request(exception):
3636
methods=allowed_files_json["methods"],
3737
)
3838
def allowed_files():
39-
geode_functions.validate_request(flask.request, allowed_files_json)
39+
utils_functions.validate_request(flask.request, allowed_files_json)
4040
extensions = geode_functions.list_input_extensions(
4141
flask.request.json["supported_feature"]
4242
)
@@ -83,7 +83,7 @@ def allowed_objects():
8383
return flask.make_response({}, 200)
8484

8585
UPLOAD_FOLDER = flask.current_app.config["UPLOAD_FOLDER"]
86-
geode_functions.validate_request(flask.request, allowed_objects_json)
86+
utils_functions.validate_request(flask.request, allowed_objects_json)
8787
file_absolute_path = os.path.join(UPLOAD_FOLDER, flask.request.json["filename"])
8888
allowed_objects = geode_functions.list_geode_objects(
8989
file_absolute_path, flask.request.json["supported_feature"]
@@ -104,7 +104,7 @@ def allowed_objects():
104104
)
105105
def missing_files():
106106
UPLOAD_FOLDER = flask.current_app.config["UPLOAD_FOLDER"]
107-
geode_functions.validate_request(flask.request, missing_files_json)
107+
utils_functions.validate_request(flask.request, missing_files_json)
108108

109109
missing_files = geode_functions.missing_files(
110110
flask.request.json["input_geode_object"],
@@ -142,7 +142,7 @@ def missing_files():
142142
methods=geographic_coordinate_systems_json["methods"],
143143
)
144144
def crs_converter_geographic_coordinate_systems():
145-
geode_functions.validate_request(flask.request, geographic_coordinate_systems_json)
145+
utils_functions.validate_request(flask.request, geographic_coordinate_systems_json)
146146
infos = geode_functions.geographic_coordinate_systems(
147147
flask.request.json["input_geode_object"]
148148
)
@@ -172,7 +172,7 @@ def crs_converter_geographic_coordinate_systems():
172172
)
173173
def inspect_file():
174174
UPLOAD_FOLDER = flask.current_app.config["UPLOAD_FOLDER"]
175-
geode_functions.validate_request(flask.request, inspect_file_json)
175+
utils_functions.validate_request(flask.request, inspect_file_json)
176176

177177
secure_filename = werkzeug.utils.secure_filename(flask.request.json["filename"])
178178
file_path = os.path.abspath(os.path.join(UPLOAD_FOLDER, secure_filename))
@@ -197,7 +197,7 @@ def inspect_file():
197197
)
198198
def geode_objects_and_output_extensions():
199199
UPLOAD_FOLDER = flask.current_app.config["UPLOAD_FOLDER"]
200-
geode_functions.validate_request(
200+
utils_functions.validate_request(
201201
flask.request, geode_objects_and_output_extensions_json
202202
)
203203
data = geode_functions.load(
@@ -229,7 +229,7 @@ def geode_objects_and_output_extensions():
229229
def save_viewable_file():
230230
UPLOAD_FOLDER = flask.current_app.config["UPLOAD_FOLDER"]
231231
DATA_FOLDER_PATH = flask.current_app.config["DATA_FOLDER_PATH"]
232-
geode_functions.validate_request(flask.request, save_viewable_file_json)
232+
utils_functions.validate_request(flask.request, save_viewable_file_json)
233233

234234
secure_filename = werkzeug.utils.secure_filename(flask.request.json["filename"])
235235
file_path = os.path.abspath(os.path.join(UPLOAD_FOLDER, secure_filename))

tests/test_functions.py renamed to tests/test_geode_functions.py

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -312,31 +312,3 @@ def test_geode_objects_output_extensions():
312312
assert type(output_extension_value["is_saveable"]) is bool
313313

314314

315-
def test_versions():
316-
list_packages = [
317-
"OpenGeode-core",
318-
"OpenGeode-IO",
319-
"OpenGeode-Geosciences",
320-
"OpenGeode-GeosciencesIO",
321-
]
322-
versions = geode_functions.versions(list_packages)
323-
assert type(versions) is list
324-
for version in versions:
325-
assert type(version) is dict
326-
327-
328-
def test_extension_from_filename():
329-
extension = geode_functions.extension_from_filename("test.toto")
330-
assert type(extension) is str
331-
assert extension.count(".") == 0
332-
333-
334-
def test_handle_exception(client):
335-
route = "/error"
336-
response = client.post(route)
337-
assert response.status_code == 500
338-
data = response.get_json()
339-
assert type(data) is dict
340-
assert type(data["description"]) is str
341-
assert type(data["name"]) is str
342-
assert type(data["code"]) is int

tests/test_utils_functions.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
from src.opengeodeweb_back import utils_functions
2+
3+
4+
def test_versions():
5+
list_packages = [
6+
"OpenGeode-core",
7+
"OpenGeode-IO",
8+
"OpenGeode-Geosciences",
9+
"OpenGeode-GeosciencesIO",
10+
]
11+
versions = utils_functions.versions(list_packages)
12+
assert type(versions) is list
13+
for version in versions:
14+
assert type(version) is dict
15+
16+
17+
def test_extension_from_filename():
18+
extension = utils_functions.extension_from_filename("test.toto")
19+
assert type(extension) is str
20+
assert extension.count(".") == 0
21+
22+
23+
def test_handle_exception(client):
24+
route = "/error"
25+
response = client.post(route)
26+
assert response.status_code == 500
27+
data = response.get_json()
28+
assert type(data) is dict
29+
assert type(data["description"]) is str
30+
assert type(data["name"]) is str
31+
assert type(data["code"]) is int

0 commit comments

Comments
 (0)