Skip to content

Commit 5f4673c

Browse files
committed
input_file as str
1 parent 9db80dc commit 5f4673c

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

src/opengeodeweb_back/data.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ class Data(Base):
2323
def create(
2424
name: str,
2525
geode_object: str,
26-
input_file: str,
26+
input_file: str | None = None,
2727
additional_files: list[str] | None = None,
2828
) -> "Data":
29-
input_file = input_file if input_file is not None else {}
29+
input_file = input_file if input_file is not None else ""
3030
additional_files = additional_files if additional_files is not None else []
3131

3232
data_entry = Data(

src/opengeodeweb_back/utils_functions.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,11 @@ def save_all_viewables_and_return_info(
158158
geode_object: str,
159159
data: Any,
160160
input_file: str,
161-
additional_files: list[str] = [],
161+
additional_files: list[str] | None = None,
162162
) -> dict[str, Any]:
163+
if additional_files is None:
164+
additional_files = []
165+
163166
data_entry = Data.create(
164167
name=data.name(),
165168
geode_object=geode_object,
@@ -201,9 +204,9 @@ def save_all_viewables_and_return_info(
201204

202205

203206
def generate_native_viewable_and_light_viewable_from_object(
204-
geode_object: str, data: Any, input_file: str
207+
geode_object: str, data: Any
205208
) -> dict[str, Any]:
206-
return save_all_viewables_and_return_info(geode_object, data, input_file)
209+
return save_all_viewables_and_return_info(geode_object, data, input_file="")
207210

208211

209212
def generate_native_viewable_and_light_viewable_from_file(
@@ -247,6 +250,6 @@ def generate_native_viewable_and_light_viewable_from_file(
247250
return save_all_viewables_and_return_info(
248251
geode_object,
249252
data,
250-
input_file=[input_filename],
253+
input_file=input_filename,
251254
additional_files=additional_files_copied,
252-
)
255+
)

tests/test_utils_functions.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def test_save_all_viewables_and_return_info(client):
100100

101101
geode_object = "BRep"
102102
data = geode_functions.load(geode_object, "./tests/data/test.og_brep")
103-
input_file = ["test.og_brep"]
103+
input_file = "test.og_brep"
104104
additional_files = ["additional_file.txt"]
105105

106106
result = utils_functions.save_all_viewables_and_return_info(
@@ -137,7 +137,7 @@ def test_save_all_viewables_commits_to_db_properly(client):
137137
with app.app_context():
138138
geode_object = "BRep"
139139
data = geode_functions.load(geode_object, "./tests/data/test.og_brep")
140-
input_file = ["test.og_brep"]
140+
input_file = "test.og_brep"
141141
result = utils_functions.save_all_viewables_and_return_info(
142142
geode_object, data, input_file
143143
)
@@ -175,7 +175,7 @@ def test_generate_native_viewable_and_light_viewable_from_object(client):
175175
assert re.match(r"[0-9a-f]{32}", result["id"])
176176
assert isinstance(result["object_type"], str)
177177
assert isinstance(result["binary_light_viewable"], str)
178-
assert result["input_files"] == []
178+
assert result["input_files"] == ""
179179

180180

181181
def test_generate_native_viewable_and_light_viewable_from_file(client):
@@ -198,4 +198,4 @@ def test_generate_native_viewable_and_light_viewable_from_file(client):
198198
assert re.match(r"[0-9a-f]{32}", result["id"])
199199
assert isinstance(result["object_type"], str)
200200
assert isinstance(result["binary_light_viewable"], str)
201-
assert isinstance(result["input_files"], list)
201+
assert isinstance(result["input_files"], str)

0 commit comments

Comments
 (0)