Skip to content

Commit 9b7cd16

Browse files
committed
loadable > 0.0
1 parent 6f96ff1 commit 9b7cd16

File tree

2 files changed

+10
-17
lines changed

2 files changed

+10
-17
lines changed

tests/test_geode_functions.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,6 @@ def test_is_loadable():
6363
for input_extension in input_extensions:
6464
file_absolute_path = os.path.join(data_folder, f"test.{input_extension}")
6565
is_loadable = geode_functions.is_loadable(geode_object, file_absolute_path)
66-
assert isinstance(is_loadable, bool)
6766
assert isinstance(is_loadable, float)
6867
assert 0.0 <= is_loadable <= 1.0
6968

@@ -75,7 +74,7 @@ def test_load():
7574
for input_extension in input_extensions:
7675
print(f"\t{input_extension=}")
7776
file_absolute_path = os.path.join(data_folder, f"test.{input_extension}")
78-
if geode_functions.is_loadable(geode_object, file_absolute_path):
77+
if geode_functions.is_loadable(geode_object, file_absolute_path) > 0.0:
7978
data = geode_functions.load(geode_object, file_absolute_path)
8079
data_name = data.name()
8180
if "save_viewable" in value:
@@ -173,7 +172,7 @@ def test_geode_object_output_extensions():
173172
print(
174173
f"\t\tAdditional files: {[f.filename for f in additional.optional_files]}"
175174
)
176-
if geode_functions.is_loadable(geode_object, file_absolute_path):
175+
if geode_functions.is_loadable(geode_object, file_absolute_path) > 0.0:
177176
data = geode_functions.load(geode_object, file_absolute_path)
178177
geode_objets_and_output_extensions = (
179178
geode_functions.geode_objects_output_extensions(geode_object, data)
@@ -216,7 +215,7 @@ def test_get_inspector_children():
216215
print(f"\t\t{mandatory_files=}", flush=True)
217216
additional_files = [f.filename for f in additional.optional_files]
218217
print(f"\t\t{additional_files=}", flush=True)
219-
if geode_functions.is_loadable(geode_object, file_absolute_path):
218+
if geode_functions.is_loadable(geode_object, file_absolute_path) > 0.0:
220219
data = geode_functions.load(geode_object, file_absolute_path)
221220
class_inspector = geode_functions.inspect(geode_object, data)
222221
assert "InspectionResult" in class_inspector.__class__.__name__
@@ -307,7 +306,7 @@ def test_geode_objects_output_extensions():
307306
input_extensions = geode_functions.geode_object_input_extensions(geode_object)
308307
for input_extension in input_extensions:
309308
file_absolute_path = os.path.join(data_folder, f"test.{input_extension}")
310-
if geode_functions.is_loadable(geode_object, file_absolute_path):
309+
if geode_functions.is_loadable(geode_object, file_absolute_path) > 0.0:
311310
data = geode_functions.load(geode_object, file_absolute_path)
312311
geode_objects_and_output_extensions = (
313312
geode_functions.geode_objects_output_extensions(geode_object, data)

tests/test_routes.py

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,10 @@ def test_vertex_attribute_names(client, test_id):
201201
elements = geode_functions.get_elements(geode_object)
202202
if "points" in elements:
203203
for input_extension in input_extensions:
204-
is_loadable = geode_functions.is_loadable(
204+
if geode_functions.is_loadable(
205205
geode_object,
206206
os.path.join("./data", f"test.{input_extension}"),
207-
)
208-
if is_loadable:
209-
207+
) > 0.0:
210208
def get_full_data():
211209
return {
212210
"input_geode_object": geode_object,
@@ -238,12 +236,10 @@ def test_polygon_attribute_names(client, test_id):
238236
elements = geode_functions.get_elements(geode_object)
239237
if "polygons" in elements:
240238
for input_extension in input_extensions:
241-
is_loadable = geode_functions.is_loadable(
239+
if geode_functions.is_loadable(
242240
geode_object,
243241
os.path.join("./data", f"test.{input_extension}"),
244-
)
245-
if is_loadable:
246-
242+
) > 0.0:
247243
def get_full_data():
248244
return {
249245
"input_geode_object": geode_object,
@@ -275,12 +271,10 @@ def test_polyhedron_attribute_names(client, test_id):
275271
elements = geode_functions.get_elements(geode_object)
276272
if "polyhedrons" in elements:
277273
for input_extension in input_extensions:
278-
is_loadable = geode_functions.is_loadable(
274+
if geode_functions.is_loadable(
279275
geode_object,
280276
os.path.join("./data", f"test.{input_extension}"),
281-
)
282-
if is_loadable:
283-
277+
) > 0.0:
284278
def get_full_data():
285279
return {
286280
"input_geode_object": geode_object,

0 commit comments

Comments
 (0)