Skip to content

Commit d0b48d0

Browse files
authored
Merge pull request #193 from Geode-solutions/fix/database
Fix/database
2 parents 3003ff4 + 9dd51b7 commit d0b48d0

File tree

5 files changed

+9
-17
lines changed

5 files changed

+9
-17
lines changed

requirements.in

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ geode-common==33.11.0
77
geode-viewables==3.3.0
88
flask[async]==3.1.2
99
flask-cors==6.0.1
10-
werkzeug==3.1.2
11-
flask-sqlalchemy==3.1.1
10+
werkzeug==3.1.2

requirements.txt

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,14 @@ flask[async]>=3
1414
# via
1515
# -r requirements.in
1616
# flask-cors
17-
# flask-sqlalchemy
1817
flask-cors==6.0.1
1918
# via -r requirements.in
20-
flask-sqlalchemy==3.1.1
21-
# via -r requirements.in
2219
geode-common==33.11.0
2320
# via
2421
# -r requirements.in
2522
# geode-viewables
2623
geode-viewables==3.3.0
2724
# via -r requirements.in
28-
greenlet>=3
29-
# via sqlalchemy
3025
itsdangerous>=2
3126
# via flask
3227
jinja2>=3
@@ -59,14 +54,9 @@ opengeode-io==7.4.0
5954
# -r requirements.in
6055
# geode-viewables
6156
# opengeode-geosciencesio
62-
sqlalchemy>=2
63-
# via flask-sqlalchemy
64-
typing-extensions>=4
65-
# via sqlalchemy
6657
werkzeug==3.1.2
6758
# via
6859
# -r requirements.in
6960
# flask
7061
# flask-cors
7162

72-
opengeodeweb-microservice==1.*,>=1.0.4rc7

src/opengeodeweb_back/app.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,12 +140,13 @@ def run_server() -> None:
140140
flush=True,
141141
)
142142

143-
db_filename: str = app.config.get("DATABASE_FILENAME") or "database.db"
143+
db_filename: str = app.config.get("DATABASE_FILENAME") or "project.db"
144144
db_path = os.path.join(args.data_folder_path, db_filename)
145145
os.makedirs(os.path.dirname(db_path), exist_ok=True)
146146
app.config["SQLALCHEMY_DATABASE_URI"] = f"sqlite:///{db_path}"
147147
app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False
148-
init_database(app, db_filename)
148+
149+
init_database(db_path)
149150
print(f"Database initialized at: {db_path}", flush=True)
150151

151152
app.run(debug=args.debug, host=args.host, port=args.port, ssl_context=SSL)

src/opengeodeweb_back/utils_functions.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ def create_data_folder_from_id(data_id: str) -> str:
163163
def save_all_viewables_and_return_info(
164164
geode_object: str,
165165
data: Any,
166-
input_file: str,
166+
input_file: str | None = None,
167167
additional_files: list[str] | None = None,
168168
) -> dict[str, Any]:
169169
if additional_files is None:
@@ -227,6 +227,8 @@ def generate_native_viewable_and_light_viewable_from_object(
227227
def generate_native_viewable_and_light_viewable_from_file(
228228
geode_object: str, input_filename: str
229229
) -> dict[str, Any]:
230+
231+
session = get_session()
230232
temp_data_entry = Data.create(
231233
geode_object=geode_object,
232234
input_file=input_filename,
@@ -258,10 +260,10 @@ def generate_native_viewable_and_light_viewable_from_file(
258260

259261
data = geode_functions.load(geode_object, copied_full_path)
260262

261-
session = get_session()
262263
if session:
263264
session.delete(temp_data_entry)
264265
session.flush()
266+
session.commit()
265267

266268
return save_all_viewables_and_return_info(
267269
geode_object,

tests/conftest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ def configure_test_environment() -> Generator[None, None, None]:
3636
print("Current working directory:", os.getcwd())
3737
print("Directory contents:", os.listdir("."))
3838

39-
init_database(app, db_path)
39+
init_database(db_path)
4040
os.environ["TEST_DB_PATH"] = str(db_path)
4141

4242
yield

0 commit comments

Comments
 (0)