Feat/folder path #166
Merged
Feat/folder path #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…y for each project
…/OpenGeodeWeb-Back into feat/folder_path
…ble and update regex for file name assertions
…ibute_names, polyhedron_attribute_names test folder changed to match project_uuid path
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…/OpenGeodeWeb-Back into feat/folder_path
…zation and maintainability
BotellaA
reviewed
Jul 30, 2025
| ) | ||
| tree = ET.parse(vtm_file_path) | ||
| except FileNotFoundError: | ||
| return flask.make_response({"error": "VTM file not found"}, 404) |
There was a problem hiding this comment.
@JulienChampagnol c'est une 404 ou une 500 ?
| flask.request.json["geode_object"], | ||
| flask.request.json, | ||
| ) | ||
| except FileNotFoundError: |
There was a problem hiding this comment.
on peut pas avoir une gestion des exceptions plus généralisé ? devoir faire un try/catch partout c'est assez intrusif
| return geode_object_value(geode_object)["load"](file_absolute_path) | ||
|
|
||
|
|
||
| def data_file_path(request_json, filename): |
There was a problem hiding this comment.
j'ai vu pourquoi tu avais besoin du filename, mais du coup je trouve ca dommage de devoir donner la requete ET le filename. Dans ce cas, je dirais plutot donner l'id et le filename
| ) | ||
|
|
||
|
|
||
| def load_data(geode_object: str, request_json: dict): |
There was a problem hiding this comment.
le geode_object il est pas dans la requete aussi ?
removed request_json in geode_functions
BotellaA
approved these changes
Jul 30, 2025
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.