Skip to content

Commit 5b43249

Browse files
committed
undefined is ok to use
1 parent 4b876ea commit 5b43249

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

components/ObjectSelector.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
<v-img
2525
:src="geode_objects[key].image"
2626
cover
27-
:class="!value['is_loadable'] ? 'disabled' : ''"
27+
:class="!value['is_loadable'] ? 'disabled' : undefined"
2828
/>
2929
</v-card>
3030
</span>
@@ -69,7 +69,7 @@
6969
function select_geode_object(object_map) {
7070
const object_keys = Object.keys(object_map)
7171
if (!object_keys.length) {
72-
return ''
72+
return undefined
7373
}
7474
if (
7575
object_keys.length === 1 &&
@@ -81,7 +81,7 @@
8181
...object_keys.map((key) => object_map[key].is_loadable),
8282
)
8383
if (highest_load_score <= 0) {
84-
return ''
84+
return undefined
8585
}
8686
const best_score_objects = object_keys.filter(
8787
(key) => object_map[key].is_loadable === highest_load_score,
@@ -100,7 +100,7 @@
100100
if (highest_priority !== -Infinity && best_priority_objects.length === 1) {
101101
return best_priority_objects[0]
102102
}
103-
return ''
103+
return undefined
104104
}
105105
106106
async function get_allowed_objects() {
@@ -125,7 +125,7 @@
125125
)
126126
const priorities = allowed_objects_list
127127
.map((obj) => obj[key].object_priority)
128-
.filter((p) => p !== '' && p !== null)
128+
.filter((p) => p !== undefined && p !== null)
129129
final_object[key] = { is_loadable: Math.min(...load_scores) }
130130
if (priorities.length) {
131131
final_object[key].object_priority = Math.max(...priorities)

0 commit comments

Comments
 (0)