oxlint

Author: JulienChampagnol

components/Recaptcha.vue

@@ -53,13 +53,15 @@
   const launch = ref(false)
   const emailRules = [
     (value) => {
-      if (value) return true
-
+      if (value) {
+        return true
+      }
       return "E-mail is required."
     },
     (value) => {
-      if (/.+@.+\..+/.test(value)) return true
-
+      if (/.+@.+\..+/.test(value)) {
+        return true
+      }
       return "E-mail must be valid."
     },
   ]
@@ -74,14 +76,14 @@
       }
     }
   })
-  async function submit_recaptcha() {
+  function submit_recaptcha() {
     $fetch(
       `/.netlify/functions/recaptcha?name=${name.value}&email=${email.value}&launch=${launch.value}`,
       {
         onResponse({ response }) {
           if (response.ok) {
             infra_store.$patch({
-              is_captcha_validated: response.status == 200,
+              is_captcha_validated: response.status === 200,
             })
           }
         },

tests/unit/utils/recaptcha.nuxt.test.js

@@ -6,28 +6,33 @@ describe("recaptcha.js", () => {
   const name = ""
   const email = ""
   const launch = false
+  const internal_error = 500
+  const success = 200
+
   describe("Wrong params", () => {
-    test("name", async () => {
+    test("name", () => {
       const name = "test"
       const result = check_recaptcha_params(name, email, launch)
-      expect(result.status).toBe(500)
+      expect(result.status).toBe(internal_error)
     })
-    test("email", async () => {
+
+    test("email", () => {
       const email = "test"
       const result = check_recaptcha_params(name, email, launch)
-      expect(result.status).toBe(500)
+      expect(result.status).toBe(internal_error)
     })
-    test("launch", async () => {
+
+    test("launch", () => {
       const launch = true
       const result = check_recaptcha_params(name, email, launch)
-      expect(result.status).toBe(500)
+      expect(result.status).toBe(internal_error)
     })
   })
 
   describe("Right params", () => {
-    test("name", async () => {
+    test("name", () => {
       const result = check_recaptcha_params(name, email, launch)
-      expect(result.status).toBe(200)
+      expect(result.status).toBe(success)
     })
   })
 })

utils/recaptcha.js

@@ -1,7 +1,13 @@
 function check_recaptcha_params(name, email, launch) {
-  if (name !== "") return { status: 500 }
-  if (email !== "") return { status: 500 }
-  if (launch !== false) return { status: 500 }
+  if (name !== "") {
+    return { status: 500 }
+  }
+  if (email !== "") {
+    return { status: 500 }
+  }
+  if (launch !== false) {
+    return { status: 500 }
+  }
   return { status: 200 }
 }