Skip to content

Commit b391011

Browse files
JulienChampagnolJulienChampagnol
authored
Merge pull request #207 from Geode-solutions/feat/refactor_stores_and_app_lifecycle
feat(stores): app_mode
2 parents f0e6644 + 5efeabc commit b391011

File tree

15 files changed

+133
-80
lines changed

15 files changed

+133
-80
lines changed

‎components/Launcher.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
watch(
2828
() => infra_store.is_captcha_validated,
2929
(value, oldValue) => {
30-
if (value && !oldValue && process.client) {
30+
if (value && !oldValue && import.meta.client) {
3131
infra_store.create_backend()
3232
}
3333
},

‎components/Recaptcha.vue‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,6 @@
1919
site_key: { type: String, required: true },
2020
})
2121
22-
onMounted(() => {
23-
if (process.client) {
24-
const config = useRuntimeConfig()
25-
if (config.public.NODE_ENV !== "production" || !infra_store.is_cloud) {
26-
infra_store.$patch({ is_captcha_validated: true })
27-
}
28-
}
29-
})
30-
3122
async function submit_recaptcha(token) {
3223
try {
3324
const response = await $fetch.raw(

‎components/RemoteRenderingView.vue‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@
108108
}
109109
110110
onMounted(async () => {
111-
if (process.client) {
111+
if (import.meta.client) {
112112
window.addEventListener("resize", resize)
113113
await nextTick()
114114
view.setContainer(viewer.value.$el)

‎composables/api_fetch.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,11 @@ export function api_fetch(
1212
const { valid, error } = validate_schema(schema, body)
1313

1414
if (!valid) {
15+
if (process.env.NODE_ENV === "development") {
16+
console.log("Bad request", error, schema, params)
17+
console.log("schema", schema)
18+
console.log("params", params)
19+
}
1520
feedback_store.add_error(400, schema.$id, "Bad request", error)
1621
throw new Error(schema.$id.concat(": ", error))
1722
}

‎composables/viewer_call.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ export function viewer_call(
88
const { valid, error } = validate_schema(schema, params)
99

1010
if (!valid) {
11+
if (process.env.NODE_ENV === "development") {
12+
console.log("Bad request", error, schema, params)
13+
console.log("schema", schema)
14+
console.log("params", params)
15+
}
1116
feedback_store.add_error(400, schema.route, "Bad request", error)
1217
throw new Error(schema.route.concat(": ", error))
1318
}

‎nuxt.config.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ export default defineNuxtConfig({
55
SITE_BRANCH:
66
process.env.NODE_ENV === "production" ? process.env.SITE_BRANCH : "",
77
PROJECT: process.env.NODE_ENV === "production" ? process.env.PROJECT : "",
8-
NODE_ENV: process.env.NODE_ENV,
8+
BROWSER: process.env.BROWSER ?? false,
9+
GEODE_PORT: process.env.GEODE_PORT ?? null,
10+
VIEWER_PORT: process.env.VIEWER_PORT ?? null,
911
},
1012
},
1113

‎stores/geode.js‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,21 +9,25 @@ export const use_geode_store = defineStore("geode", {
99
}),
1010
getters: {
1111
protocol() {
12-
if (use_infra_store().is_cloud) {
12+
if (use_infra_store().app_mode == appMode.appMode.CLOUD) {
1313
return "https"
1414
}
1515
return "http"
1616
},
1717
port() {
18-
if (use_infra_store().is_cloud) {
18+
if (use_infra_store().app_mode == appMode.appMode.CLOUD) {
1919
return "443"
2020
}
21+
const GEODE_PORT = useRuntimeConfig().public.GEODE_PORT
22+
if (GEODE_PORT != null && GEODE_PORT !== "") {
23+
return GEODE_PORT
24+
}
2125
return this.default_local_port
2226
},
2327
base_url() {
2428
const infra_store = use_infra_store()
2529
let geode_url = `${this.protocol}://${infra_store.domain_name}:${this.port}`
26-
if (infra_store.is_cloud) {
30+
if (infra_store.app_mode == appMode.appMode.CLOUD) {
2731
if (infra_store.ID == "") {
2832
throw new Error("ID must not be empty in cloud mode")
2933
}

‎stores/infra.js‎

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,20 @@
11
import { useStorage } from "@vueuse/core"
2-
import isElectron from "is-electron"
32
import Status from "@ogw_f/utils/status.js"
3+
import getCaptchaState from "@ogw_f/utils/captcha_state.js"
44

55
export const use_infra_store = defineStore("infra", {
66
state: () => ({
7+
app_mode: getAppMode(),
78
ID: useStorage("ID", ""),
8-
is_captcha_validated: false,
9+
is_captcha_validated: getCaptchaState(),
910
status: Status.NOT_CREATED,
1011
}),
1112
getters: {
12-
is_cloud() {
13-
return (
14-
!isElectron() && useRuntimeConfig().public.NODE_ENV === "production"
15-
)
16-
},
1713
domain_name() {
18-
if (this.is_cloud) {
14+
if (this.app_mode == appMode.appMode.CLOUD) {
1915
return useRuntimeConfig().public.API_URL
20-
} else {
21-
return "localhost"
2216
}
17+
return "localhost"
2318
},
2419
lambda_url() {
2520
const geode_store = use_geode_store()
@@ -47,27 +42,30 @@ export const use_infra_store = defineStore("infra", {
4742
},
4843
actions: {
4944
async create_backend() {
45+
console.log("create_backend this.app_mode", this.app_mode)
5046
if (this.status === Status.CREATED) return
5147
return navigator.locks.request("infra.create_backend", async (lock) => {
5248
this.status = Status.CREATING
5349
if (this.status === Status.CREATED) return
5450
console.log("LOCK GRANTED !", lock)
55-
const geode_store = use_geode_store()
56-
const viewer_store = use_viewer_store()
57-
const feedback_store = use_feedback_store()
58-
if (isElectron()) {
59-
const back_port = await window.electronAPI.run_back(geode_store.port)
51+
if (this.app_mode == appMode.appMode.DESKTOP) {
52+
const viewer_store = use_viewer_store()
53+
const geode_store = use_geode_store()
54+
const back_port = await window.electronAPI.run_back(
55+
geode_store.default_local_port,
56+
)
6057
geode_store.$patch({ default_local_port: back_port })
6158
const viewer_port = await window.electronAPI.run_viewer(
62-
viewer_store.port,
59+
viewer_store.default_local_port,
6360
)
6461
viewer_store.$patch({ default_local_port: viewer_port })
65-
} else {
62+
} else if (this.app_mode == appMode.appMode.CLOUD) {
6663
const { data, error } = await useFetch(this.lambda_url, {
6764
method: "POST",
6865
})
6966
if (error.value || !data.value) {
7067
this.status = Status.NOT_CREATED
68+
const feedback_store = use_feedback_store()
7169
feedback_store.server_error = true
7270
return
7371
}
@@ -79,6 +77,7 @@ export const use_infra_store = defineStore("infra", {
7977
})
8078
},
8179
async create_connection() {
80+
console.log("create_connection")
8281
await use_viewer_store().ws_connect()
8382
await use_geode_store().do_ping()
8483
return

‎stores/viewer.js‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,23 +16,26 @@ export const use_viewer_store = defineStore("viewer", {
1616
}),
1717
getters: {
1818
protocol() {
19-
if (use_infra_store().is_cloud) {
19+
if (use_infra_store().app_mode == appMode.appMode.CLOUD) {
2020
return "wss"
2121
} else {
2222
return "ws"
2323
}
2424
},
2525
port() {
26-
if (use_infra_store().is_cloud) {
26+
if (use_infra_store().app_mode == appMode.appMode.CLOUD) {
2727
return "443"
28-
} else {
29-
return this.default_local_port
3028
}
29+
const VIEWER_PORT = useRuntimeConfig().public.VIEWER_PORT
30+
if (VIEWER_PORT != null && VIEWER_PORT !== "") {
31+
return VIEWER_PORT
32+
}
33+
return this.default_local_port
3134
},
3235
base_url() {
3336
const infra_store = use_infra_store()
3437
let viewer_url = `${this.protocol}://${infra_store.domain_name}:${this.port}`
35-
if (infra_store.is_cloud) {
38+
if (infra_store.app_mode == appMode.appMode.CLOUD) {
3639
if (infra_store.ID == "") {
3740
throw new Error("ID must not be empty in cloud mode")
3841
}

‎test/components/Launcher.nuxt.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ global.ResizeObserver = require("resize-observer-polyfill")
3131

3232
describe("Launcher.vue", async () => {
3333
test(`Mount`, async () => {
34-
const spy_infra_store = vi.spyOn(infra_store, "create_backend")
34+
const spy_create_backend = vi.spyOn(infra_store, "create_backend")
3535
const wrapper = await mountSuspended(Launcher, {
3636
global: {
3737
plugins: [vuetify],
@@ -40,6 +40,6 @@ describe("Launcher.vue", async () => {
4040
expect(wrapper.exists()).toBe(true)
4141
await infra_store.$patch({ is_captcha_validated: true })
4242
flushPromises()
43-
expect(spy_infra_store).toHaveBeenCalled()
43+
expect(spy_create_backend).toHaveBeenCalled()
4444
})
4545
})

0 commit comments

Comments
 (0)