Skip to content

Fix/action integration #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 17, 2025
Merged

Fix/action integration #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ddcbd70
test
BotellaA Sep 15, 2025
f5824ee
microservices_path: "tests/integration/microservices"
BotellaA Sep 15, 2025
584aa76
fix(Actions): add integration tests
BotellaA Sep 15, 2025
d7af85c
again
BotellaA Sep 15, 2025
a343453
again
BotellaA Sep 15, 2025
1dfde9e
absolute
BotellaA Sep 15, 2025
bd00042
test
BotellaA Sep 15, 2025
a6daeab
revert
BotellaA Sep 15, 2025
2072c80
update
BotellaA Sep 15, 2025
859e1e4
Merge branch 'next' of https://github.com/Geode-solutions/OpenGeodeWe…
BotellaA Sep 15, 2025
7e09dc1
test
BotellaA Sep 16, 2025
69f33a7
merge
JulienChampagnol Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 2 additions & 23 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,10 @@ on:
- next

jobs:
test-integration:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Node setup
uses: actions/setup-node@v4
with:
node-version: 22
- name: Python setup
uses: actions/setup-python@v5
with:
python-version: 3.12
- name: Install python dependencies
run: |
cd ./tests/integration/microservices/viewer
python3 -m venv venv
source venv/bin/activate
pip install --extra-index-url https://wheels.vtk.org -r requirements.txt
- name: Install and run tests
run: |
npm i

npm run test:integration
test:
uses: Geode-solutions/actions/.github/workflows/js-test.yml@master
with:
repos: ${{ vars.REPOS }}
integration: true
microservices_path: "tests/integration/microservices"
Copy link
Member

@JulienChampagnol JulienChampagnol Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this handle --extra-index-url ?

secrets: inherit
3 changes: 2 additions & 1 deletion .github/workflows/test_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ jobs:
uses: Geode-solutions/actions/.github/workflows/js-test-pr.yml@master
with:
repos: ${{ vars.REPOS }}
integration: false
integration: true
microservices_path: "tests/integration/microservices"
secrets: inherit
13 changes: 2 additions & 11 deletions components/HybridRenderingView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<VeaseViewToolbar />
<slot name="ui"></slot>
<v-col
class="pa-0"
ref="viewer"
style="overflow: hidden; position: relative; z-index: 0"
:style="{ height: viewerHeight }"
style="height: 100%; overflow: hidden; position: relative; z-index: 0"
@click="get_x_y"
@keydown.esc="viewerStore.toggle_picking_mode(false)"
/>
Expand All @@ -15,13 +15,6 @@
</template>

<script setup>
const props = defineProps({
height: {
type: String,
default: "100%",
},
})

const emit = defineEmits(["click"])

const container = useTemplateRef("viewer")
Expand All @@ -30,8 +23,6 @@
const { windowWidth, windowHeight } = useWindowSize()
const { width, height } = useElementSize(container)

const viewerHeight = computed(() => props.height)

const debouncedResize = debounce(() => {
hybridViewerStore.resize(width.value, height.value)
}, 100)
Expand Down
Loading