Skip to content

Commit 21c483b

Browse files
committed
delete all database_path.
missing viewer_object = self.get_viewer_object_type(params["id"])
1 parent c1dd621 commit 21c483b

File tree

4 files changed

+32
-53
lines changed

4 files changed

+32
-53
lines changed

src/opengeodeweb_viewer/config.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,10 @@ def _copy_test_assets(
4848
copyfile(src, os.path.join(uploads_directory, file))
4949

5050

51-
def test_config(path: str) -> None:
51+
def test_config() -> None:
5252
default_config()
53-
os.environ["DATA_FOLDER_PATH"] = os.path.join(
54-
os.path.dirname(__file__), "..", "..", "tests", "data"
55-
)
56-
57-
os.environ["DATABASE_PATH"] = str(path)
58-
db_file = os.path.join(path, "project.db")
53+
data_path = os.path.join(os.path.dirname(__file__), "..", "..", "tests", "data")
54+
os.environ["DATA_FOLDER_PATH"] = data_path
55+
db_file = os.path.join(data_path, "project.db")
5956
if not os.path.exists(db_file):
6057
open(db_file, "a").close()

src/opengeodeweb_viewer/rpc/generic/generic_protocols.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ def __init__(self, mesh_protocols, model_protocols):
2323

2424
@exportRpc(generic_prefix + generic_schemas_dict["register"]["rpc"])
2525
def register(self, params):
26-
print(f"{self.generic_schemas_dict["register"]}", flush=True)
2726
validate_schema(
2827
params, self.generic_schemas_dict["register"], self.generic_prefix
2928
)

src/opengeodeweb_viewer/vtk_protocol.py

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ class VtkView(vtk_protocols.vtkWebProtocol):
1414
def __init__(self) -> None:
1515
super().__init__()
1616
self.DATA_FOLDER_PATH = os.getenv("DATA_FOLDER_PATH")
17-
self.DATABASE_PATH = os.getenv("DATABASE_PATH")
1817
self.DataReader = vtk.vtkXMLPolyDataReader()
1918
self.ImageReader = vtk.vtkXMLImageDataReader()
2019

@@ -26,38 +25,38 @@ def get_object(self, id: str) -> dict[str, object | str]:
2625

2726
def get_viewer_object_type(self, data_id: str) -> str:
2827
data = self.get_data(data_id)
29-
geode_object = data.get("geode_object")
30-
if geode_object == "mesh":
28+
object_type = data.get("object_type")
29+
if object_type == "mesh":
3130
return "mesh"
32-
elif geode_object == "model":
31+
elif object_type == "model":
3332
return "model"
34-
raise Exception(f"Unknown geode_object type: {geode_object}")
33+
raise Exception(f"Unknown object_type type: {object_type}")
3534

3635
def get_data(self, data_id: str) -> dict[str, str | list[str] | None]:
3736
if Data is None:
3837
raise Exception("Data model not available")
3938

40-
session = get_session()
41-
if not session:
42-
raise Exception("No database session available")
43-
44-
try:
45-
data = session.get(Data, data_id)
46-
if not data:
47-
raise Exception(f"Data with id {data_id} not found in database")
48-
49-
return {
50-
"id": data.id,
51-
"native_file_name": data.native_file_name,
52-
"viewable_file_name": data.viewable_file_name,
53-
"geode_object": data.geode_object,
54-
"light_viewable": data.light_viewable,
55-
"input_file": data.input_file,
56-
"additional_files": data.additional_files,
57-
}
58-
except Exception as e:
59-
print(f"Error fetching data {data_id}: {e}")
60-
raise
39+
with get_session() as session:
40+
if not session:
41+
raise Exception("No database session available")
42+
43+
try:
44+
data = session.get(Data, data_id)
45+
if not data:
46+
raise Exception(f"Data with id {data_id} not found in database")
47+
48+
return {
49+
"id": data.id,
50+
"native_file_name": data.native_file_name,
51+
"viewable_file_name": data.viewable_file_name,
52+
"geode_object": data.geode_object,
53+
"light_viewable": data.light_viewable,
54+
"input_file": data.input_file,
55+
"additional_files": data.additional_files,
56+
}
57+
except Exception as e:
58+
print(f"Error fetching data {data_id}: {e}")
59+
raise
6160

6261
def get_data_file_path(self, data_id: str, filename: str | None = None) -> str:
6362
if filename is None:

src/opengeodeweb_viewer/vtkw_server.py

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -58,11 +58,6 @@ def add_arguments(parser):
5858
default=os.environ.get("DATA_FOLDER_PATH"),
5959
help="Path to the folder where data is stored",
6060
)
61-
parser.add_argument(
62-
"--database_path",
63-
default=os.environ.get("DATABASE_PATH"),
64-
help="Path to the SQLite database file",
65-
)
6661

6762
@staticmethod
6863
def configure(args):
@@ -141,20 +136,9 @@ def run_server(Server=_Server):
141136
if "data_folder_path" in args and args.data_folder_path:
142137
os.environ["DATA_FOLDER_PATH"] = args.data_folder_path
143138

144-
if "data_folder_path" in args and args.data_folder_path:
145-
if not args.database_path:
146-
args.database_path = args.data_folder_path
147-
os.environ["DATABASE_PATH"] = args.data_folder_path
148-
else:
149-
os.environ["DATABASE_PATH"] = args.database_path
150-
151-
db_path = os.environ.get("DATABASE_PATH")
152-
if db_path:
153-
db_full_path = os.path.join(db_path, "project.db")
154-
connection.init_database(db_full_path)
155-
print(f"Viewer database initialized at: {db_full_path}", flush=True)
156-
else:
157-
print("WARNING: No DATABASE_PATH set, database not initialized!", flush=True)
139+
db_full_path = os.path.join(os.environ["DATA_FOLDER_PATH"], "project.db")
140+
connection.init_database(db_full_path)
141+
print(f"Viewer connected to database at: {db_full_path}", flush=True)
158142

159143
print(f"{args=}", flush=True)
160144
Server.configure(args)

0 commit comments

Comments
 (0)