Skip to content

Commit af166e6

Browse files
committed
type object_methods and test_mesh_polyhedra_protocols
1 parent 61243ff commit af166e6

File tree

2 files changed

+43
-23
lines changed

2 files changed

+43
-23
lines changed

src/opengeodeweb_viewer/object/object_methods.py

Lines changed: 24 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# Standard library imports
22
import os
3+
from typing import Any, List, Dict
34

45
# Third party imports
56
import vtk
@@ -10,10 +11,17 @@
1011

1112

1213
class VtkObjectView(VtkView):
13-
def __init__(self):
14+
def __init__(self) -> None:
1415
super().__init__()
1516

16-
def registerObject(self, id: str, file_name: str, reader, filter, mapper):
17+
def registerObject(
18+
self,
19+
id: str,
20+
file_name: str,
21+
reader: Any,
22+
filter: Any,
23+
mapper: Any
24+
) -> None:
1725
actor = vtk.vtkActor()
1826
self.register_object(id, reader, filter, actor, mapper, {})
1927
reader.SetFileName(os.path.join(self.DATA_FOLDER_PATH, id, file_name))
@@ -30,15 +38,15 @@ def registerObject(self, id: str, file_name: str, reader, filter, mapper):
3038
renderWindow.Render()
3139
self.render()
3240

33-
def deregisterObject(self, data_id: str):
41+
def deregisterObject(self, data_id: str) -> None:
3442
actor = self.get_object(data_id)["actor"]
3543
renderWindow = self.getView("-1")
3644
renderer = renderWindow.GetRenderers().GetFirstRenderer()
3745
renderer.RemoveActor(actor)
3846
self.deregister_object(data_id)
3947
self.render()
4048

41-
def applyTextures(self, data_id: str, textures):
49+
def applyTextures(self, data_id: str, textures: List[Dict[str, Any]]) -> None:
4250
textures_array = []
4351
images_reader_array = []
4452

@@ -86,24 +94,24 @@ def applyTextures(self, data_id: str, textures):
8694

8795
self.render()
8896

89-
def SetVisibility(self, data_id: str, visibility):
97+
def SetVisibility(self, data_id: str, visibility: bool) -> None:
9098
actor = self.get_object(data_id)["actor"]
9199
actor.SetVisibility(visibility)
92100
self.render()
93101

94-
def SetOpacity(self, data_id: str, opacity):
102+
def SetOpacity(self, data_id: str, opacity: float) -> None:
95103
actor = self.get_object(data_id)["actor"]
96104
actor.GetProperty().SetOpacity(opacity)
97105
self.render()
98106

99-
def SetColor(self, data_id: str, red, green, blue):
107+
def SetColor(self, data_id: str, red: int, green: int, blue: int) -> None:
100108
mapper = self.get_object(data_id)["mapper"]
101109
mapper.ScalarVisibilityOff()
102110
actor = self.get_object(data_id)["actor"]
103111
actor.GetProperty().SetColor([red / 255, green / 255, blue / 255])
104112
self.render()
105113

106-
def SetEdgesVisibility(self, data_id: str, visibility):
114+
def SetEdgesVisibility(self, data_id: str, visibility: bool) -> None:
107115
actor = self.get_object(data_id)["actor"]
108116
max_dimension = self.get_object(data_id)["max_dimension"]
109117
if max_dimension == "edges":
@@ -112,12 +120,12 @@ def SetEdgesVisibility(self, data_id: str, visibility):
112120
actor.GetProperty().SetEdgeVisibility(visibility)
113121
self.render()
114122

115-
def SetEdgesWidth(self, data_id: str, width):
123+
def SetEdgesWidth(self, data_id: str, width: float) -> None:
116124
actor = self.get_object(data_id)["actor"]
117125
actor.GetProperty().SetEdgeWidth(width)
118126
self.render()
119127

120-
def SetEdgesColor(self, data_id: str, red, green, blue):
128+
def SetEdgesColor(self, data_id: str, red: int, green: int, blue: int) -> None:
121129
actor = self.get_object(data_id)["actor"]
122130
max_dimension = self.get_object(data_id)["max_dimension"]
123131
if max_dimension == "edges":
@@ -126,7 +134,7 @@ def SetEdgesColor(self, data_id: str, red, green, blue):
126134
actor.GetProperty().SetEdgeColor([red / 255, green / 255, blue / 255])
127135
self.render()
128136

129-
def SetPointsVisibility(self, data_id: str, visibility):
137+
def SetPointsVisibility(self, data_id: str, visibility: bool) -> None:
130138
actor = self.get_object(data_id)["actor"]
131139
max_dimension = self.get_object(data_id)["max_dimension"]
132140
if max_dimension == "points":
@@ -135,12 +143,12 @@ def SetPointsVisibility(self, data_id: str, visibility):
135143
actor.GetProperty().SetVertexVisibility(visibility)
136144
self.render()
137145

138-
def SetPointsSize(self, data_id: str, size):
146+
def SetPointsSize(self, data_id: str, size: float) -> None:
139147
actor = self.get_object(data_id)["actor"]
140148
actor.GetProperty().SetPointSize(size)
141149
self.render()
142150

143-
def SetPointsColor(self, data_id: str, red, green, blue):
151+
def SetPointsColor(self, data_id: str, red: int, green: int, blue: int) -> None:
144152
actor = self.get_object(data_id)["actor"]
145153
max_dimension = self.get_object(data_id)["max_dimension"]
146154
if max_dimension == "points":
@@ -149,19 +157,19 @@ def SetPointsColor(self, data_id: str, red, green, blue):
149157
actor.GetProperty().SetVertexColor([red / 255, green / 255, blue / 255])
150158
self.render()
151159

152-
def SetBlocksVisibility(self, data_id: str, block_ids, visibility):
160+
def SetBlocksVisibility(self, data_id: str, block_ids: List[Any], visibility: bool) -> None:
153161
mapper = self.get_object(data_id)["mapper"]
154162
for block_id in block_ids:
155163
mapper.SetBlockVisibility(block_id, visibility)
156164
self.render()
157165

158-
def SetBlocksColor(self, data_id: str, block_ids, red, green, blue):
166+
def SetBlocksColor(self, data_id: str, block_ids: List[Any], red: int, green: int, blue: int) -> None:
159167
mapper = self.get_object(data_id)["mapper"]
160168
for block_id in block_ids:
161169
mapper.SetBlockColor(block_id, [red / 255, green / 255, blue / 255])
162170
self.render()
163171

164-
def clearColors(self, data_id):
172+
def clearColors(self, data_id: str) -> None:
165173
db = self.get_object(data_id)
166174
mapper = db["mapper"]
167175
reader = db["reader"]

src/tests/mesh/polyhedra/test_mesh_polyhedra_protocols.py

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,19 @@
11
# Standard library imports
2+
from typing import Callable
23

34
# Third party imports
4-
from opengeodeweb_viewer.rpc.mesh.mesh_protocols import VtkMeshView
5-
from opengeodeweb_viewer.rpc.mesh.polyhedra.polyhedra_protocols import (
5+
from src.opengeodeweb_viewer.rpc.mesh.mesh_protocols import VtkMeshView
6+
from src.opengeodeweb_viewer.rpc.mesh.polyhedra.polyhedra_protocols import (
67
VtkMeshPolyhedraView,
78
)
89

910
# Local application imports
11+
from ...conftest import ServerMonitor
1012

1113

12-
def test_register_mesh(server, dataset_factory):
14+
def test_register_mesh(
15+
server: ServerMonitor, dataset_factory: Callable[..., str]
16+
) -> None:
1317
dataset_factory(id="123456789", viewable_file_name="polyhedron_attribute.vtu")
1418

1519
server.call(
@@ -19,7 +23,9 @@ def test_register_mesh(server, dataset_factory):
1923
assert server.compare_image(3, "mesh/polyhedra/register.jpeg") == True
2024

2125

22-
def test_polyhedra_color(server, dataset_factory):
26+
def test_polyhedra_color(
27+
server: ServerMonitor, dataset_factory: Callable[..., str]
28+
) -> None:
2329
test_register_mesh(server, dataset_factory)
2430

2531
server.call(
@@ -30,7 +36,9 @@ def test_polyhedra_color(server, dataset_factory):
3036
assert server.compare_image(3, "mesh/polyhedra/color.jpeg") == True
3137

3238

33-
def test_polyhedra_visibility(server, dataset_factory):
39+
def test_polyhedra_visibility(
40+
server: ServerMonitor, dataset_factory: Callable[..., str]
41+
) -> None:
3442
test_register_mesh(server, dataset_factory)
3543

3644
server.call(
@@ -41,7 +49,9 @@ def test_polyhedra_visibility(server, dataset_factory):
4149
assert server.compare_image(3, "mesh/polyhedra/visibility.jpeg") == True
4250

4351

44-
def test_vertex_attribute(server, dataset_factory):
52+
def test_vertex_attribute(
53+
server: ServerMonitor, dataset_factory: Callable[..., str]
54+
) -> None:
4555
test_register_mesh(server, dataset_factory)
4656

4757
server.call(
@@ -52,7 +62,9 @@ def test_vertex_attribute(server, dataset_factory):
5262
assert server.compare_image(3, "mesh/polyhedra/vertex_attribute.jpeg") == True
5363

5464

55-
def test_polyhedron_attribute(server, dataset_factory):
65+
def test_polyhedron_attribute(
66+
server: ServerMonitor, dataset_factory: Callable[..., str]
67+
) -> None:
5668
test_register_mesh(server, dataset_factory)
5769

5870
server.call(

0 commit comments

Comments
 (0)