Skip to content

Commit b6847ab

Browse files
committed
rm bool_render
1 parent 0f75aac commit b6847ab

File tree

5 files changed

+3
-30
lines changed

5 files changed

+3
-30
lines changed

src/opengeodeweb_viewer/rpc/viewer/schemas/update_camera.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,9 @@
4545
"view_angle",
4646
"clipping_range"
4747
]
48-
},
49-
"bool_render": {
50-
"type": "boolean",
51-
"default": true
5248
}
5349
},
5450
"required": [
55-
"camera_options",
56-
"bool_render"
51+
"camera_options"
5752
]
5853
}

src/opengeodeweb_viewer/rpc/viewer/viewer_protocols.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ def updateCamera(self, params):
263263
position = camera_options["position"]
264264
view_angle = camera_options["view_angle"]
265265
clipping_range = camera_options["clipping_range"]
266-
bool_render = params["bool_render"]
267266

268267
renderWindow = self.getView("-1")
269268
camera = renderWindow.GetRenderers().GetFirstRenderer().GetActiveCamera()
@@ -273,17 +272,11 @@ def updateCamera(self, params):
273272
camera.SetPosition(*position)
274273
camera.SetViewAngle(view_angle)
275274
camera.SetClippingRange(*clipping_range)
276-
277-
print(f"bool_render: {bool_render}", flush=True)
278-
if bool_render == True:
279-
print("render", flush=True)
280-
renderWindow.Render()
281-
self.render()
282-
return
275+
self.render()
283276

284277
@exportRpc(viewer_prefix + viewer_schemas_dict["render_now"]["rpc"])
285278
def renderNow(self, params):
286-
validate_schema(
279+
params = validate_schema(
287280
params, self.viewer_schemas_dict["render_now"], self.viewer_prefix
288281
)
289282

-1.22 KB
Loading
-1.22 KB
Loading

src/tests/test_viewer_protocols.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -221,20 +221,6 @@ def test_update_camera(server):
221221
[
222222
{
223223
"camera_options": camera_options,
224-
"bool_render": False
225-
}
226-
],
227-
)
228-
server.compare_image(1, "mesh/register.jpeg")
229-
230-
231-
server.call(
232-
VtkViewerView.viewer_prefix
233-
+ VtkViewerView.viewer_schemas_dict["update_camera"]["rpc"],
234-
[
235-
{
236-
"camera_options": camera_options,
237-
"bool_render": True
238224
}
239225
],
240226
)
@@ -259,7 +245,6 @@ def test_render_now(server):
259245
[
260246
{
261247
"camera_options": camera_options,
262-
"bool_render": False
263248
}
264249
],
265250
)

0 commit comments

Comments
 (0)