Skip to content

Commit 506ec69

Browse files
authored
Merge branch 'next' into fix/0
2 parents 8a23da2 + 9155949 commit 506ec69

File tree

11 files changed

+52
-29
lines changed

11 files changed

+52
-29
lines changed

app/pages/index.vue

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,24 @@
2626
import viewer_schemas from "@geode/opengeodeweb-viewer/opengeodeweb_viewer_schemas.json"
2727
import Status from "@ogw_f/utils/status.js"
2828
29+
const query = useRoute().query
30+
if (query.geode_port) {
31+
console.log(
32+
"Modifying geode port from query parameters to",
33+
query.geode_port,
34+
)
35+
const geodeStore = useGeodeStore()
36+
geodeStore.$patch({ default_local_port: query.geode_port })
37+
}
38+
if (query.viewer_port) {
39+
console.log(
40+
"Modifying viewer port from query parameters to",
41+
query.viewer_port,
42+
)
43+
const viewerStore = useViewerStore()
44+
viewerStore.$patch({ default_local_port: query.viewer_port })
45+
}
46+
2947
const infra_store = useInfraStore()
3048
const viewer_store = useViewerStore()
3149
const menuStore = useMenuStore()

electron/main.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
executable_name,
99
kill_back,
1010
kill_viewer,
11+
get_available_port,
1112
run_back,
1213
run_viewer,
1314
delete_folder_recursive,
@@ -27,25 +28,23 @@ let mainWindow = null
2728
let back_port = 0
2829
let viewer_port = 0
2930

30-
ipcMain.handle("run_back", async (_event, ...args) => {
31+
ipcMain.handle("run_back", async (_event) => {
3132
const back_command = path.join(
3233
executable_path(path.join("microservices", "back")),
3334
executable_name("vease-back"),
3435
)
3536
back_port = await run_back(back_command, {
36-
port: args[0],
37-
data_folder_path: project_folder_path,
37+
project_folder_path: project_folder_path,
3838
})
3939
return back_port
4040
})
41-
ipcMain.handle("run_viewer", async (_event, ...args) => {
41+
ipcMain.handle("run_viewer", async (_event) => {
4242
const viewer_command = path.join(
4343
executable_path(path.join("microservices", "viewer")),
4444
executable_name("vease-viewer"),
4545
)
4646
viewer_port = await run_viewer(viewer_command, {
47-
port: args[0],
48-
data_folder_path: project_folder_path,
47+
project_folder_path: project_folder_path,
4948
})
5049
return viewer_port
5150
})

electron/preload.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
const { contextBridge, ipcRenderer } = require("electron")
22

33
contextBridge.exposeInMainWorld("electronAPI", {
4-
run_back: async (port) => {
5-
const result = await ipcRenderer.invoke("run_back", port)
4+
run_back: async () => {
5+
const result = await ipcRenderer.invoke("run_back")
66
return result
77
},
8-
run_viewer: async (port) => {
9-
const result = await ipcRenderer.invoke("run_viewer", port)
8+
run_viewer: async () => {
9+
const result = await ipcRenderer.invoke("run_viewer")
1010
return result
1111
},
1212
new_window: async (args) => {

microservices/back/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@
55
# pip-compile --output-file=microservices/back/requirements.txt microservices/back/requirements.in
66
#
77

8+
vease-back==1.*,>=1.6.5rc1

microservices/viewer/requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@
55
# pip-compile --output-file=microservices/viewer/requirements.txt microservices/viewer/requirements.in
66
#
77

8+
vease-viewer==2.*,>=2.3.18rc1

nuxt.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,8 @@ export default defineNuxtConfig({
127127

128128
router: {
129129
options: {
130-
hashMode: true,
130+
hashMode:
131+
process.env.BROWSER && process.env.BROWSER == "true" ? false : true,
131132
},
132133
},
133134

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
"build:viewer": "node node_scripts/run_script_file.js viewer/build",
2929
"build:microservices": "concurrently \"npm run build:back\" \"npm run build:viewer\"",
3030
"package": "npm run build && electron-builder build --publish=never",
31-
"internal:browser": "node node_scripts/browser.js preview:browser",
3231
"test:e2e:browser": "npx playwright test --config ./tests/e2e/browser/playwright.config.js",
3332
"test:e2e:desktop": "npx playwright test --config ./tests/e2e/desktop/playwright.config.js"
3433
},

tests/e2e/browser/browser.test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,14 @@ import { isWindows } from "std-env"
88
import { run_browser_wrapper } from "../../../utils/local"
99

1010
test.beforeEach(async ({ page }) => {
11-
const NUXT_PORT = await run_browser_wrapper(`internal:browser`)
12-
console.log("NUXT_PORT", NUXT_PORT)
13-
await page.goto(`http://localhost:${NUXT_PORT}/`)
14-
console.log("setViewportSize")
11+
const ports = await run_browser_wrapper(`preview:browser`)
12+
console.log("ports", ports)
13+
const { geode_port, viewer_port, nuxt_port } = ports
14+
page.on("console", (msg) => console.log(`Browser console: ${msg.text()}`))
15+
await page.goto(
16+
`http://localhost:${nuxt_port}?geode_port=${geode_port}&viewer_port=${viewer_port}`,
17+
)
18+
console.log("Navigated to", page.url())
1519
await page.setViewportSize({ width: 1200, height: 800 })
1620
})
1721

tests/e2e/browser/playwright.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default defineConfig({
1313
testDir: "./",
1414
timeout: (isWindows ? 60 : 30) * 1000,
1515
/* Run tests in files in parallel */
16-
fullyParallel: false,
16+
fullyParallel: true,
1717
/* Fail the build on CI if you accidentally left test.only in the source code. */
1818
forbidOnly: !!process.env.CI,
1919
/* Retry on CI only */

tests/e2e/desktop/playwright.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default defineConfig({
1212
testDir: "./",
1313
timeout: (isWindows ? 60 : 30) * 1000,
1414
/* Run tests in files in parallel */
15-
fullyParallel: false,
15+
fullyParallel: true,
1616
/* Fail the build on CI if you accidentally left test.only in the source code. */
1717
forbidOnly: !!process.env.CI,
1818
/* Retry on CI only */

0 commit comments

Comments
 (0)