-
Notifications
You must be signed in to change notification settings - Fork 53
Description
I followed the README installation instructions. Running the tests fails with ModuleNotFoundError: No module named 'volestipy'.
Also, poetry install fails because build.py imports setuptools, which produces the error ModuleNotFoundError: No module named 'setuptools'. I believe this happens because setuptools is not included in the [build-system].requires list in pyproject.toml.
To Reproduce
- Fork and clone the repository and
cdinto the clone directory - set the python version to 3.8.x( I did this by
pyenv local 3.8.20and confirmed the version bypython --version) git submodule update --init- Follow the README for downloading Boost & Ipsolve libraries.
- Install system dependencies( since I am on Fedora, I did this by
sudo dnf install suitesparse suitesparse-devel) - install poetry by
curl -sSL https://install.python-poetry.org | python3 - --version 1.3.2 poetry install
Observe thesetuptoolserror. After I added'setuptools'to the[build-system].requireslist inpyproject.toml, the installation completed without errors.- install gurobi (not mandatory to reproduce the error)
- Execute
python tests/fba.py
Observe the error:
Traceback (most recent call last):
File "tests/fba.py", line 12, in <module>
from dingo import MetabolicNetwork
File "/home/adot/projects/geomscaleTesting/dingo/dingo/__init__.py", line 28, in <module>
from dingo.PolytopeSampler import PolytopeSampler
File "/home/adot/projects/geomscaleTesting/dingo/dingo/PolytopeSampler.py", line 22, in <module>
from volestipy import HPolytope
ModuleNotFoundError: No module named 'volestipy'Expected behavior
-
poetry installshould execute without error. Adding'setuptools'to[build-system].requireslistpyproject.tomlis necessary for this. -
Running the tests should execute without error.
Environment
OS: Fedora Linux 42
Python: 3.8.20
Additional context
I can prepare a PR adding setuptools to the build-system requires list. I am still trying to figure out the volestipy dependency part though. I would appreciate any guidance on this.