Skip to content

Commit fc4c6ea

Browse files
authored
Add gqa filter param to composites cli (#132)
* add gqa filter param to composites cli add gqa filter param to composites cli Allows turning on and off the gqa filter when loading data for tidal composites. * Automatically update integration test validation results
1 parent c69b056 commit fc4c6ea

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

intertidal/composites.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -335,11 +335,19 @@ def tidal_composites(
335335
"(e.g. < 20) often correspond with sunglint. Defaults to 20, "
336336
"which will mask all pixels with a glint angle of less than 20.",
337337
)
338+
@click.option(
339+
"--gqa_filter/--no-gqa_filter",
340+
type=bool,
341+
default=True,
342+
help="Whether to filter scenes when loading data based on gqa values. "
343+
"Defaults to True",
344+
)
338345
@click.option(
339346
"--include_coastal_aerosol/--no-include_coastal_aerosol",
340347
type=bool,
341348
default=True,
342-
help="Whether to include the coastal aerosol band",
349+
help="Whether to include the coastal aerosol band. "
350+
"Defaults to True",
343351
)
344352
@click.option(
345353
"--eps",
@@ -404,6 +412,7 @@ def tidal_composites_cli(
404412
threshold_hightide,
405413
min_obs,
406414
mask_sunglint,
415+
gqa_filter,
407416
include_coastal_aerosol,
408417
eps,
409418
cpus,
@@ -463,7 +472,7 @@ def tidal_composites_cli(
463472
crs="EPSG:3577",
464473
include_s2=True,
465474
include_ls=False,
466-
filter_gqa=True,
475+
filter_gqa=gqa_filter,
467476
ndwi=False,
468477
mask_sunglint=mask_sunglint,
469478
include_coastal_aerosol=include_coastal_aerosol,

tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Integration tests
1010
1111
This directory contains tests that are run to verify that DEA Intertidal code runs correctly. The ``test_intertidal.py`` file runs a small-scale full workflow analysis over an intertidal flat in the Gulf of Carpentaria using the DEA Intertidal [Command Line Interface (CLI) tools](../notebooks/Intertidal_CLI.ipynb), and compares these results against a LiDAR validation DEM to produce some simple accuracy metrics.
1212

13-
The latest integration test completed at **2025-04-28 16:23**. Compared to the previous run, it had an:
13+
The latest integration test completed at **2025-05-02 11:43**. Compared to the previous run, it had an:
1414
- RMSE accuracy of **0.14 m ( :heavy_minus_sign: no change)**
1515
- MAE accuracy of **0.12 m ( :heavy_minus_sign: no change)**
1616
- Bias of **0.12 m ( :heavy_minus_sign: no change)**

tests/validation.csv

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,3 +107,4 @@ time,Correlation,RMSE,MAE,R-squared,Bias,Regression slope
107107
2025-04-28 01:32:00.287768+00:00,0.975,0.145,0.123,0.95,0.117,1.119
108108
2025-04-28 02:09:27.190062+00:00,0.975,0.145,0.123,0.95,0.117,1.119
109109
2025-04-28 06:23:57.332550+00:00,0.975,0.145,0.123,0.95,0.117,1.119
110+
2025-05-02 01:43:13.002005+00:00,0.975,0.145,0.123,0.95,0.117,1.119

tests/validation.jpg

109 Bytes
Loading

0 commit comments

Comments
 (0)