Skip to content

Commit 8b8d951

Browse files
committed
NPI-4067 tidy up comments based on PR feedback
1 parent 0fbfae5 commit 8b8d951

File tree

1 file changed

+2
-11
lines changed

1 file changed

+2
-11
lines changed

gnssanalysis/gn_io/sp3.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -507,17 +507,6 @@ def mapparm(old: Tuple[float, float], new: Tuple[float, float]) -> Tuple[float,
507507
return offset, scale_factor
508508

509509

510-
# Hypothetically we could do this to the whole file, but we'd need a good way to parse over the header...
511-
# def _check_sp3_line_length_column_alignment(
512-
# data: bytes | str,
513-
# strict_mode: type[StrictMode] = StrictModes.STRICT_WARN,
514-
# ignore_short_data_lines: bool = True,
515-
# ) -> bool:
516-
# """
517-
518-
# """
519-
520-
521510
def _check_column_alignment_of_sp3_block(
522511
date: str,
523512
data: str,
@@ -534,6 +523,8 @@ def _check_column_alignment_of_sp3_block(
534523
even though this is technically not to spec under SP3 version d. Defaults to True.
535524
:raises ValueError: if validation doesn't pass, and strict_mode is set to STRICT_RAISE.
536525
"""
526+
# NOTE: we currently only run these checks on individual SP3 blocks, not the entire file.
527+
537528
# Check epoch header (date) and data lines (P/V/EP/EV) are the right length, and that all unused columns (by SP3d
538529
# spec) are in fact blank (contain spaces). If this is not true, it probably indicates column misalignment which
539530
# will lead to incorrect parsing.

0 commit comments

Comments
 (0)