Incorrect time types

[CourchesneA]

In the request for trips, I get duration information (ex in the drivingDuration field) in a datetime.time format, which should be reserved for a time of the day. I would assume this would throw errors for duration more than 24 hours but I think the API happens to return only duration < 24.

It is really annoying since I can't process the data directly since no operation are supported between datetime.time objects. It would be great if duration could be parsed into a datetime.timedelta instead,.

[joakimnordling]

I decided to have a bit of a look into this, since I'm evaluating to use this library for a project.

If you have python-rapidjson installed, which you likely have, since this library requires it, the deserialization will be handled by python-rapidjson.

I decided to mimic the way this library uses rapidjson to deserialize data and here's how it treats the string "01:01:01" vs "25:01:01":

>>> import rapidjson
>>> DATETIME_MODE = rapidjson.DM_SHIFT_TO_UTC | rapidjson.DM_ISO8601
>>> rapidjson.loads("{\"drivingDuration\": \"01:01:01\"}", datetime_mode=DATETIME_MODE)
{'drivingDuration': datetime.time(1, 1, 1)}
>>> rapidjson.loads("{\"drivingDuration\": \"25:01:01\"}", datetime_mode=DATETIME_MODE)
{'drivingDuration': '25:01:01'}

So the latter becomes a string, whereas the first becomes a datetime.time.

Unless I'm missing something, you will get some funny problems if you manage to get something that looks like a time into a string field, because from what it looks like it's not relying on any kind of schema, just checking if the value looks like a time.