manifest_xml, git_superproject: Rename an argument for XmlManifest.ToXml()

Rename the groups argument to filter_groups to make it more clear what
kind of groups it refers to.

Change-Id: I90e6e9aa74a7e3e697705dd4bf8676226055878b
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/528461
Reviewed-by: Mike Frysinger <[email protected]>
Commit-Queue: Peter Kjellerstedt <[email protected]>
Tested-by: Peter Kjellerstedt <[email protected]>
Reviewed-by: Gavin Mak <[email protected]>

Author: Peter Kjellerstedt

git_superproject.py

@@ -422,7 +422,7 @@ def _WriteManifestFile(self):
             )
             return None
         manifest_str = self._manifest.ToXml(
-            groups=self._manifest.GetGroupsStr(), omit_local=True
+            filter_groups=self._manifest.GetGroupsStr(), omit_local=True
         ).toxml()
         manifest_path = self._manifest_path
         try:

manifest_xml.py

@@ -579,16 +579,16 @@ def ToXml(
         peg_rev=False,
         peg_rev_upstream=True,
         peg_rev_dest_branch=True,
-        groups=None,
+        filter_groups=None,
         omit_local=False,
     ):
         """Return the current manifest XML."""
         mp = self.manifestProject
 
-        if groups is None:
-            groups = mp.manifest_groups
-        if groups:
-            groups = self._ParseList(groups)
+        if filter_groups is None:
+            filter_groups = mp.manifest_groups
+        if filter_groups:
+            filter_groups = self._ParseList(filter_groups)
 
         doc = xml.dom.minidom.Document()
         root = doc.createElement("manifest")
@@ -661,7 +661,7 @@ def output_projects(parent, parent_node, projects):
                     output_project(parent, parent_node, project)
 
         def output_project(parent, parent_node, p):
-            if not p.MatchesGroups(groups):
+            if not p.MatchesGroups(filter_groups):
                 return
 
             if omit_local and self.IsFromLocalManifest(p):
@@ -732,9 +732,9 @@ def output_project(parent, parent_node, p):
                 le.setAttribute("dest", lf.dest)
                 e.appendChild(le)
 
-            egroups = p.groups - {"all", f"name:{p.name}", f"path:{p.relpath}"}
-            if egroups:
-                e.setAttribute("groups", ",".join(sorted(egroups)))
+            groups = p.groups - {"all", f"name:{p.name}", f"path:{p.relpath}"}
+            if groups:
+                e.setAttribute("groups", ",".join(sorted(groups)))
 
             for a in p.annotations:
                 if a.keep == "true":