forall: Fix returning results early

rc should be returned only after all results are processed.

[email protected]

Bug: b/376454189
Change-Id: I8200b9954240dd3e8e9f2ab82494779a3cb38627
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/440901
Tested-by: Josip Sokcevic <[email protected]>
Commit-Queue: Josip Sokcevic <[email protected]>
Reviewed-by: Joanna Wang <[email protected]>

Author: sokcevicG

subcmds/forall.py

@@ -279,7 +279,7 @@ def _ProcessResults(_pool, _output, results):
                 rc = rc or r
                 if r != 0 and opt.abort_on_errors:
                     raise Exception("Aborting due to previous error")
-                return rc
+            return rc
 
         try:
             config = self.manifest.manifestProject.config
@@ -298,15 +298,15 @@ def _ProcessResults(_pool, _output, results):
                 )
         except (KeyboardInterrupt, WorkerKeyboardInterrupt):
             # Catch KeyboardInterrupt raised inside and outside of workers
-            rc = rc or errno.EINTR
+            rc = errno.EINTR
         except Exception as e:
             # Catch any other exceptions raised
             logger.error(
                 "forall: unhandled error, terminating the pool: %s: %s",
                 type(e).__name__,
                 e,
             )
-            rc = rc or getattr(e, "errno", 1)
+            rc = getattr(e, "errno", 1)
         if rc != 0:
             sys.exit(rc)