Fix dependency check and enhance alternative suggestions in build scripts

Author: dvershinin

EXTERNAL_BUILD_SCRIPT.md

@@ -77,11 +77,13 @@ This ensures you always get the latest build logic without waiting for Docker im
 
 To prevent infinite recursion, the system works as follows:
 
-1. **Local script** checks if `--no-fetch` is present
-2. **If not present**: Fetches latest version and executes it with `--no-fetch`
-3. **Fetched script**: Sees `--no-fetch` and skips fetching, runs normally
+1. **Local script** stores `--no-fetch` flag in `NO_FETCH` variable during argument parsing
+2. **If `NO_FETCH` is false**: Fetches latest version and executes it with `--no-fetch`
+3. **Fetched script**: Processes `--no-fetch` and sets `NO_FETCH=true`, skips fetching
 4. **Result**: Only one fetch per execution, no infinite loops
 
+**Fixed**: Previously there was a bug where `--no-fetch` was consumed during argument parsing, causing infinite recursion. This has been resolved by properly storing the flag before processing arguments.
+
 ```
 Execution Flow:
 ┌─────────────────┐    ┌─────────────────┐    ┌─────────────────┐

assets/build

@@ -223,19 +223,28 @@ build_package() {
     # Check for missing dependencies first
     if [[ -f "/usr/bin/check-deps.sh" ]]; then
         echo "Checking build dependencies..."
+        # Ensure the script has execute permissions
+        chmod +x /usr/bin/check-deps.sh || true
         /usr/bin/check-deps.sh || {
             echo "Dependency check failed. Attempting to install anyway..."
         }
     fi
 
     # Try to install build dependencies using mk-build-deps
+    echo "Installing build dependencies using mk-build-deps..."
     if ! mk-build-deps -t "apt-get --no-install-recommends -y" -ir; then
         echo "Failed to install build dependencies using mk-build-deps."
         echo "This usually means there are missing packages in the distribution repositories."
-        echo "Please check the debian/control file and ensure all Build-Depends are available."
         echo ""
-        echo "You can run the dependency checker manually:"
-        echo "  /usr/bin/check-deps.sh"
+        echo "Checking which packages are missing..."
+        if [[ -f "/usr/bin/check-deps.sh" ]]; then
+            chmod +x /usr/bin/check-deps.sh || true
+            /usr/bin/check-deps.sh
+        fi
+        echo ""
+        echo "You can also check manually:"
+        echo "  apt-cache policy <package-name>"
+        echo "  apt-cache search <package-name>"
         return 1
     fi
 

assets/check-deps.sh

@@ -25,11 +25,47 @@ suggest_alternatives() {
             echo "   💡 Alternative: python3-appdirs might be available as python3-appdirs2 or similar"
             echo "   💡 Or you can add it to debian/control as a conditional dependency"
             ;;
+        python3-appdirs2)
+            echo "   💡 Alternative: python3-appdirs2 might be available as python3-appdirs or similar"
+            echo "   💡 Or you can add it to debian/control as a conditional dependency"
+            ;;
         python3-requests)
             echo "   💡 Alternative: python3-urllib3 or python3-httplib2"
             ;;
+        python3-cachecontrol)
+            echo "   💡 Alternative: python3-cachecontrol might not be available in this distribution"
+            echo "   💡 Consider using python3-requests-cache or similar"
+            ;;
+        python3-bs4)
+            echo "   💡 Alternative: python3-beautifulsoup4"
+            ;;
+        python3-beautifulsoup4)
+            echo "   💡 Alternative: python3-bs4"
+            ;;
+        python3-html5lib)
+            echo "   💡 Alternative: python3-html5lib might not be available in this distribution"
+            echo "   💡 Consider using python3-lxml or similar"
+            ;;
+        python3-lxml)
+            echo "   💡 Alternative: python3-html5lib"
+            ;;
+        python3-cachecontrol)
+            echo "   💡 Alternative: python3-cachecontrol might not be available in this distribution"
+            echo "   💡 Consider using python3-requests-cache or similar"
+            ;;
+        python3-requests-cache)
+            echo "   💡 Alternative: python3-cachecontrol"
+            ;;
+        pandoc)
+            echo "   💡 Alternative: pandoc might not be available in this distribution"
+            echo "   💡 Consider making it optional or using python3-docutils"
+            ;;
+        python3-docutils)
+            echo "   💡 Alternative: pandoc"
+            ;;
         *)
             echo "   💡 Check if this package has a different name in this distribution"
+            echo "   💡 Try: apt-cache search $package"
             ;;
     esac
 }
@@ -46,12 +82,36 @@ if [[ -f "debian/control" ]]; then
     while IFS= read -r dep; do
         # Skip empty lines and version constraints for now
         if [[ -n "$dep" && ! "$dep" =~ ^[[:space:]]*$ ]]; then
-            # Extract package name (remove version constraints)
-            package=$(echo "$dep" | sed 's/[[:space:]]*([^)]*)[[:space:]]*$//')
-            
-            if ! check_package "$package"; then
-                missing_packages+=("$package")
-                suggest_alternatives "$package"
+            # Handle conditional dependencies (e.g., "package1 | package2")
+            if [[ "$dep" == *"|"* ]]; then
+                # Split by | and check each alternative
+                alternatives=$(echo "$dep" | tr '|' '\n' | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
+                found_alternative=false
+                
+                while IFS= read -r alt; do
+                    # Extract package name (remove version constraints)
+                    package=$(echo "$alt" | sed 's/[[:space:]]*([^)]*)[[:space:]]*$//')
+                    
+                    if check_package "$package"; then
+                        echo "✅ Found alternative: $package (for: $dep)"
+                        found_alternative=true
+                        break
+                    fi
+                done <<< "$alternatives"
+                
+                if [[ "$found_alternative" == "false" ]]; then
+                    echo "❌ No alternatives found for: $dep"
+                    missing_packages+=("$dep")
+                    suggest_alternatives "$(echo "$dep" | cut -d'|' -f1 | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')"
+                fi
+            else
+                # Extract package name (remove version constraints)
+                package=$(echo "$dep" | sed 's/[[:space:]]*([^)]*)[[:space:]]*$//')
+                
+                if ! check_package "$package"; then
+                    missing_packages+=("$package")
+                    suggest_alternatives "$package"
+                fi
             fi
         fi
     done <<< "$build_deps"