Extract hasImgurImage helper method

Author: zsmb13

samplejava/src/main/java/com/example/chattutorialjava/ImgurAttachmentViewHolderFactory.java

@@ -19,41 +19,40 @@ class ImgurAttachmentViewHolderFactory extends MessageListItemViewHolderFactory
 
     @Override
     public int getItemViewType(@NotNull MessageListItem item) {
+        if (hasImgurImage(item)) {
+            return IMGUR;
+        }
+        return super.getItemViewType(item);
+    }
+
+    @NotNull
+    @Override
+    public BaseMessageItemViewHolder<? extends MessageListItem> createViewHolder(@NotNull ViewGroup parentView, int viewType) {
+        boolean isImgur = viewType == IMGUR;
+        return isImgur ? ImgurAttachmentViewHolder.create(parentView) : super.createViewHolder(parentView, viewType);
+    }
 
-        boolean isMessageItem = item instanceof MessageListItem.MessageItem;
-        if (!isMessageItem) {
-            return super.getItemViewType(item);
+    private boolean hasImgurImage(MessageListItem item) {
+        if (!(item instanceof MessageListItem.MessageItem)) {
+            return false;
         }
 
         Message message = ((MessageListItem.MessageItem) item).getMessage();
         List<Attachment> attachments = message.getAttachments();
-
         if (attachments == null || attachments.isEmpty()) {
-            return super.getItemViewType(item);
+            return false;
         }
 
         Attachment attachment = attachments.get(0);
         if (attachment == null) {
-            return super.getItemViewType(item);
+            return false;
         }
 
         String imageUrl = attachment.getImageUrl();
         if (imageUrl == null) {
-            return super.getItemViewType(item);
+            return false;
         }
 
-        boolean isImgur = imageUrl.contains("imgur");
-        if (isImgur) {
-            return IMGUR;
-        }
-
-        return super.getItemViewType(item);
-    }
-
-    @NotNull
-    @Override
-    public BaseMessageItemViewHolder<? extends MessageListItem> createViewHolder(@NotNull ViewGroup parentView, int viewType) {
-        boolean isImgur = viewType == IMGUR;
-        return isImgur ? ImgurAttachmentViewHolder.create(parentView) : super.createViewHolder(parentView, viewType);
+        return imageUrl.contains("imgur");
     }
 }