Skip to content

Commit 933f5d4

Browse files
committed
Improve third Java sample
1 parent f5b07d5 commit 933f5d4

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

samplejava/src/main/java/com/example/chattutorialjava/ChannelActivity3.java

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import android.content.Context;
44
import android.content.Intent;
55
import android.os.Bundle;
6+
import android.text.TextUtils;
67
import android.widget.TextView;
78

89
import androidx.activity.OnBackPressedCallback;
@@ -24,6 +25,9 @@
2425
import com.getstream.sdk.chat.viewmodel.messages.MessageListViewModel.State.NavigateUp;
2526
import com.getstream.sdk.chat.viewmodel.messages.MessageListViewModelBinding;
2627

28+
import java.util.LinkedList;
29+
import java.util.List;
30+
2731
import io.getstream.chat.android.client.models.Channel;
2832
import io.getstream.chat.android.client.models.User;
2933
import io.getstream.chat.android.livedata.ChatDomain;
@@ -118,15 +122,12 @@ public void handleOnBackPressed() {
118122
if (users.isEmpty()) {
119123
typingHeader.setText(nobodyTyping);
120124
} else {
121-
StringBuilder typingText = new StringBuilder("typing: ");
122-
for (int i = 0; i < users.size(); i++) {
123-
User user = users.get(i);
124-
if (i > 0) {
125-
typingText.append(", ");
126-
}
127-
typingText.append(user.getExtraData().get("name"));
125+
List<String> userNames = new LinkedList<>();
126+
for (User user : users) {
127+
userNames.add((String)user.getExtraData().get("name"));
128128
}
129-
typingHeader.setText(typingText.toString());
129+
String typing = "typing: " + TextUtils.join(", ", userNames);
130+
typingHeader.setText(typing);
130131
}
131132
});
132133
});

samplekotlin/src/main/java/com/example/chattutorial/ChannelActivity4.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ class ChannelActivity4 : AppCompatActivity() {
9090
.channel(cid)
9191
.subscribeFor(this, TypingStartEvent::class, TypingStopEvent::class
9292
) { event ->
93+
@Suppress("NON_EXHAUSTIVE_WHEN_ON_SEALED_CLASS")
9394
when (event) {
9495
is TypingStartEvent -> currentlyTyping.add(event.user.name)
9596
is TypingStopEvent -> currentlyTyping.remove(event.user.name)

0 commit comments

Comments
 (0)