Skip to content

Commit 707943f

Browse files
authored
fix proto breaking change (#843)
1 parent 8fdd3f9 commit 707943f

File tree

4 files changed

+39
-40
lines changed

4 files changed

+39
-40
lines changed

generate.sh

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ PB=$REPO/protobuf
77

88
export PATH=/opt/.protoc/bin:$PWD/.protoc/bin:$PATH
99

10-
REALPATH=${REALPATH:-$(if [[ "$OSTYPE" == "darwin"* ]]; then echo "grealpath"; else echo "realpath"; fi)}
11-
if ! command -v $REALPATH &> /dev/null; then
12-
echo "$REALPATH command not found. Please install it and try again."
13-
exit 1
14-
fi
10+
# In some systems like Mac OS 13.0.1, the realpath defaults to
11+
# the system installed one which does not support flags like
12+
# --relative-path. This results in the scripts erroring out.
13+
# The coreutils installed with Homebrew (as mentioned in README)
14+
# installs GNU realpath which could be available as "grealpath"
15+
# which actually works. Hence, the option to customize REALPATH
16+
REALPATH=${REALPATH:-realpath}
1517

1618
GEN_PROFILE=${1:-go}
1719

protobuf/video/sfu/models/models.pb.go

Lines changed: 2 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

protobuf/video/sfu/models/models.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ message PublishOption {
122122
}
123123

124124
message Codec {
125-
uint32 payload_type = 13;
125+
uint32 payload_type = 16;
126126
string name = 10;
127127
uint32 clock_rate = 14;
128128
string encoding_parameters = 15;

protobuf/video/sfu/models/models_vtproto.pb.go

Lines changed: 29 additions & 27 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)