Rename MessageReceiptReporter.init to start and add logging

Author: andremion

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/receipts/MessageReceiptReporter.kt

@@ -38,38 +38,42 @@ internal class MessageReceiptReporter(
 
     private val logger by taggedLogger("Chat:MessageReceiptReporter")
 
-    fun init() {
-        logger.d { "Initializing…" }
+    fun start() {
+        logger.d { "Starting reporter…" }
         scope.launch {
-            while (isActive) {
-                val messages = messageReceiptRepository.getAllMessageReceiptsByType(
-                    type = MessageReceipt.TYPE_DELIVERY,
-                    limit = MAX_BATCH_SIZE,
-                ).map { receipt ->
-                    Message(
-                        id = receipt.messageId,
-                        cid = receipt.cid,
-                    )
-                }
+            try {
+                while (isActive) {
+                    val messages = messageReceiptRepository.getAllMessageReceiptsByType(
+                        type = MessageReceipt.TYPE_DELIVERY,
+                        limit = MAX_BATCH_SIZE,
+                    ).map { receipt ->
+                        Message(
+                            id = receipt.messageId,
+                            cid = receipt.cid,
+                        )
+                    }
 
-                if (messages.isNotEmpty()) {
-                    logger.d { "Reporting delivery receipts for ${messages.size} messages…" }
-                    chatClient.markMessagesAsDelivered(messages)
-                        .execute()
-                        .onSuccessSuspend {
-                            logger.d { "Successfully reported delivery receipts for ${messages.size} messages" }
-                            val deliveredMessageIds = messages.map(Message::id)
-                            messageReceiptRepository.deleteMessageReceiptsByMessageIds(deliveredMessageIds)
-                        }
-                        .onError { error ->
-                            logger.e {
-                                "Failed to report delivery receipts for ${messages.size} messages: " +
-                                    error.message
+                    if (messages.isNotEmpty()) {
+                        logger.d { "Reporting delivery receipts for ${messages.size} messages…" }
+                        chatClient.markMessagesAsDelivered(messages)
+                            .execute()
+                            .onSuccessSuspend {
+                                logger.d { "Successfully reported delivery receipts for ${messages.size} messages" }
+                                val deliveredMessageIds = messages.map(Message::id)
+                                messageReceiptRepository.deleteMessageReceiptsByMessageIds(deliveredMessageIds)
                             }
-                        }
-                }
+                            .onError { error ->
+                                logger.e {
+                                    "Failed to report delivery receipts for ${messages.size} messages: " +
+                                        error.message
+                                }
+                            }
+                    }
 
-                delay(REPORT_INTERVAL_IN_MS)
+                    delay(REPORT_INTERVAL_IN_MS)
+                }
+            } finally {
+                logger.d { "Reporter is no longer active" }
             }
         }
     }

stream-chat-android-client/src/test/java/io/getstream/chat/android/client/receipts/MessageReceiptReporterTest.kt

@@ -59,7 +59,7 @@ internal class MessageReceiptReporterTest {
             .givenMarkMessagesAsDelivered(messages)
         val sut = fixture.get(backgroundScope)
 
-        sut.init()
+        sut.start()
         advanceTimeBy(100) // Allow initial execution
 
         fixture.verifyMarkMessagesAsDeliveredCalled(messages = messages)
@@ -75,7 +75,7 @@ internal class MessageReceiptReporterTest {
             .givenMarkMessagesAsDelivered(error = mock())
         val sut = fixture.get(backgroundScope)
 
-        sut.init()
+        sut.start()
         advanceTimeBy(100) // Allow initial execution
 
         fixture.verifyDeleteByMessageIdsCalled(never())
@@ -94,7 +94,7 @@ internal class MessageReceiptReporterTest {
             .givenMessageReceipts(receipts = emptyList())
         val sut = fixture.get(backgroundScope)
 
-        sut.init()
+        sut.start()
         advanceTimeBy(100) // Allow initial execution
 
         fixture.verifyMarkMessagesAsDeliveredCalled(never())
@@ -108,7 +108,7 @@ internal class MessageReceiptReporterTest {
             .givenMarkMessagesAsDelivered()
         val sut = fixture.get(backgroundScope)
 
-        sut.init()
+        sut.start()
         advanceTimeBy(100) // Allow initial execution
 
         advanceTimeBy(1000) // Advance to the second interval
@@ -127,7 +127,7 @@ internal class MessageReceiptReporterTest {
             .givenMarkMessagesAsDelivered()
         val sut = fixture.get(backgroundScope)
 
-        sut.init()
+        sut.start()
         advanceTimeBy(100) // Allow initial execution
 
         backgroundScope.cancel()