Refactor ChatClientTest to simplify test setup

- Remove unused properties and simplify the `setUp` method.
- Make test properties `private`.
- Remove `runTest` from test function signatures as it's already handled by the `TestCoroutineExtension`.

Author: andremion

stream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientTest.kt

@@ -18,25 +18,20 @@ package io.getstream.chat.android.client
 
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.testing.TestLifecycleOwner
-import io.getstream.chat.android.client.api.ChatApi
 import io.getstream.chat.android.client.api.ChatClientConfig
 import io.getstream.chat.android.client.api2.mapping.DtoMapping
 import io.getstream.chat.android.client.clientstate.DisconnectCause
 import io.getstream.chat.android.client.clientstate.UserStateService
-import io.getstream.chat.android.client.errorhandler.factory.ErrorHandlerFactory
 import io.getstream.chat.android.client.errors.ChatErrorCode
 import io.getstream.chat.android.client.events.ChatEvent
 import io.getstream.chat.android.client.events.DisconnectedEvent
 import io.getstream.chat.android.client.events.UnknownEvent
 import io.getstream.chat.android.client.extensions.cidToTypeAndId
 import io.getstream.chat.android.client.network.NetworkStateProvider
-import io.getstream.chat.android.client.notifications.ChatNotifications
 import io.getstream.chat.android.client.notifications.handler.NotificationConfig
 import io.getstream.chat.android.client.parser.EventArguments
 import io.getstream.chat.android.client.parser2.adapters.internal.StreamDateFormatter
 import io.getstream.chat.android.client.persistance.repository.noop.NoOpRepositoryFactory
-import io.getstream.chat.android.client.persistence.repository.ChatClientRepository
-import io.getstream.chat.android.client.plugin.factory.PluginFactory
 import io.getstream.chat.android.client.scope.ClientTestScope
 import io.getstream.chat.android.client.scope.UserTestScope
 import io.getstream.chat.android.client.socket.FakeChatSocket
@@ -70,7 +65,7 @@ import java.util.Date
 
 internal class ChatClientTest {
 
-    companion object {
+    private companion object {
         @JvmField
         @RegisterExtension
         val testCoroutines = TestCoroutineExtension()
@@ -87,43 +82,36 @@ internal class ChatClientTest {
         val eventF = UnknownEvent("f", createdAt, rawCreatedAt, null, emptyMap<Any, Any>())
     }
 
-    lateinit var lifecycleOwner: TestLifecycleOwner
-    lateinit var api: ChatApi
-    lateinit var client: ChatClient
-    lateinit var fakeChatSocket: FakeChatSocket
-    lateinit var result: MutableList<ChatEvent>
-    val token = randomString()
-    val userId = randomString()
-    val user = randomUser(id = userId)
-    val tokenUtils: TokenUtils = mock()
-    var pluginFactories: List<PluginFactory> = emptyList()
-    var errorHandlerFactories: List<ErrorHandlerFactory> = emptyList()
-
-    @Suppress("LongMethod")
+    private lateinit var lifecycleOwner: TestLifecycleOwner
+    private lateinit var client: ChatClient
+    private lateinit var fakeChatSocket: FakeChatSocket
+    private lateinit var result: MutableList<ChatEvent>
+    private val token = randomString()
+    private val userId = randomString()
+    private val user = randomUser(id = userId)
+    private val tokenUtils: TokenUtils = mock()
+
     @BeforeEach
     fun setUp() {
         val apiKey = "api-key"
         val wssUrl = "socket.url"
         val config = ChatClientConfig(
-            apiKey,
-            "hello.http",
-            "cdn.http",
-            wssUrl,
-            false,
-            Mother.chatLoggerConfig(),
-            false,
-            false,
-            NotificationConfig(),
+            apiKey = apiKey,
+            httpUrl = "hello.http",
+            cdnHttpUrl = "cdn.http",
+            wssUrl = wssUrl,
+            warmUp = false,
+            loggerConfig = Mother.chatLoggerConfig(),
+            distinctApiCalls = false,
+            debugRequests = false,
+            notificationConfig = NotificationConfig(),
         )
         whenever(tokenUtils.getUserId(token)) doReturn userId
         lifecycleOwner = TestLifecycleOwner(coroutineDispatcher = testCoroutines.dispatcher)
-        api = mock()
-        val userStateService = UserStateService()
         val clientScope = ClientTestScope(testCoroutines.scope)
         val userScope = UserTestScope(clientScope)
         val lifecycleObserver = StreamLifecycleObserver(userScope, lifecycleOwner.lifecycle)
         val tokenManager = FakeTokenManager("")
-        val notifications = mock<ChatNotifications>()
         val networkStateProvider: NetworkStateProvider = mock()
         whenever(networkStateProvider.isConnected()) doReturn true
         fakeChatSocket = FakeChatSocket(
@@ -136,19 +124,19 @@ internal class ChatClientTest {
         )
         client = ChatClient(
             config = config,
-            api = api,
+            api = mock(),
             dtoMapping = DtoMapping(NoOpMessageTransformer, NoOpUserTransformer),
-            notifications = notifications,
+            notifications = mock(),
             tokenManager = tokenManager,
             userCredentialStorage = mock(),
-            userStateService = userStateService,
+            userStateService = UserStateService(),
             tokenUtils = tokenUtils,
             clientScope = clientScope,
             userScope = userScope,
             retryPolicy = NoRetryPolicy(),
             appSettingsManager = mock(),
             chatSocket = fakeChatSocket,
-            pluginFactories = pluginFactories,
+            pluginFactories = emptyList(),
             mutableClientState = Mother.mockedClientState(),
             repositoryFactoryProvider = NoOpRepositoryFactory.Provider,
             currentUserFetcher = mock(),
@@ -184,7 +172,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Simple subscribe for one event`() = runTest {
+    fun `Simple subscribe for one event`() {
         client.subscribe {
             result.add(it)
         }
@@ -195,7 +183,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Simple subscribe for multiple events`() = runTest {
+    fun `Simple subscribe for multiple events`() {
         client.subscribe {
             result.add(it)
         }
@@ -223,7 +211,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Subscribe for Java Class event types`() = runTest {
+    fun `Subscribe for Java Class event types`() {
         client.subscribeFor(eventA::class.java, eventC::class.java) {
             result.add(it)
         }
@@ -236,7 +224,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Subscribe for KClass event types`() = runTest {
+    fun `Subscribe for KClass event types`() {
         client.subscribeFor(eventA::class, eventC::class) {
             result.add(it)
         }
@@ -249,7 +237,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Subscribe for event types with type parameter`() = runTest {
+    fun `Subscribe for event types with type parameter`() {
         client.subscribeFor<UnknownEvent> {
             result.add(it)
         }
@@ -262,7 +250,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Subscribe for single string event type`() = runTest {
+    fun `Subscribe for single string event type`() {
         client.subscribeForSingle("d") {
             result.add(it)
         }
@@ -276,7 +264,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Subscribe for single event, with event type as type parameter`() = runTest {
+    fun `Subscribe for single event, with event type as type parameter`() {
         client.subscribeForSingle<UnknownEvent> {
             result.add(it)
         }
@@ -289,7 +277,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Unsubscribe from events`() = runTest {
+    fun `Unsubscribe from events`() {
         val disposable = client.subscribe {
             result.add(it)
         }
@@ -305,7 +293,7 @@ internal class ChatClientTest {
     }
 
     @Test
-    fun `Given connected user When handle event with updated user Should updated user value`() = runTest {
+    fun `Given connected user When handle event with updated user Should updated user value`() {
         val updateUser = user.copy(
             extraData = mutableMapOf(),
             name = "updateUserName",