Skip to content

Commit 294b967

Browse files
authored
Deprecate invalid getReactions method (#6039)
* Deprecate invalid getReactions method. * Update CHANGELOG.md. * Update DEPRECATIONS.md. * Remove tests. * Change deprecation level from error to warning.
1 parent c4021ac commit 294b967

File tree

5 files changed

+6
-12
lines changed

5 files changed

+6
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
### ⚠️ Changed
2525
- Deprecate `ChatClient.markThreadUnread(String, String, String, String)` because marking a thread as unread from a given message is currently not supported. [#6027](https://github.com/GetStream/stream-chat-android/pull/6027)
2626
- Deprecate `ChannelClient.markThreadUnread(String, String)` because marking a thread as unread from a given message is currently not supported. [#6027](https://github.com/GetStream/stream-chat-android/pull/6027)
27+
- Deprecate `ChannelClient.getReactions(messageId: String, firstReactionId: String, limit: Int)` because it is no longer supported. [#6039](https://github.com/GetStream/stream-chat-android/pull/6039)
2728

2829
### ❌ Removed
2930

DEPRECATIONS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ This document lists deprecated constructs in the SDK, with their expected time
44

55
| API / Feature | Deprecated (warning) | Deprecated (error) | Removed | Notes |
66
|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------|-----------------------|-----------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
7+
| `ChannelClient.getReactions(messageId: String, firstReactionId: String, limit: Int)` method | 2025.12.10 ⌛ | | | This method has been deprecated because it is no longer supported. Use `ChannelClient.getReactions(messageId: String, offset: Int, limit: Int)` instead. |
78
| `AttachmentsPickerViewModel.loadData()` method | 2025.12.10 ⌛ | | | This method is deprecated because it is no longer used and will be removed in future versions. |
89
| `ChatClient.markThreadUnread(channelType: String, channelId: String, threadId: String, mesageId: String)` method | 2025.11.24 ⌛ | | | This method is deprecated because marking a thread as unread from a given message is currently not supported, and the passed `messageId` is ignored. Use `ChatClient.markThreadUnread(channelType: String, channelId: String, threadId: String)` instead. |
910
| `ChannelClient.markThreadUnread(threadId: String, mesageId: String)` method | 2025.11.24 ⌛ | | | This method is deprecated because marking a thread as unread from a given message is currently not supported, and the passed `messageId` is ignored. Use `ChannelClient.markThreadUnread(threadId: String)` instead. |

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/channel/ChannelClient.kt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,10 @@ public class ChannelClient internal constructor(
673673
return client.getReactions(messageId, offset, limit)
674674
}
675675

676+
@Deprecated(
677+
message = "This operation is not supported. " +
678+
"Use ChannelClient.getReactions(messageId: String, offset: Int, limit: Int) instead.",
679+
)
676680
@CheckResult
677681
public fun getReactions(
678682
messageId: String,

stream-chat-android-docs/src/main/java/io/getstream/chat/docs/java/client/cms/Messages.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,11 +291,6 @@ public void paginatingReactions() {
291291
offset = 10;
292292
channelClient.getReactions("message-id", offset, limit)
293293
.enqueue(result -> { /* ... */ });
294-
295-
// Get 10 reactions after particular reaction
296-
String reactionId = "reaction-id";
297-
channelClient.getReactions("message-id", reactionId, limit)
298-
.enqueue(result -> { /* ... */ });
299294
}
300295

301296
/**

stream-chat-android-docs/src/main/kotlin/io/getstream/chat/docs/kotlin/client/cms/Messages.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -295,13 +295,6 @@ class Messages(
295295
offset = 10,
296296
limit = 10,
297297
).enqueue { /* ... */ }
298-
299-
// Get 10 reactions after particular reaction
300-
channelClient.getReactions(
301-
messageId = "message-id",
302-
firstReactionId = "reaction-id",
303-
limit = 10,
304-
).enqueue { /* ... */ }
305298
}
306299

307300
/**

0 commit comments

Comments
 (0)