Hide the message status indicator when a message is deleted

Author: andremion

stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/components/messages/MessageFooter.kt

@@ -44,6 +44,7 @@ import io.getstream.chat.android.compose.ui.util.clickable
 import io.getstream.chat.android.core.utils.date.truncateFuture
 import io.getstream.chat.android.models.Message
 import io.getstream.chat.android.ui.common.state.messages.list.MessageItemState
+import io.getstream.chat.android.ui.common.utils.extensions.shouldShowMessageStatusIndicator
 
 /**
  * Default message footer, which contains either [MessageThreadFooter] or the default footer, which
@@ -102,7 +103,7 @@ public fun MessageFooter(
                         maxLines = 1,
                         color = ChatTheme.colors.textLowEmphasis,
                     )
-                } else {
+                } else if (message.shouldShowMessageStatusIndicator()) {
                     ChatTheme.componentFactory.MessageFooterStatusIndicator(
                         params = MessageFooterStatusIndicatorParams(
                             modifier = Modifier.padding(end = 4.dp),

stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/utils/extensions/Message.kt

@@ -17,10 +17,13 @@
 package io.getstream.chat.android.ui.common.utils.extensions
 
 import io.getstream.chat.android.client.ChatClient
+import io.getstream.chat.android.client.utils.message.isDeleted
+import io.getstream.chat.android.client.utils.message.isEphemeral
 import io.getstream.chat.android.core.internal.InternalStreamChatApi
 import io.getstream.chat.android.models.Message
 import io.getstream.chat.android.models.MessageModerationAction
 import io.getstream.chat.android.models.ModerationAction
+import io.getstream.chat.android.models.SyncStatus
 import io.getstream.chat.android.models.User
 
 /**
@@ -32,6 +35,10 @@ public fun Message.isMine(chatClient: ChatClient): Boolean = chatClient.clientSt
 @InternalStreamChatApi
 public fun Message.isMine(currentUser: User?): Boolean = currentUser?.id == user.id
 
+@InternalStreamChatApi
+public fun Message.shouldShowMessageStatusIndicator(): Boolean =
+    !isEphemeral() && !isDeleted() && syncStatus != SyncStatus.FAILED_PERMANENTLY
+
 /**
  * @return if the message failed at moderation or not.
  */

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/list/adapter/viewholder/decorator/internal/FootnoteDecorator.kt

@@ -31,6 +31,7 @@ import io.getstream.chat.android.ui.ChatUI
 import io.getstream.chat.android.ui.R
 import io.getstream.chat.android.ui.common.helper.DateFormatter
 import io.getstream.chat.android.ui.common.state.messages.list.DeletedMessageVisibility
+import io.getstream.chat.android.ui.common.utils.extensions.shouldShowMessageStatusIndicator
 import io.getstream.chat.android.ui.feature.messages.list.MessageListItemStyle
 import io.getstream.chat.android.ui.feature.messages.list.MessageListViewStyle
 import io.getstream.chat.android.ui.feature.messages.list.adapter.MessageListItem
@@ -389,11 +390,13 @@ internal class FootnoteDecorator(
             SyncStatus.SYNC_NEEDED,
             SyncStatus.AWAITING_ATTACHMENTS,
             -> itemStyle.iconIndicatorPendingSync
+
             SyncStatus.COMPLETED -> when {
                 data.isMessageRead -> itemStyle.iconIndicatorRead
                 data.isMessageDelivered -> itemStyle.iconIndicatorDelivered
                 else -> itemStyle.iconIndicatorSent
             }
+
             else -> null
         }
         if (statusIndicator != null) {
@@ -422,13 +425,8 @@ internal class FootnoteDecorator(
     }
 
     private fun shouldHideReadRelatedInfo(data: MessageListItem.MessageItem): Boolean {
-        val status = data.message.syncStatus
         val isNotBottomPosition = data.isNotBottomPosition()
         val isTheirs = data.isTheirs
-        val isEphemeral = data.message.isEphemeral()
-        val isDeleted = data.message.isDeleted()
-        val isFailedPermanently = status == SyncStatus.FAILED_PERMANENTLY
-
-        return isNotBottomPosition || isTheirs || isEphemeral || isDeleted || isFailedPermanently
+        return isNotBottomPosition || isTheirs || !data.message.shouldShowMessageStatusIndicator()
     }
 }