Skip to content

Commit 662bd05

Browse files
committed
Do not expose ChatClient.markMessagesAsDelivered
1 parent c8b8866 commit 662bd05

File tree

3 files changed

+0
-44
lines changed

3 files changed

+0
-44
lines changed

stream-chat-android-client/api/stream-chat-android-client.api

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ public final class io/getstream/chat/android/client/ChatClient {
114114
public static synthetic fun keystroke$default (Lio/getstream/chat/android/client/ChatClient;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;ILjava/lang/Object;)Lio/getstream/result/call/Call;
115115
public final fun markAllRead ()Lio/getstream/result/call/Call;
116116
public final fun markMessageRead (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/getstream/result/call/Call;
117-
public final fun markMessagesAsDelivered (Ljava/util/List;)Lio/getstream/result/call/Call;
118117
public final fun markRead (Ljava/lang/String;Ljava/lang/String;)Lio/getstream/result/call/Call;
119118
public final fun markThreadRead (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/getstream/result/call/Call;
120119
public final fun markThreadUnread (Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/getstream/result/call/Call;

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2911,21 +2911,6 @@ internal constructor(
29112911
}
29122912
}
29132913

2914-
/**
2915-
* Marks the given messages as delivered.
2916-
*
2917-
* @param messages The list of messages to mark as delivered.
2918-
*/
2919-
@CheckResult
2920-
public fun markMessagesAsDelivered(messages: List<Message>): Call<Unit> =
2921-
api.markDelivered(messages)
2922-
.doOnStart(userScope) {
2923-
logger.d { "[markMessagesAsDelivered] #doOnStart; messages: ${messages.size}" }
2924-
}
2925-
.doOnResult(userScope) { result ->
2926-
logger.v { "[markMessagesAsDelivered] #doOnResult; completed: $result" }
2927-
}
2928-
29292914
/**
29302915
* Marks a given thread as read.
29312916
*

stream-chat-android-client/src/test/java/io/getstream/chat/android/client/ChatClientChannelApiTests.kt

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ import io.getstream.chat.android.randomExtraData
4444
import io.getstream.chat.android.randomInt
4545
import io.getstream.chat.android.randomMember
4646
import io.getstream.chat.android.randomMessage
47-
import io.getstream.chat.android.randomMessageList
4847
import io.getstream.chat.android.randomString
4948
import io.getstream.chat.android.randomUser
5049
import io.getstream.result.Error
@@ -988,33 +987,6 @@ internal class ChatClientChannelApiTests : BaseChatClientTest() {
988987
verifyNetworkError(result, errorCode)
989988
}
990989

991-
@Test
992-
fun markMessagesAsDeliveredSuccess() = runTest {
993-
// given
994-
val messages = randomMessageList(10)
995-
val sut = Fixture()
996-
.givenMarkDeliveredResult(RetroSuccess(Unit).toRetrofitCall())
997-
.get()
998-
// when
999-
val result = sut.markMessagesAsDelivered(messages).await()
1000-
// then
1001-
verifySuccess(result, Unit)
1002-
}
1003-
1004-
@Test
1005-
fun markMessagesAsDeliveredError() = runTest {
1006-
// given
1007-
val messages = randomMessageList(10)
1008-
val errorCode = positiveRandomInt()
1009-
val sut = Fixture()
1010-
.givenMarkDeliveredResult(RetroError<Unit>(errorCode).toRetrofitCall())
1011-
.get()
1012-
// when
1013-
val result = sut.markMessagesAsDelivered(messages).await()
1014-
// then
1015-
verifyNetworkError(result, errorCode)
1016-
}
1017-
1018990
@Test
1019991
fun markReadSuccess() = runTest {
1020992
// given

0 commit comments

Comments
 (0)