Prevent default notification channel creation if notifications are disabled (#6054)

* Prevent default notification channel created before it is required.

* Prevent default notification channel created before it is required.

* Update CHANGELOG.

Author: VelikovPetar

CHANGELOG.md

@@ -12,6 +12,7 @@
 
 ## stream-chat-android-client
 ### 🐞 Fixed
+- Fix default notification channel created even if SDK notifications are disabled. [#6054](https://github.com/GetStream/stream-chat-android/pull/6054)
 
 ### ⬆️ Improved
 

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt

@@ -5000,10 +5000,7 @@ internal constructor(
                     clientScope = clientScope,
                     userScope = userScope,
                     config = config,
-                    notificationsHandler = notificationsHandler ?: NotificationHandlerFactory.createNotificationHandler(
-                        context = appContext,
-                        notificationConfig = notificationConfig,
-                    ),
+                    notificationsHandler = notificationsHandler,
                     apiModelTransformers = apiModelTransformers,
                     fileTransformer = fileTransformer,
                     fileUploader = fileUploader,

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/di/ChatModule.kt

@@ -67,6 +67,7 @@ import io.getstream.chat.android.client.notifications.ChatNotificationsImpl
 import io.getstream.chat.android.client.notifications.NoOpChatNotifications
 import io.getstream.chat.android.client.notifications.handler.NotificationConfig
 import io.getstream.chat.android.client.notifications.handler.NotificationHandler
+import io.getstream.chat.android.client.notifications.handler.NotificationHandlerFactory
 import io.getstream.chat.android.client.parser.ChatParser
 import io.getstream.chat.android.client.parser2.MoshiChatParser
 import io.getstream.chat.android.client.plugins.requests.ApiRequestsAnalyser
@@ -124,7 +125,7 @@ constructor(
     private val clientScope: ClientScope,
     private val userScope: UserScope,
     private val config: ChatClientConfig,
-    private val notificationsHandler: NotificationHandler,
+    private val notificationsHandler: NotificationHandler?,
     private val apiModelTransformers: ApiModelTransformers,
     private val fileTransformer: FileTransformer,
     private val fileUploader: FileUploader?,
@@ -164,7 +165,7 @@ constructor(
     }
     private val socketFactory: SocketFactory by lazy { SocketFactory(moshiParser, tokenManager, headersUtil) }
 
-    private val defaultNotifications by lazy { buildNotification(notificationsHandler, config.notificationConfig) }
+    private val defaultNotifications by lazy { buildChatNotifications(notificationsHandler, config.notificationConfig) }
     private val defaultApi by lazy { buildApi(config) }
     internal val chatSocket: ChatSocket by lazy { buildChatSocket(config) }
     private val defaultFileUploader by lazy {
@@ -203,15 +204,26 @@ constructor(
 
     //endregion
 
-    private fun buildNotification(
-        handler: NotificationHandler,
+    private fun buildChatNotifications(
+        handler: NotificationHandler?,
         notificationConfig: NotificationConfig,
     ): ChatNotifications = if (notificationConfig.pushNotificationsEnabled) {
-        ChatNotificationsImpl(handler, notificationConfig, appContext, defaultApi)
+        ChatNotificationsImpl(
+            handler = handler ?: defaultNotificationHandler(notificationConfig),
+            notificationConfig = notificationConfig,
+            context = appContext,
+            api = defaultApi,
+        )
     } else {
         NoOpChatNotifications
     }
 
+    private fun defaultNotificationHandler(notificationConfig: NotificationConfig): NotificationHandler =
+        NotificationHandlerFactory.createNotificationHandler(
+            context = appContext,
+            notificationConfig = notificationConfig,
+        )
+
     private fun buildRetrofit(
         endpoint: String,
         timeout: Long,

stream-chat-android-client/src/main/java/io/getstream/chat/android/client/notifications/handler/MessagingStyleNotificationHandler.kt

@@ -69,16 +69,18 @@ internal class MessagingStyleNotificationHandler(
         }
     }
 
-    private val factory: MessagingStyleNotificationFactory = MessagingStyleNotificationFactory(
-        context = context,
-        notificationManager = notificationManager,
-        notificationChannelId = getNotificationChannelId(),
-        userIconBuilder = userIconBuilder,
-        newMessageIntent = newMessageIntent,
-        notificationTextFormatter = notificationTextFormatter,
-        actionsProvider = actionsProvider,
-        notificationBuilderTransformer = notificationBuilderTransformer,
-    )
+    private val factory: MessagingStyleNotificationFactory by lazy {
+        MessagingStyleNotificationFactory(
+            context = context,
+            notificationManager = notificationManager,
+            notificationChannelId = getNotificationChannelId(),
+            userIconBuilder = userIconBuilder,
+            newMessageIntent = newMessageIntent,
+            notificationTextFormatter = notificationTextFormatter,
+            actionsProvider = actionsProvider,
+            notificationBuilderTransformer = notificationBuilderTransformer,
+        )
+    }
 
     override fun onNotificationPermissionStatus(status: NotificationPermissionStatus) {
         when (status) {