Use component factory when rendering message attachments#6133
Draft
Use component factory when rendering message attachments#6133
Conversation
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This PR finishes the restructuring of the message content, where instead of using attachment factories, we just delegate to the component factory.
Implementation
MessageAttachmentsContent(which was using the attachment factories) and directly call the component factory for the remaining attachment types: links, recordings, unknown/customcontentparameter fromFileAttachmentFactoryand updated examples🎨 UI Changes
There should be no UI changes here. The redesign of audio & file attachments is coming in the next PR.
Testing
Can be tested in the sample by checking messages with different attachments