Merge pull request #542 from GetStream/ignore-already-exists-error

fix: ignore already exists error for message resend

Author: szuperaz

projects/stream-chat-angular/src/lib/channel.service.spec.ts

@@ -1436,6 +1436,38 @@ describe('ChannelService', () => {
     expect(latestMessage.status).toBe('received');
   });
 
+  it('should ignore error if resend failed because message already exists', async () => {
+    await init();
+    let latestMessage!: StreamMessage;
+    service.activeChannelMessages$.subscribe((m) => {
+      latestMessage = m[m.length - 1];
+    });
+    latestMessage.status = 'failed';
+    let channel!: Channel<DefaultStreamChatGenerics>;
+    service.activeChannel$.pipe(first()).subscribe((c) => (channel = c!));
+    spyOn(channel, 'sendMessage').and.rejectWith({
+      code: 4,
+      status: 400,
+      response: {
+        data: {
+          message:
+            'SendMessage failed with error: "a message with ID zitaszuperagetstreamio-9005f6d8-aeb7-42a1-984c-921f94567759 already exists"',
+        },
+      },
+    });
+    spyOn(channel.state, 'addMessageSorted').and.callThrough();
+    await service.resendMessage(latestMessage);
+
+    expect(channel.state.addMessageSorted).toHaveBeenCalledWith(
+      jasmine.objectContaining({
+        status: 'received',
+      }),
+      true
+    );
+
+    expect(latestMessage.status).toBe('received');
+  });
+
   it('should set message state while sending', async () => {
     await init();
     let channel!: Channel<DefaultStreamChatGenerics>;

projects/stream-chat-angular/src/lib/channel.service.ts

@@ -801,7 +801,7 @@ export class ChannelService<
       },
       true
     );
-    await this.sendMessageRequest(message);
+    return this.sendMessageRequest(message, undefined, true);
   }
 
   /**
@@ -1009,7 +1009,8 @@ export class ChannelService<
 
   private async sendMessageRequest(
     preview: MessageResponse<T> | StreamMessage<T>,
-    customData?: Partial<T['messageType']>
+    customData?: Partial<T['messageType']>,
+    isResend = false
   ) {
     const channel = this.activeChannelSubject.getValue()!;
     const isThreadReply = !!preview.parent_id;
@@ -1046,17 +1047,32 @@ export class ChannelService<
         .subscribe((m) => (messages = m));
       const newMessage = messages[messages.length - 1]!;
       return newMessage;
-    } catch (error) {
+    } catch (error: any) {
       const stringError = JSON.stringify(error);
-      const parsedError: { status?: number } = stringError
-        ? (JSON.parse(stringError) as { status?: number })
-        : {};
+      const parsedError: {
+        status?: number;
+        code?: number;
+        response?: { data?: { message?: string } };
+      } = stringError ? (JSON.parse(stringError) as { status?: number }) : {};
+
+      let isAlreadyExists = false;
+      if (isResend) {
+        if (
+          parsedError.status === 400 &&
+          parsedError.code === 4 &&
+          parsedError?.response?.data?.message?.includes('already exists')
+        ) {
+          isAlreadyExists = true;
+        }
+      }
 
       channel.state.addMessageSorted(
         {
           ...(preview as MessageResponse<T>),
-          errorStatusCode: parsedError.status || undefined,
-          status: 'failed',
+          errorStatusCode: isAlreadyExists
+            ? undefined
+            : parsedError.status || undefined,
+          status: isAlreadyExists ? 'received' : 'failed',
         },
         true
       );