Skip to content

Commit 938ca9c

Browse files
authored
Merge pull request #686 from GetStream/fix-voice-recording
Fix voice recording
2 parents 3ccd3fd + 1e940b9 commit 938ca9c

File tree

5 files changed

+11
-4
lines changed

5 files changed

+11
-4
lines changed

.github/workflows/workflow.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
- master
66
- angular-19
77
- test-update
8+
- fix-voice-recording
89
pull_request:
910
branches:
1011
- master

package.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,11 @@
4545
"prerelease": true,
4646
"channel": "beta"
4747
},
48+
{
49+
"name": "fix-voice-recording",
50+
"prerelease": true,
51+
"channel": "beta"
52+
},
4853
{
4954
"name": "5.x.x-beta",
5055
"prerelease": true,

projects/stream-chat-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "stream-chat-angular",
3-
"version": "5.12.3",
3+
"version": "5.12.4-fix-voice-recording.1",
44
"description": "Angular components to create chat conversations or livestream style chat",
55
"author": "GetStream",
66
"homepage": "https://getstream.io/chat/",
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
export const version = '5.12.3';
1+
export const version = '5.12.4-fix-voice-recording.1';

projects/stream-chat-angular/src/lib/voice-recorder/audio-recorder.service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { Injectable, NgModule } from '@angular/core';
22
import { AmplitudeRecorderService } from './amplitude-recorder.service';
3-
import { isSafari } from '../is-safari';
43
import { MediaRecorderConfig, MultimediaRecorder } from './media-recorder';
54
import { NotificationService } from '../notification.service';
65
import { ChatClientService } from '../chat-client.service';
@@ -21,7 +20,9 @@ export class AudioRecorderService extends MultimediaRecorder<
2120
* - For all other browsers we use audio/webm (which is then transcoded to wav)
2221
*/
2322
config: MediaRecorderConfig = {
24-
mimeType: isSafari() ? 'audio/mp4;codecs=mp4a.40.2' : 'audio/webm',
23+
mimeType: MediaRecorder.isTypeSupported('audio/webm')
24+
? 'audio/webm'
25+
: 'audio/mp4;codecs=mp4a.40.2', // fallback for Safari
2526
};
2627

2728
constructor(

0 commit comments

Comments
 (0)