Skip to content

Commit a5136b5

Browse files
committed
feat: make sure channels$ stream never closes
BREAKING CHANGE: `options.keepAliveChannels$OnError` is no longer necessary, and has been removed
1 parent 1780eb2 commit a5136b5

38 files changed

+275
-284
lines changed

docusaurus/angular_versioned_docs/version-5/basics/upgrade-v4.mdx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,10 @@ The `ImageLoadService` is now removed. It's no longer required since the SDK use
108108

109109
The `ChannelListToggleService` is now removed as it was only used in theme-v1. For theme-v2 please refer to the [responsive layout guide](../code-examples/responsive-layout.mdx).
110110

111+
### Channel query error handling
112+
113+
In previous versions if an error occured during channel load, the `channelService.channels$` Observable emitted an error, which would close the stream. Users would have to reload the page to be able to reinitialize the `ChannelService`. This isn't a sensible default behavior. From version 5 the `channels$` Observable will never emit an error, the channel query result can be observed using the [`channelService.channelQueryState$`](../../services/ChannelService/#channelquerystate). With this change the `options.keepAliveChannels$OnError` is no longer necessary, and has been removed.
114+
111115
### Type changes
112116

113117
- Event handlers with `Function` type are changed to `() => void`

docusaurus/angular_versioned_docs/version-5/components/AttachmentListComponent.mdx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ The id of the message the attachments belong to
122122

123123
#### Defined in
124124

125-
[projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:39](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L39)
125+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:39](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L39)
126126

127127
---
128128

@@ -134,7 +134,7 @@ The parent id of the message the attachments belong to
134134

135135
#### Defined in
136136

137-
[projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:43](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L43)
137+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:43](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L43)
138138

139139
---
140140

@@ -146,7 +146,7 @@ The attachments to display
146146

147147
#### Defined in
148148

149-
[projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:47](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L47)
149+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:47](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L47)
150150

151151
---
152152

@@ -158,6 +158,6 @@ Emits the state of the image carousel window
158158

159159
#### Defined in
160160

161-
[projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:51](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L51)
161+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts:51](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.ts#L51)
162162

163163
[//]: # "End of generated content"

docusaurus/angular_versioned_docs/version-5/components/AttachmentPreviewListComponent.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ A stream that emits the current file uploads and their states
4747

4848
#### Defined in
4949

50-
[projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:17](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L17)
50+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:17](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L17)
5151

5252
---
5353

@@ -59,7 +59,7 @@ An output to notify the parent component if the user tries to retry a failed upl
5959

6060
#### Defined in
6161

62-
[projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:21](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L21)
62+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:21](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L21)
6363

6464
---
6565

@@ -71,6 +71,6 @@ An output to notify the parent component if the user wants to delete a file
7171

7272
#### Defined in
7373

74-
[projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:25](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L25)
74+
[stream-chat-angular/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts:25](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/attachment-preview-list/attachment-preview-list.component.ts#L25)
7575

7676
[//]: # "End of generated content"

docusaurus/angular_versioned_docs/version-5/components/AutocompleteTextareaComponent.mdx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ TextareaInterface.value
5151

5252
#### Defined in
5353

54-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:49](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L49)
54+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:49](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L49)
5555

5656
---
5757

@@ -67,7 +67,7 @@ TextareaInterface.placeholder
6767

6868
#### Defined in
6969

70-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:53](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L53)
70+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:53](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L53)
7171

7272
---
7373

@@ -83,7 +83,7 @@ TextareaInterface.areMentionsEnabled
8383

8484
#### Defined in
8585

86-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:57](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L57)
86+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:57](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L57)
8787

8888
---
8989

@@ -99,7 +99,7 @@ TextareaInterface.inputMode
9999

100100
#### Defined in
101101

102-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:61](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L61)
102+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:61](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L61)
103103

104104
---
105105

@@ -115,7 +115,7 @@ TextareaInterface.mentionScope
115115

116116
#### Defined in
117117

118-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:65](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L65)
118+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:65](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L65)
119119

120120
---
121121

@@ -131,7 +131,7 @@ TextareaInterface.autoFocus
131131

132132
#### Defined in
133133

134-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:69](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L69)
134+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:69](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L69)
135135

136136
---
137137

@@ -147,7 +147,7 @@ TextareaInterface.valueChange
147147

148148
#### Defined in
149149

150-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:73](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L73)
150+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:73](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L73)
151151

152152
---
153153

@@ -163,7 +163,7 @@ TextareaInterface.send
163163

164164
#### Defined in
165165

166-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:77](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L77)
166+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:77](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L77)
167167

168168
---
169169

@@ -179,6 +179,6 @@ TextareaInterface.userMentions
179179

180180
#### Defined in
181181

182-
[projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:81](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L81)
182+
[stream-chat-angular/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts:81](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/message-input/autocomplete-textarea/autocomplete-textarea.component.ts#L81)
183183

184184
[//]: # "End of generated content"

docusaurus/angular_versioned_docs/version-5/components/AvatarComponent.mdx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ An optional name of the image, used for fallback image or image title (if `image
7171

7272
#### Defined in
7373

74-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:35](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L35)
74+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:35](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L35)
7575

7676
---
7777

@@ -83,7 +83,7 @@ The URL of the image to be displayed. If the image can't be displayed the first
8383

8484
#### Defined in
8585

86-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:39](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L39)
86+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:39](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L39)
8787

8888
---
8989

@@ -95,7 +95,7 @@ The size in pixels of the avatar image.
9595

9696
#### Defined in
9797

98-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:43](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L43)
98+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:43](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L43)
9999

100100
---
101101

@@ -107,7 +107,7 @@ The location the avatar will be displayed in
107107

108108
#### Defined in
109109

110-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:47](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L47)
110+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:47](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L47)
111111

112112
---
113113

@@ -119,7 +119,7 @@ The channel the avatar belongs to (if avatar of a channel is displayed)
119119

120120
#### Defined in
121121

122-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:51](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L51)
122+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:51](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L51)
123123

124124
---
125125

@@ -131,7 +131,7 @@ The user the avatar belongs to (if avatar of a user is displayed)
131131

132132
#### Defined in
133133

134-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:55](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L55)
134+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:55](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L55)
135135

136136
---
137137

@@ -143,7 +143,7 @@ The type of the avatar: channel if channel avatar is displayed, user if user ava
143143

144144
#### Defined in
145145

146-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:59](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L59)
146+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:59](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L59)
147147

148148
---
149149

@@ -155,7 +155,7 @@ If a channel avatar is displayed, and if the channel has exactly two members a g
155155

156156
#### Defined in
157157

158-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:63](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L63)
158+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:63](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L63)
159159

160160
---
161161

@@ -167,6 +167,6 @@ If channel/user image isn't provided the initials of the name of the channel/use
167167

168168
#### Defined in
169169

170-
[projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:67](https://github.com/GetStream/stream-chat-angular/blob/7b41a2694fc8f1b2c1ec325a4b1ac7faf9d826dd/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L67)
170+
[stream-chat-angular/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts:67](https://github.com/GetStream/stream-chat-angular/blob/1780eb2818bdbdaa0627275d4b409e2b7e56d2b0/projects/stream-chat-angular/src/lib/avatar/avatar.component.ts#L67)
171171

172172
[//]: # "End of generated content"

0 commit comments

Comments
 (0)