Skip to content

Commit ae0c825

Browse files
authored
Merge pull request #395 from GetStream/small-fixes
Small fixes
2 parents a856994 + 7820f8c commit ae0c825

File tree

6 files changed

+13
-17
lines changed

6 files changed

+13
-17
lines changed

projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.html

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,12 +189,16 @@
189189
"
190190
></video>
191191
</div>
192-
<div
192+
<a
193193
*ngIf="isFile(attachment)"
194194
class="
195195
str-chat__message-attachment-file--item
196196
str-chat-angular__message-attachment-file-single
197197
"
198+
style="cursor: pointer; text-decoration: none"
199+
data-testclass="file-link"
200+
href="{{ attachment.asset_url }}"
201+
target="_blank"
198202
>
199203
<stream-icon-placeholder
200204
*ngIf="themeVersion === '1'"
@@ -214,7 +218,8 @@
214218
>
215219
{{ attachment.title }}
216220
</div>
217-
<a
221+
<!-- Temporary disabled, will be fixed with this: https://github.com/GetStream/stream-chat-angular/issues/393 -->
222+
<!-- <a
218223
class="str-chat__message-attachment-file--item-download"
219224
data-testclass="file-link"
220225
download
@@ -225,7 +230,7 @@
225230
class="str-chat__message-attachment-download-icon"
226231
icon="download"
227232
></stream-icon-placeholder>
228-
</a>
233+
</a> -->
229234
</div>
230235
<span
231236
class="str-chat__message-attachment-file--item-size"
@@ -234,7 +239,7 @@
234239
>{{ getFileSize(attachment) }}</span
235240
>
236241
</div>
237-
</div>
242+
</a>
238243
<div
239244
*ngIf="
240245
isCard(attachment) &&

projects/stream-chat-angular/src/lib/attachment-list/attachment-list.component.spec.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,6 @@ describe('AttachmentListComponent', () => {
424424
const link = queryFileLinks()[0];
425425
const titleElement = queryFileNames()[0];
426426

427-
expect(link.hasAttribute('download')).toBeTrue();
428427
expect(link.href).toContain(asset_url);
429428
expect(titleElement.textContent).toContain(title);
430429
});
@@ -467,7 +466,6 @@ describe('AttachmentListComponent', () => {
467466
fixture.detectChanges();
468467
const link = queryFileLinks()[0];
469468

470-
expect(link.hasAttribute('download')).toBeTrue();
471469
expect(link.href).toContain('unsafe:' + asset_url);
472470
});
473471

projects/stream-chat-angular/src/lib/message-actions-box/message-actions-box.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
<button
2828
class="str-chat__message-actions-list-item-button"
2929
[attr.data-testid]="actionName + '-action'"
30-
(click)="actionHandler()"
30+
(click)="actionHandler(message, isMine)"
3131
>
3232
<li class="str-chat__message-actions-list-item">
3333
{{ getActionLabel(actionLabelOrTranslationKey) | translate }}

projects/stream-chat-angular/src/lib/message-actions-box/message-actions-box.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ describe('MessageActionsBoxComponent', () => {
225225

226226
expect(channelService.pinMessage).toHaveBeenCalledWith(component.message);
227227

228-
component.message!.pinned = true;
228+
component.message = { ...component.message!, pinned: true };
229229
action?.click();
230230
fixture.detectChanges();
231231

projects/stream-chat-angular/src/lib/message-actions-box/message-actions-box.component.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,6 @@ export class MessageActionsBoxComponent implements OnChanges, OnDestroy {
164164

165165
ngOnChanges(changes: SimpleChanges): void {
166166
if (changes.isMine || changes.enabledActions || changes.message) {
167-
this.messageActionItems.forEach(
168-
(i) =>
169-
(i.actionHandler = i.actionHandler.bind(
170-
this,
171-
this.message!,
172-
this.isMine
173-
))
174-
);
175167
this.visibleMessageActionItems = this.messageActionItems.filter((item) =>
176168
item.isVisible(this.enabledActions, this.isMine, this.message!)
177169
);

projects/stream-chat-angular/src/lib/message-list/message-list.component.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@
55
(scroll)="scrolled()"
66
>
77
<div class="str-chat__reverse-infinite-scroll str-chat__message-list-scroll">
8-
<ul class="str-chat__ul">
8+
<ul class="str-chat__ul" style="-webkit-transform: translate3d(0, 0, 0)">
99
<li
1010
#parentMessageElement
1111
*ngIf="mode === 'thread'"
1212
data-testid="parent-message"
1313
class="str-chat__parent-message-li"
14+
style="-webkit-transform: translate3d(0, 0, 0)"
1415
>
1516
<ng-container
1617
*ngTemplateOutlet="

0 commit comments

Comments
 (0)