fix: Close thread if parent message removed from state

Author: szuperaz

projects/stream-chat-angular/src/lib/channel.service.thread.spec.ts

@@ -162,6 +162,19 @@ describe('ChannelService - threads', () => {
     });
   });
 
+  it('should handle if selected parent message is removed from message list', async () => {
+    await init();
+    let parentMessage!: StreamMessage;
+    service.activeChannelMessages$.subscribe((m) => (parentMessage = m[0]));
+    parentMessage.id = 'parentMessage';
+    service.activeParentMessage$.subscribe();
+    await service.setAsActiveParentMessage(parentMessage);
+    spyOn(service, 'setAsActiveParentMessage').and.callThrough();
+    await service.jumpToMessage('message-very-far-away');
+
+    expect(service.setAsActiveParentMessage).toHaveBeenCalledWith(undefined);
+  });
+
   it(`shouldn't deselect message to quote, if not a thread reply`, async () => {
     await init();
     const messageToQuoteSpy = jasmine.createSpy();

projects/stream-chat-angular/src/lib/channel.service.ts

@@ -6,7 +6,7 @@ import {
   ReplaySubject,
   Subscription,
 } from 'rxjs';
-import { filter, first, map, shareReplay } from 'rxjs/operators';
+import { filter, first, map, shareReplay, tap } from 'rxjs/operators';
 import {
   Attachment,
   Channel,
@@ -343,7 +343,13 @@ export class ChannelService<
           if (!parentMessageId) {
             return undefined;
           } else {
-            return messages.find((m) => m.id === parentMessageId);
+            const message = messages.find((m) => m.id === parentMessageId);
+            if (!message) {
+              this.setAsActiveParentMessage(undefined);
+              return undefined;
+            } else {
+              return message;
+            }
           }
         }
       ),

projects/stream-chat-angular/src/lib/message-list/message-list.component.ts

@@ -368,6 +368,7 @@ export class MessageListComponent
       tap((messages) => {
         this.isLatestMessageInList =
           !this.latestMessage ||
+          messages.length === 0 ||
           messages[messages.length - 1].id === this.latestMessage.id;
         if (!this.isLatestMessageInList) {
           this.isUserScrolled = true;