Skip to content

Commit e2f2e6f

Browse files
author
Rafael Marinho
committed
refactor
1 parent 29208a6 commit e2f2e6f

File tree

5 files changed

+41
-231
lines changed

5 files changed

+41
-231
lines changed

src/main/java/io/getstream/chat/java/models/Channel.java

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import io.getstream.chat.java.models.Channel.ChannelTruncateRequestData.ChannelTruncateRequest;
1818
import io.getstream.chat.java.models.Channel.ChannelUnMuteRequestData.ChannelUnMuteRequest;
1919
import io.getstream.chat.java.models.Channel.ChannelUpdateRequestData.ChannelUpdateRequest;
20+
import io.getstream.chat.java.models.Channel.MarkDeliveredRequestData.MarkDeliveredRequest;
2021
import io.getstream.chat.java.models.ChannelType.BlocklistBehavior;
2122
import io.getstream.chat.java.models.ChannelType.ChannelTypeWithCommands;
2223
import io.getstream.chat.java.models.Message.MessageRequestObject;
@@ -1202,6 +1203,27 @@ protected Call<ChannelMemberResponse> generateCall(Client client) {
12021203
}
12031204
}
12041205

1206+
@Builder(
1207+
builderClassName = "MarkDeliveredRequest",
1208+
builderMethodName = "",
1209+
buildMethodName = "internalBuild")
1210+
public static class MarkDeliveredRequestData {
1211+
@Nullable
1212+
@JsonProperty("user_id")
1213+
private String userId;
1214+
1215+
@Nullable
1216+
@JsonProperty("user")
1217+
private UserRequestObject user;
1218+
1219+
public static class MarkDeliveredRequest extends StreamRequest<StreamResponseObject> {
1220+
@Override
1221+
protected Call<StreamResponseObject> generateCall(Client client) {
1222+
return client.create(ChannelService.class).markDelivered(this.internalBuild());
1223+
}
1224+
}
1225+
}
1226+
12051227
@Data
12061228
@NoArgsConstructor
12071229
@EqualsAndHashCode(callSuper = true)
@@ -1757,4 +1779,14 @@ public static ChannelMemberPartialUpdateRequest unarchive(
17571779
@NotNull String type, @NotNull String id, @NotNull String userId) {
17581780
return new ChannelMemberPartialUpdateRequest(type, id, userId).setValue("archived", false);
17591781
}
1782+
1783+
/**
1784+
* Creates a mark delivered request
1785+
*
1786+
* @return the created request
1787+
*/
1788+
@NotNull
1789+
public static MarkDeliveredRequest markDelivered() {
1790+
return new MarkDeliveredRequest();
1791+
}
17601792
}

src/main/java/io/getstream/chat/java/models/MarkDeliveredOptions.java

Lines changed: 0 additions & 94 deletions
This file was deleted.

src/main/java/io/getstream/chat/java/services/ChannelService.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import io.getstream.chat.java.models.Channel;
44
import io.getstream.chat.java.models.Channel.*;
5-
import io.getstream.chat.java.models.MarkDeliveredOptions;
65
import io.getstream.chat.java.models.framework.StreamResponseObject;
76
import io.getstream.chat.java.services.framework.ToJson;
87
import org.jetbrains.annotations.NotNull;
@@ -106,7 +105,6 @@ Call<ChannelMemberResponse> updateMemberPartial(
106105
@NotNull @Body ChannelMemberPartialUpdateRequestData updateMemberPartialRequestData);
107106

108107
@POST("channels/delivered")
109-
Call<MarkDeliveredOptions.MarkDeliveredResponse> markChannelsDelivered(
110-
@NotNull @Body MarkDeliveredOptions markDeliveredOptions,
111-
@NotNull @Query("user_id") String userId);
108+
Call<StreamResponseObject> markDelivered(
109+
@NotNull @Body MarkDeliveredRequestData markDeliveredOptions);
112110
}

src/test/java/io/getstream/chat/java/ChannelTest.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,4 +624,11 @@ void whenPartialUpdateMember_thenNoException() {
624624
Assertions.assertEquals("updated_value1", updatedMember.getAdditionalFields().get("field1"));
625625
Assertions.assertEquals("value2", updatedMember.getAdditionalFields().get("field2"));
626626
}
627+
628+
@DisplayName("Can mark messages delivered")
629+
@Test
630+
void whenMarkingDelivered_thenNoException() {
631+
Assertions.assertDoesNotThrow(
632+
() -> Channel.markDelivered().user(testUserRequestObject).request());
633+
}
627634
}

src/test/java/io/getstream/chat/java/DeliveryReceiptsTest.java

Lines changed: 0 additions & 133 deletions
This file was deleted.

0 commit comments

Comments
 (0)