Skip to content

Commit 4d1b395

Browse files
Adjust tests
1 parent 81c0594 commit 4d1b395

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

test/unit/channel.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ describe('Channel _handleChannelEvent', function () {
652652

653653
await channel.query();
654654

655-
expect(Object.keys(channel.state.members).length).to.be.eq(2);
655+
expect(Object.keys(channel.state.members).length).to.be.eq(1);
656656
expect(Object.keys(channel.state.watchers).length).to.be.eq(1);
657657
expect(Object.keys(channel.state.read).length).to.be.eq(1);
658658
expect(channel.state.messages.length).to.be.eq(1);
@@ -1217,8 +1217,7 @@ describe('Channel lastMessage', async () => {
12171217
});
12181218

12191219
describe('Channel _initializeState', () => {
1220-
// FIXME: unwatching should remove members manually, not through state initialization
1221-
it.skip('should not keep members that have unwatched since last watch', async () => {
1220+
it('should not keep members that have unwatched since last watch', async () => {
12221221
const client = await getClientWithUser();
12231222
const channel = client.channel('messaging', uuidv4());
12241223

test/unit/threads.test.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ describe('Threads 2.0', () => {
4848
beforeEach(() => {
4949
client = new StreamChat('apiKey');
5050
client._setUser({ id: TEST_USER_ID });
51-
channelResponse = generateChannel({ channel: { id: uuidv4(), name: 'Test channel' } }).channel as ChannelResponse;
51+
channelResponse = generateChannel({
52+
channel: { id: uuidv4(), name: 'Test channel', members: [] },
53+
}).channel as ChannelResponse;
5254
channel = client.channel(channelResponse.type, channelResponse.id);
5355
parentMessageResponse = generateMsg() as MessageResponse;
5456
threadManager = new ThreadManager({ client });
@@ -57,12 +59,16 @@ describe('Threads 2.0', () => {
5759
describe('Thread', () => {
5860
it('initializes properly', () => {
5961
const threadResponse = generateThreadResponse(channelResponse, parentMessageResponse);
62+
// mimic pre-cached channel with existing members
63+
channel._hydrateMembers({ members: [{ user: { id: TEST_USER_ID } }] });
6064
const thread = new Thread({ client, threadData: threadResponse });
6165
const state = thread.state.getLatestValue();
6266

67+
expect(threadResponse.channel.members).to.have.lengthOf(0);
6368
expect(threadResponse.read).to.have.lengthOf(0);
6469
expect(state.read).to.have.keys([TEST_USER_ID]);
6570

71+
expect(thread.channel.state.members).to.have.keys([TEST_USER_ID]);
6672
expect(thread.id).to.equal(parentMessageResponse.id);
6773
expect(thread.channel.data?.name).to.equal(channelResponse.name);
6874
});

0 commit comments

Comments
 (0)